linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] MTD: atmel_nand: Add DMA support to access Nandflash
Date: Tue, 18 Jan 2011 10:35:16 +1300	[thread overview]
Message-ID: <4D34B614.3000909@bluewatersys.com> (raw)
In-Reply-To: <1295248809-30334-2-git-send-email-hong.xu@atmel.com>

On 01/17/2011 08:20 PM, Hong Xu wrote:
> Some SAM9 chips have the ability to perform DMA between CPU and SMC controller.
> This patch adds DMA support for SAM9RL, SAM9G45, SSAM9G46,AM9M10, SAM9M11.
> 
> Signed-off-by: Hong Xu <hong.xu@atmel.com>
> ---

One more comment:

> +	if (cpu_has_dma() && use_dma) {
> +		dma_cap_mask_t mask;
> +
> +		dma_cap_zero(mask);
> +		dma_cap_set(DMA_MEMCPY, mask);
> +		host->dma_chan = dma_request_channel(mask, 0, NULL);
> +
> +		if (!host->dma_chan) {
> +			dev_err(host->dev, "Failed to request DMA channel\n");
> +			host->dma_ready = 0;

Because host is kzalloc'ed above, you do not need to set host->dma_ready
to zero here.

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

  parent reply	other threads:[~2011-01-17 21:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <hong.xu@atmel.com>
2011-01-18  6:36 ` [PATCH] MTD: atmel_nand: Add DMA support to access Nandflash Hong Xu
2011-01-21 11:23   ` Artem Bityutskiy
2011-07-08 15:36   ` Ryan Mallon
2011-07-08 16:43 ` Hong Xu
2011-01-17 20:15   ` Ryan Mallon
2011-01-17 22:42     ` Ryan Mallon
2011-01-18  1:43       ` Xu, Hong
2011-01-18  2:44         ` Ryan Mallon
2011-01-17 21:35   ` Ryan Mallon [this message]
2011-07-08 17:32 ` Hong Xu
2011-01-18  3:08   ` Ryan Mallon
2011-01-18  6:17     ` 答复: " Xu, Hong
2011-01-18  3:02 Hong Xu
  -- strict thread matches above, loose matches on Subject: below --
2011-01-14  9:34 Hong Xu
2011-01-14 10:00 ` Jamie Iles
2011-01-14 11:43 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D34B614.3000909@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).