From: skannan@codeaurora.org (Saravana Kannan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drivers: mmc: msm: remove clock disable in probe
Date: Thu, 20 Jan 2011 19:24:05 -0800 [thread overview]
Message-ID: <4D38FC55.2030601@codeaurora.org> (raw)
In-Reply-To: <AANLkTim-=40MM=TeH1XSQ-rio1ctwcZAs4qbf9SaxmdH@mail.gmail.com>
On 01/19/2011 02:50 AM, Vitaly Wool wrote:
> Hi,
>
> On Tue, Jan 18, 2011 at 7:14 PM, Daniel Walker<dwalker@codeaurora.org> wrote:
>> The probe function adds the MMC host which can start accepting request
>> immediately. There is an assumption here that no requests happen
>> immediatly, but it's not always the case. This assumption can causes
>> a BUG() when the clocks are disabled. The fix is to just remove the
>> clock disable in the probe function.
>>
>> Signed-off-by: Daniel Walker<dwalker@codeaurora.org>
>
> I can add acked-by and/or tested-by if needed.
>
> ~Vitaly
Nack from me. The fix is incorrect. The clocks are alread refcounted in
the clock driver. There should be no need to "leave it on because
someone else might access it". Every code that needs the clock should
have a clk_enable/disable around it and it would all work fine.
-Saravana
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-21 3:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 18:14 [PATCH] drivers: mmc: msm: remove clock disable in probe Daniel Walker
2011-01-19 10:50 ` Vitaly Wool
2011-01-21 3:24 ` Saravana Kannan [this message]
2011-01-21 16:58 ` Daniel Walker
2011-01-21 19:16 ` Saravana Kannan
2011-01-24 12:44 ` Sahitya Tummala
2011-01-24 19:40 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D38FC55.2030601@codeaurora.org \
--to=skannan@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).