From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: map ATAGs when not in first 1MB of RAM
Date: Thu, 27 Jan 2011 11:41:30 -0600 [thread overview]
Message-ID: <4D41AE4A.1000105@gmail.com> (raw)
In-Reply-To: <20110127163149.GF25968@n2100.arm.linux.org.uk>
Russell,
On 01/27/2011 10:31 AM, Russell King - ARM Linux wrote:
> On Thu, Jan 27, 2011 at 09:50:43AM -0600, Rob Herring wrote:
>> + /*
>> + * Otherwise map the 1MB region r2 points to (atags or dtb)
>> + */
>> +1: mov r0, r2, lsr #20
>> + mov r0, r0, lsl #20
>> + sub r3, r0, #(PHYS_OFFSET& 0xff000000)
>> + .if (PHYS_OFFSET& 0x00f00000)
>> + sub r3, r3, #(PHYS_OFFSET& 0x00f00000)
>
> This introduces new PHYS_OFFSET uses which we're trying hard to get
> rid of. This will need to be reworked.
Yeah, I didn't really like that either. How about this? It's untested.
It replaces the whole section mapping the 1st 1MB and should make
replacing this instance of PHYS_OFFSET with a variable easier.
/*
* Then map boot params address in r2 or
* the first 1MB of ram if boot params address is not specified.
*/
ldr r3, =PHYS_OFFSET
mov r0, r2, lsr #20
movs r0, r0, lsl #20
moveq r0, r3
sub r3, r0, r3
add r3, r3, #PAGE_OFFSET
add r3, r4, r3, lsr #18
orr r6, r7, r0
str r6, [r3]
Rob
next prev parent reply other threads:[~2011-01-27 17:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-27 15:50 [PATCH] ARM: map ATAGs when not in first 1MB of RAM Rob Herring
2011-01-27 16:31 ` Russell King - ARM Linux
2011-01-27 17:41 ` Rob Herring [this message]
2011-01-27 17:46 ` Russell King - ARM Linux
2011-02-02 3:26 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D41AE4A.1000105@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox