[PATCH 2/3] ARM: S5PV210: Add supplies for CIF camera on GONI board

[snjw23@gmail.com (Sylwester Nawrocki)]

On 01/28/2011 06:32 PM, Kukjin Kim wrote:
> Sylwester Nawrocki wrote:
>>
>> Add regulator supplies required for NOON010PC30 CIF sensor.
>>
>> Signed-off-by: Sylwester Nawrocki<s.nawrocki@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>> ---
>>   arch/arm/mach-s5pv210/mach-goni.c |   24 +++++++++++++++++++++---
>>   1 files changed, 21 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/arm/mach-s5pv210/mach-goni.c
> b/arch/arm/mach-s5pv210/mach-
>> goni.c
>> index fc34575..2051cee 100644
>> --- a/arch/arm/mach-s5pv210/mach-goni.c
>> +++ b/arch/arm/mach-s5pv210/mach-goni.c
>> @@ -273,6 +273,18 @@ static struct regulator_consumer_supply
>> goni_ldo5_consumers[] = {
>>   	REGULATOR_SUPPLY("vmmc", "s3c-sdhci.0"),
>>   };
>>
>> +static struct regulator_consumer_supply goni_ldo11_consumers[] = {
>> +	REGULATOR_SUPPLY("vddio", "0-0030"), /* "CAM_IO_2.8V" */
>> +};
> 
> Need array in goni_ldo11_consumers?
> 
> +static struct regulator_consumer_supply goni_ldo11_consumers =
> +	REGULATOR_SUPPLY("vddio", "0-0030"); /* "CAM_IO_2.8V" */
> 
>> +
... 
>> +
>>   static struct regulator_init_data goni_ldo2_data = {
>>   	.constraints	= {
>>   		.name		= "VALIVE_1.1V",
>> @@ -371,8 +383,10 @@ static struct regulator_init_data goni_ldo11_data = {
>>   		.min_uV		= 2800000,
>>   		.max_uV		= 2800000,
>>   		.apply_uV	= 1,
>> -		.always_on	= 1,
>> +		.valid_ops_mask	= REGULATOR_CHANGE_STATUS,
>>   	},
>> +	.num_consumer_supplies	= ARRAY_SIZE(goni_ldo11_consumers),
>> +	.consumer_supplies	= goni_ldo11_consumers,
> 
> If you modify as per my suggestion, then need to change this like following.
> 
> +	.num_consumer_supplies	= 1,
> +	.consumer_supplies	=&goni_ldo11_consumers,
> 
>>   };

Although the current state of this file is not reflecting it, there is
more devices sharing the regulators I've added supply definitions for,
e.g the second camera in the system.
So the arrays are really needed. If I modify it as you as you are
suggesting then it will have to be changed when the other supplies
are added.


Thanks,
Sylwester