linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: michael.williamson@criticallink.com (Michael Williamson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] davinci: add spi devices support for MityDSP-L138/MityARM-1808 platform
Date: Tue, 01 Feb 2011 07:33:08 -0500	[thread overview]
Message-ID: <4D47FD84.4040302@criticallink.com> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB5930248777A4B@dbde02.ent.ti.com>

Hi Sekhar,

On 2/1/2011 7:21 AM, Nori, Sekhar wrote:

> Hi Mike,
> 
> On Tue, Feb 01, 2011 at 05:35:14, Michael Williamson wrote:
>> This patch adds support for accessing the on board SPI NOR FLASH
>> device for MityDSP-L138 and MityARM-1808 SoMs.
>>
>> Signed-off-by: Michael Williamson <michael.williamson@criticallink.com>
>> Tested-by: Michael Williamson <michael.williamson@criticallink.com>
>> ---
>>  arch/arm/mach-davinci/board-mityomapl138.c |  104 ++++++++++++++++++++++++++++
>>  1 files changed, 104 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/board-mityomapl138.c b/arch/arm/mach-davinci/board-mityomapl138.c
> 
> 
>> +
>> +static struct davinci_spi_platform_data mityomapl138_spi1_pdata = {
>> +	.version	= SPI_VERSION_2,
>> +	.num_chipselect	= 1,
>> +	.intr_line	= 1,
>> +};
> 
> This platform data is better placed in devices-da8xx.c as most of
> it is common across all DA8xx platforms. Only num_chipselect and
> chip_sel array are expected to be board specific so only those should
> be passed on from board files.
> 
> Thanks,
> Sekhar


I will move this to devices-da8xx.c and create a placeholder for spi0.

Thanks.

-Mike

  reply	other threads:[~2011-02-01 12:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-01  0:05 [PATCH 0/4] davinci: Add SPI support for da8xx platforms Michael Williamson
2011-02-01  0:05 ` [PATCH 1/4] davinci: da8xx/omap-l1: add support for SPI Michael Williamson
2011-02-01 11:44   ` Sergei Shtylyov
2011-02-01 12:26     ` Michael Williamson
2011-02-01  0:05 ` [PATCH 2/4] davinci: add spi devices support for MityDSP-L138/MityARM-1808 platform Michael Williamson
2011-02-01 12:21   ` Nori, Sekhar
2011-02-01 12:33     ` Michael Williamson [this message]
2011-02-01  0:05 ` [PATCH 3/4] davinci: add spi devices support for da850/omap-l138/am18x evm Michael Williamson
2011-02-01 11:54   ` Sergei Shtylyov
2011-02-01  0:05 ` [PATCH 4/4] davinci: add spi devices support for da830/omap-l137/am17x evm Michael Williamson
2011-02-01 12:06   ` Sergei Shtylyov
2011-02-01 12:11     ` Nori, Sekhar
2011-02-01 12:43       ` Michael Williamson
2011-02-01 13:01         ` Nori, Sekhar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D47FD84.4040302@criticallink.com \
    --to=michael.williamson@criticallink.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).