linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/11] ARM: integrator: use new init_early for clock tree init
Date: Fri, 04 Feb 2011 13:53:12 -0600	[thread overview]
Message-ID: <4D4C5928.8040809@gmail.com> (raw)
In-Reply-To: <20110204193420.GC8732@n2100.arm.linux.org.uk>

Russell,

On 02/04/2011 01:34 PM, Russell King - ARM Linux wrote:
> On Fri, Feb 04, 2011 at 01:27:20PM -0600, Rob Herring wrote:
>> Russell,
>>
>> On 01/27/2011 07:46 AM, Russell King - ARM Linux wrote:
>>> Initialize the clock tree early.
>>>
>>> Signed-off-by: Russell King<rmk+kernel@arm.linux.org.uk>
>>> ---
>>>    arch/arm/mach-integrator/common.h        |    1 +
>>>    arch/arm/mach-integrator/core.c          |    7 +++++--
>>>    arch/arm/mach-integrator/integrator_ap.c |    3 ++-
>>>    arch/arm/mach-integrator/integrator_cp.c |   11 +++++++++--
>>>    4 files changed, 17 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-integrator/common.h b/arch/arm/mach-integrator/common.h
>>> index 5f96e15..a08f9b0 100644
>>> --- a/arch/arm/mach-integrator/common.h
>>> +++ b/arch/arm/mach-integrator/common.h
>>> @@ -1 +1,2 @@
>>> +void integrator_init_early(void);
>>>    void integrator_reserve(void);
>>> diff --git a/arch/arm/mach-integrator/core.c b/arch/arm/mach-integrator/core.c
>>> index b8e884b..77315b9 100644
>>> --- a/arch/arm/mach-integrator/core.c
>>> +++ b/arch/arm/mach-integrator/core.c
>>> @@ -144,12 +144,15 @@ static struct clk_lookup lookups[] = {
>>>    	}
>>>    };
>>>
>>> +void __init integrator_init_early(void)
>>> +{
>>> +	clkdev_add_table(lookups, ARRAY_SIZE(lookups));
>>> +}
>>> +
>>
>> One potential issue with init_early is kmalloc is not up yet. So moving
>> clock init here will be an issue when/if clocks are converted to device
>> tree or if any platforms do dynamic allocations for their clock tree.
>
> That can't be avoided, because the long term plan is to move the sp804
> and twd timers over to using the clk API - and system timers are
> initialized prior to kmalloc.

setup_arch is before mm_init, and init_IRQ and time_init are after 
mm_init. My testing shows OF clock init works fine in the timer init.

Rob

  reply	other threads:[~2011-02-04 19:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-27 13:45 [PATCH 00/11] Rationalize and consolidate ARMs evaluation boards Russell King - ARM Linux
2011-01-27 13:46 ` [PATCH 01/11] ARM: integrator: use new init_early for clock tree init Russell King - ARM Linux
2011-02-04 19:27   ` Rob Herring
2011-02-04 19:31     ` Grant Likely
2011-02-04 19:34     ` Russell King - ARM Linux
2011-02-04 19:53       ` Rob Herring [this message]
2011-02-04 19:59         ` Russell King - ARM Linux
2011-01-27 13:46 ` [PATCH 02/11] ARM: versatile: use new init_early for clock tree and sched_clock init Russell King - ARM Linux
2011-01-27 13:46 ` [PATCH 03/11] ARM: realview: " Russell King - ARM Linux
2011-01-27 13:47 ` [PATCH 04/11] ARM: vexpress: " Russell King - ARM Linux
2011-01-27 13:47 ` [PATCH 05/11] ARM: versatile: remove old AMBA device DMA definitions Russell King - ARM Linux
2011-01-27 13:47 ` [PATCH 06/11] ARM: realview: " Russell King - ARM Linux
2011-01-27 14:40   ` Linus Walleij
2011-01-27 13:48 ` [PATCH 07/11] ARM: rationalize versatile family Kconfig/Makefile Russell King - ARM Linux
2011-01-27 13:48 ` [PATCH 08/11] ARM: integrator/versatile: consolidate FPGA IRQ handling code Russell King - ARM Linux
2011-01-27 13:48 ` [PATCH 09/11] ARM: realview/vexpress: consolidate localtimer support Russell King - ARM Linux
2011-01-27 13:49 ` [PATCH 10/11] ARM: realview/vexpress: consolidate SMP bringup code Russell King - ARM Linux
2011-01-27 13:49 ` [PATCH 11/11] ARM: integrator: add Integrator/CP sched_clock support Russell King - ARM Linux
2011-02-18 11:34 ` [PATCH 00/11] Rationalize and consolidate ARMs evaluation boards Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D4C5928.8040809@gmail.com \
    --to=robherring2@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).