From mboxrd@z Thu Jan  1 00:00:00 1970
From: sshtylyov@mvista.com (Sergei Shtylyov)
Date: Wed, 16 Feb 2011 15:35:28 +0300
Subject: [PATCH 1/3] OMAP2+: hwmod: Avoid setup if clock lookup failed
In-Reply-To: <1297858285-7056-2-git-send-email-rnayak@ti.com>
References: <1297858285-7056-1-git-send-email-rnayak@ti.com>
	<1297858285-7056-2-git-send-email-rnayak@ti.com>
Message-ID: <4D5BC490.4060809@ru.mvista.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hello.

On 16.02.2011 15:11, Rajendra Nayak wrote:

> Add a hwmod state check in the _setup function
> to avoid setting up hwmods' for which clock
> lookup has failed.

> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
[...]

> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index e282e35..cd9dcde 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -1362,6 +1362,12 @@ static int _setup(struct omap_hwmod *oh, void *data)
>   	int i, r;
>   	u8 postsetup_state;
>
> +	if (oh->_state != _HWMOD_STATE_CLKS_INITED) {
> +		WARN(1, "omap_hwmod: %s: _setup failed as one or more"

    You forgot space bafore " -- "moreclock" will be printed.

> +		     "clock lookups' have failed\n", oh->name);

    Why there's apostrophe here?

WBR, Sergei