From mboxrd@z Thu Jan  1 00:00:00 1970
From: b-cousson@ti.com (Cousson, Benoit)
Date: Fri, 18 Feb 2011 15:51:42 +0100
Subject: [PATCH 2/3] OMAP2+: hwmod: Fix what _init_clock returns
In-Reply-To: <1297858285-7056-3-git-send-email-rnayak@ti.com>
References: <1297858285-7056-1-git-send-email-rnayak@ti.com>
	<1297858285-7056-2-git-send-email-rnayak@ti.com>
	<1297858285-7056-3-git-send-email-rnayak@ti.com>
Message-ID: <4D5E877E.5090600@ti.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 2/16/2011 1:11 PM, Nayak, Rajendra wrote:
> _init_clock always returns 0 and does
> not propogate the error (in case of failure)
> back to the caller, causing _init_clocks to
> fail silently.
>
> Signed-off-by: Rajendra Nayak<rnayak@ti.com>
> ---
>   arch/arm/mach-omap2/omap_hwmod.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
> index cd9dcde..960461f 100644
> --- a/arch/arm/mach-omap2/omap_hwmod.c
> +++ b/arch/arm/mach-omap2/omap_hwmod.c
> @@ -926,7 +926,7 @@ static int _init_clocks(struct omap_hwmod *oh, void *data)
>   	if (!ret)
>   		oh->_state = _HWMOD_STATE_CLKS_INITED;
>
> -	return 0;
> +	return ret;
>   }
>
>   /**

This is correct and that makes kerneldoc accurate : "Returns ... a 
non-zero error on failure."

I'll queue it for 2.6.39.

Thanks,
Benoit