From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DaVinci: fix compilation warnings in <mach/clkdev.h>
Date: Fri, 18 Feb 2011 23:38:18 +0300 [thread overview]
Message-ID: <4D5ED8BA.5000703@mvista.com> (raw)
In-Reply-To: <201102092133.23765.sshtylyov@ru.mvista.com>
Hello.
I wrote:
> Commit 6d803ba736abb5e122dede70a4720e4843dd6df4 (ARM: 6483/1: arm & sh:
> factorised duplicated clkdev.c) caused the following warnings:
> In file included from /home/headless/src/kernel.org/linux-davinci/arch/arm/
> include/asm/clkdev.h:17,
> from include/linux/clkdev.h:15,
> from arch/arm/mach-davinci/clock.h:71,
> from arch/arm/mach-davinci/common.c:22:
> arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: `struct clk' declared
> inside parameter list
> arch/arm/mach-davinci/include/mach/clkdev.h:4: warning: its scope is only this
> definition or declaration, which is probably not what you want
> arch/arm/mach-davinci/include/mach/clkdev.h:9: warning: `struct clk' declared
> inside parameter list
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ---
> The patch is against the recent DaVinci tree.
> arch/arm/mach-davinci/include/mach/clkdev.h | 2 ++
> 1 file changed, 2 insertions(+)
> Index: linux-davinci/arch/arm/mach-davinci/include/mach/clkdev.h
> ===================================================================
> --- linux-davinci.orig/arch/arm/mach-davinci/include/mach/clkdev.h
> +++ linux-davinci/arch/arm/mach-davinci/include/mach/clkdev.h
> @@ -1,6 +1,8 @@
> #ifndef __MACH_CLKDEV_H
> #define __MACH_CLKDEV_H
>
> +struct clk;
> +
> static inline int __clk_get(struct clk *clk)
> {
> return 1;
Kevin, Sekhar, will you apply this?
WBR, Sergei
next prev parent reply other threads:[~2011-02-18 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 18:33 [PATCH] DaVinci: fix compilation warnings in <mach/clkdev.h> Sergei Shtylyov
2011-02-18 20:38 ` Sergei Shtylyov [this message]
2011-02-21 12:13 ` Nori, Sekhar
2011-02-23 12:01 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5ED8BA.5000703@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox