linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: stepanm@codeaurora.org (Stepan Moskovchenko)
To: linux-arm-kernel@lists.infradead.org
Subject: Compilation error in ARM NOMMU kernel due to fixup_smp change
Date: Wed, 23 Feb 2011 19:58:39 -0800	[thread overview]
Message-ID: <4D65D76F.4000006@codeaurora.org> (raw)

Hi Russell,

I am seeing the following compilation error in arch/arm/kernek/module.c 
when trying to compile an ARM NOMMU kernel (using Linus's tree as of an 
hour ago):

arch/arm/kernel/built-in.o: In function `module_finalize':
~/linux-2.6/arch/arm/kernel/module.c:337: undefined reference to `fixup_smp'
make: *** [.tmp_vmlinux1] Error 1

It looks like you have added fixup_smp to head.S but not to 
head-nommu.S, which is what gets used when building a NOMMU kernel. I 
have tried to find the original thread for that patch, but I was not 
able to find it, so I am just sending it here. I believe this was 
introduced by the commit below:

commit 4a9cb360197684a861bc06f06d33d5fcc8ffcbf5
Author: Russell King <rmk+kernel@arm.linux.org.uk>
Date:   Thu Feb 10 15:25:18 2011 +0000

     ARM: fixup SMP alternatives in modules

     With certain configurations, we inline the unlock functions in modules,
     which results in SMP alternatives being created in modules.  We need to
     fix those up when loading a module to prevent undefined instruction
     faults.

     Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>

I am not sure how you would want to go about fixing this (put the proper 
things into head-nommu.S, or just wrap the offending code in #ifdef 
CONFIG_MMU), but I thought I would bring this to your attention.

Thanks
Steve

Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

                 reply	other threads:[~2011-02-24  3:58 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D65D76F.4000006@codeaurora.org \
    --to=stepanm@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).