From: b-cousson@ti.com (Cousson, Benoit)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] OMAP 3 and 4 i2c fixes
Date: Thu, 3 Mar 2011 22:55:54 +0100 [thread overview]
Message-ID: <4D700E6A.10409@ti.com> (raw)
In-Reply-To: <20110303134744.30648.91218.stgit@otae.warmcat.com>
To summarize my comments on your series.
On 3/3/2011 2:50 PM, Andy Green wrote:
> The following series fixes two issues with OMAP 3 and 4 i2c support.
>
> First, hwmod tables don't have the i2c units marked up as being
> for 16-bit access only, which is mandatory.
That part is OK, and should just be extended to 2430 for the sake of
completeness. A rev attribute should be added as well for the second part.
> Second, the i2c peripheral unit init code is confused about using
> cpu_is...() and probed peripheral unit version, leading to OMAP3
> i2c code doing the wrong thing and accessing nonexistant registers.
That part should be revisited to use a better way to identify the IP
revision.
Most of the code is there, you just have to copy the correct information
during I2C device init.
Just let me know if you are not comfortable with that latest part, some
l-o folks, including me, can help you.
Thanks,
Benoit
prev parent reply other threads:[~2011-03-03 21:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-03 13:50 [PATCH 0/4] OMAP 3 and 4 i2c fixes Andy Green
2011-03-03 13:50 ` [PATCH 1/4] OMAP3 and 4 hwmod I2C units only allow 16 bit access Andy Green
2011-03-03 17:42 ` Cousson, Benoit
2011-03-03 17:56 ` Andy Green
2011-03-03 20:40 ` Cousson, Benoit
2011-03-04 8:33 ` Andy Green
2011-03-04 10:05 ` Cousson, Benoit
2011-03-04 15:20 ` Cousson, Benoit
2011-03-03 13:50 ` [PATCH 2/4] OMAP3 I2C document why cpu type and not peripheral unit ID used to probe Andy Green
2011-03-03 21:12 ` Cousson, Benoit
2011-03-04 8:25 ` Andy Green
2011-03-03 13:50 ` [PATCH 3/4] OMAP3 and 4 i2c mark extended reg enums as extended only Andy Green
2011-03-03 21:33 ` Cousson, Benoit
2011-03-04 8:32 ` Andy Green
2011-03-04 10:05 ` Cousson, Benoit
2011-03-03 13:50 ` [PATCH 4/4] OMAP3 and 4 I2C use cpu type consistently for new register availability Andy Green
2011-03-03 21:45 ` Cousson, Benoit
2011-03-03 21:55 ` Cousson, Benoit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D700E6A.10409@ti.com \
--to=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).