linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matt.waddel@canonical.com (Matt Waddel)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: mmci: Add ARM variant with extended FIFO
Date: Wed, 16 Mar 2011 10:25:16 -0600	[thread overview]
Message-ID: <4D80E46C.3010103@canonical.com> (raw)
In-Reply-To: <1299863887-15490-1-git-send-email-pawel.moll@arm.com>

On 03/11/2011 10:18 AM, Pawel Moll wrote:
> New IO FPGA implementation for Versatile Express boards contain
> MMCI (PL180) cell with FIFO extended to 128 words (512 bytes).
> 
> Signed-off-by: Pawel Moll <pawel.moll@arm.com>

Tested-by: Matt Waddel <matt.waddel@linaro.org>

This patch improves MMC performance on my vexpress system. Also
fixes "mmcblk0: error -5 transferring data" errors.

> ---
>  drivers/mmc/host/mmci.c |   13 ++++++++++++-
>  1 files changed, 12 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/mmci.c b/drivers/mmc/host/mmci.c
> index 2d6de3e..e7197b0 100644
> --- a/drivers/mmc/host/mmci.c
> +++ b/drivers/mmc/host/mmci.c
> @@ -66,6 +66,12 @@ static struct variant_data variant_arm = {
>  	.datalength_bits	= 16,
>  };
>  
> +static struct variant_data variant_arm_extended_fifo = {
> +	.fifosize		= 128 * 4,
> +	.fifohalfsize		= 64 * 4,
> +	.datalength_bits	= 16,
> +};
> +
>  static struct variant_data variant_u300 = {
>  	.fifosize		= 16 * 4,
>  	.fifohalfsize		= 8 * 4,
> @@ -1019,10 +1025,15 @@ static int mmci_resume(struct amba_device *dev)
>  static struct amba_id mmci_ids[] = {
>  	{
>  		.id	= 0x00041180,
> -		.mask	= 0x000fffff,
> +		.mask	= 0xff0fffff,
>  		.data	= &variant_arm,
>  	},
>  	{
> +		.id	= 0x01041180,
> +		.mask	= 0xff0fffff,
> +		.data	= &variant_arm_extended_fifo,
> +	},
> +	{
>  		.id	= 0x00041181,
>  		.mask	= 0x000fffff,
>  		.data	= &variant_arm,

  reply	other threads:[~2011-03-16 16:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 17:18 [PATCH] arm: mmci: Add ARM variant with extended FIFO Pawel Moll
2011-03-16 16:25 ` Matt Waddel [this message]
2011-03-16 16:34   ` Russell King - ARM Linux
2011-03-16 16:53     ` Pawel Moll
2011-03-17  8:54 ` Linus Walleij
2011-03-17 10:07   ` Pawel Moll
2011-03-24 22:47 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D80E46C.3010103@canonical.com \
    --to=matt.waddel@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).