[PATCH 5/7] add GPMI support for imx28

[b32955@freescale.com (Huang Shijie)]

Hi:
>>>> Hi,
>>>>
>>>> some general comments:
>>>> - Why are you not using the existing nand_ids but inventing your own
>>>>
>>>>     database?
>>> The nand_ids{} contains poor information for me.
>>> Such as :
>>> [1]The nand_ids does not have the enough information for the page
>>> size,oob size for some new NANDs.
>>>
>>>      And you can not get the information from parsing the NAND ids, such
>>>
>>> as some Micron NANDs.
>> You could use it for the standard chips where you do not need
>> additional information. That way most NAND chips could be supported
>> out of the box without having to modify the driver.
>>
>>> [2]I need the timing information of the NAND. The nand_ids DOES not have
>>> it. I have to
>>>
>>>      read the datasheet of the NAND, and add it to my database.
>> Do we really need exact timing data for each individual chip?
>> Or couldn't we live with some sane timing that works for most chips
>> and provide some means to specify a different timing via
>> platform_data?
> I suppose this is the way it should be done, but then you might some need some
> sort of NAND detection available before registering the driver. Eventually,
> the bootloader might have configured the appropriate timings already.
The bootloader does not set it.
> Have you considered using ONFI chips? They have standard timings at least.
>
The imx23/imx28 do not support ONFI chips in the DDR mode due to the 
hardware limits.
The the imx508 does support the ONFI and TOGGLE nand in the DDR mode.


Best Regards
Huang Shijie