* [PATCH] ep93xx: add support Vision EP9307 SoM
@ 2011-03-28 18:27 H Hartley Sweeten
2011-03-28 19:30 ` Ryan Mallon
0 siblings, 1 reply; 7+ messages in thread
From: H Hartley Sweeten @ 2011-03-28 18:27 UTC (permalink / raw)
To: linux-arm-kernel
Add support for Vision Engraving Systems EP9307 based SoM.
Signed-off-by: Hartley Sweeten <hartleys@visionengravers.com>
Cc: Ryan Mallon <ryan@bluewatersys.com>
---
diff --git a/arch/arm/mach-ep93xx/Kconfig b/arch/arm/mach-ep93xx/Kconfig
index 3a08b18..97a2493 100644
--- a/arch/arm/mach-ep93xx/Kconfig
+++ b/arch/arm/mach-ep93xx/Kconfig
@@ -182,6 +182,13 @@ config MACH_TS72XX
Say 'Y' here if you want your kernel to support the
Technologic Systems TS-72xx board.
+config MACH_VISION_EP9307
+ bool "Support Vision Engraving Systems EP9307 SoM"
+ depends on EP93XX_SDCE0_PHYS_OFFSET
+ help
+ Say 'Y' here if you want your kernel to support the
+ Vision Engraving Systems EP9307 SoM.
+
choice
prompt "Select a UART for early kernel messages"
diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
index 33ee2c8..bb5974c 100644
--- a/arch/arm/mach-ep93xx/Makefile
+++ b/arch/arm/mach-ep93xx/Makefile
@@ -13,3 +13,4 @@ obj-$(CONFIG_MACH_MICRO9) += micro9.o
obj-$(CONFIG_MACH_SIM_ONE) += simone.o
obj-$(CONFIG_MACH_SNAPPER_CL15) += snappercl15.o
obj-$(CONFIG_MACH_TS72XX) += ts72xx.o
+obj-$(CONFIG_MACH_VISION_EP9307)+= vision_ep9307.o
diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c
new file mode 100644
index 0000000..cb2d400
--- /dev/null
+++ b/arch/arm/mach-ep93xx/vision_ep9307.c
@@ -0,0 +1,377 @@
+/*
+ * arch/arm/mach-ep93xx/vision_ep9307.c
+ * Vision Engraving Systems EP9307 SoM support.
+ *
+ * Copyright (C) 2008-2011 Vision Engraving Systems
+ * H Hartley Sweeten <hsweeten@visionengravers.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+#include <linux/irq.h>
+#include <linux/gpio.h>
+#include <linux/fb.h>
+#include <linux/io.h>
+#include <linux/mtd/partitions.h>
+#include <linux/i2c.h>
+#include <linux/i2c-gpio.h>
+#include <linux/i2c/pca953x.h>
+#include <linux/spi/spi.h>
+#include <linux/spi/flash.h>
+#include <linux/spi/mmc_spi.h>
+#include <linux/mmc/host.h>
+
+#include <mach/hardware.h>
+#include <mach/fb.h>
+#include <mach/ep93xx_spi.h>
+
+#include <asm/mach-types.h>
+#include <asm/mach/map.h>
+#include <asm/mach/arch.h>
+
+/*************************************************************************
+ * Static I/O mappings for the FPGA
+ *************************************************************************/
+#define VISION_PHYS_BASE EP93XX_CS7_PHYS_BASE
+#define VISION_VIRT_BASE 0xfebff000
+
+static struct map_desc vision_io_desc[] __initdata = {
+ {
+ .virtual = VISION_VIRT_BASE,
+ .pfn = __phys_to_pfn(VISION_PHYS_BASE),
+ .length = SZ_4K,
+ .type = MT_DEVICE,
+ },
+};
+
+static void __init vision_map_io(void)
+{
+ ep93xx_map_io();
+
+ iotable_init(vision_io_desc, ARRAY_SIZE(vision_io_desc));
+}
+
+/*************************************************************************
+ * Ethernet
+ *************************************************************************/
+static struct ep93xx_eth_data vision_eth_data __initdata = {
+ .phy_id = 1,
+};
+
+/*************************************************************************
+ * Framebuffer
+ *************************************************************************/
+#define VISION_LCD_ENABLE EP93XX_GPIO_LINE_EGPIO1
+
+static int vision_lcd_setup(struct platform_device *pdev)
+{
+ int err;
+
+ err = gpio_request_one(VISION_LCD_ENABLE, GPIOF_INIT_HIGH,
+ dev_name(&pdev->dev));
+ if (err)
+ return err;
+
+ ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_RAS |
+ EP93XX_SYSCON_DEVCFG_RASONP3 |
+ EP93XX_SYSCON_DEVCFG_EXVC);
+
+ return 0;
+}
+
+static void vision_lcd_teardown(struct platform_device *pdev)
+{
+ gpio_free(VISION_LCD_ENABLE);
+}
+
+static void vision_lcd_blank(int blank_mode, struct fb_info *info)
+{
+ if (blank_mode)
+ gpio_set_value(VISION_LCD_ENABLE, 0);
+ else
+ gpio_set_value(VISION_LCD_ENABLE, 1);
+}
+
+static struct ep93xxfb_mach_info ep93xxfb_info __initdata = {
+ .num_modes = EP93XXFB_USE_MODEDB,
+ .modes = NULL,
+ .default_mode = NULL,
+ .bpp = 16,
+ .flags = EP93XXFB_USE_SDCSN0 | EP93XXFB_PCLK_FALLING,
+ .setup = vision_lcd_setup,
+ .teardown = vision_lcd_teardown,
+ .blank = vision_lcd_blank,
+};
+
+
+/*************************************************************************
+ * GPIO Expanders
+ *************************************************************************/
+#define PCA9539_74_GPIO_BASE (EP93XX_GPIO_LINE_MAX + 1)
+#define PCA9539_75_GPIO_BASE (PCA9539_74_GPIO_BASE + 16)
+#define PCA9539_76_GPIO_BASE (PCA9539_75_GPIO_BASE + 16)
+#define PCA9539_77_GPIO_BASE (PCA9539_76_GPIO_BASE + 16)
+
+static struct pca953x_platform_data pca953x_74_gpio_data = {
+ .gpio_base = PCA9539_74_GPIO_BASE,
+ .invert = 0,
+ .irq_base = EP93XX_BOARD_IRQ(0),
+ .context = NULL,
+ .setup = NULL,
+ .teardown = NULL,
+};
+
+static struct pca953x_platform_data pca953x_75_gpio_data = {
+ .gpio_base = PCA9539_75_GPIO_BASE,
+ .invert = 0,
+ .irq_base = -1,
+};
+
+static struct pca953x_platform_data pca953x_76_gpio_data = {
+ .gpio_base = PCA9539_76_GPIO_BASE,
+ .invert = 0,
+ .irq_base = -1,
+};
+
+static struct pca953x_platform_data pca953x_77_gpio_data = {
+ .gpio_base = PCA9539_77_GPIO_BASE,
+ .invert = 0,
+ .irq_base = -1,
+};
+
+/*************************************************************************
+ * I2C Bus
+ *************************************************************************/
+static struct i2c_gpio_platform_data vision_i2c_gpio_data __initdata = {
+ .sda_pin = EP93XX_GPIO_LINE_EEDAT,
+ .sda_is_open_drain = 0,
+ .scl_pin = EP93XX_GPIO_LINE_EECLK,
+ .scl_is_open_drain = 0,
+ .udelay = 0, /* default to 100 kHz */
+ .timeout = 0, /* default to 100 ms */
+};
+
+static struct i2c_board_info vision_i2c_info[] __initdata = {
+ {
+ I2C_BOARD_INFO("isl1208", 0x6f),
+ .irq = IRQ_EP93XX_EXT1,
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x74),
+ .platform_data = &pca953x_74_gpio_data,
+ .irq = gpio_to_irq(EP93XX_GPIO_LINE_F(7)),
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x75),
+ .platform_data = &pca953x_75_gpio_data,
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x76),
+ .platform_data = &pca953x_76_gpio_data,
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x77),
+ .platform_data = &pca953x_77_gpio_data,
+ },
+};
+
+/*************************************************************************
+ * SPI Flash
+ *************************************************************************/
+#define VISION_SPI_FLASH_CS EP93XX_GPIO_LINE_EGPIO7
+
+static struct mtd_partition vision_spi_flash_partitions[] = {
+ {
+ .name = "SPI bootstrap",
+ .offset = 0,
+ .size = SZ_4K,
+ }, {
+ .name = "Bootstrap config",
+ .offset = MTDPART_OFS_APPEND,
+ .size = SZ_4K,
+ }, {
+ .name = "System config",
+ .offset = MTDPART_OFS_APPEND,
+ .size = MTDPART_SIZ_FULL,
+ },
+};
+
+static struct flash_platform_data vision_spi_flash_data = {
+ .name = "SPI Flash",
+ .parts = vision_spi_flash_partitions,
+ .nr_parts = ARRAY_SIZE(vision_spi_flash_partitions),
+};
+
+static int vision_spi_flash_hw_setup(struct spi_device *spi)
+{
+ return gpio_request_one(VISION_SPI_FLASH_CS, GPIOF_INIT_HIGH,
+ spi->modalias);
+}
+
+static void vision_spi_flash_hw_cleanup(struct spi_device *spi)
+{
+ gpio_free(VISION_SPI_FLASH_CS);
+}
+
+static void vision_spi_flash_hw_cs_control(struct spi_device *spi, int value)
+{
+ gpio_set_value(VISION_SPI_FLASH_CS, value);
+}
+
+static struct ep93xx_spi_chip_ops vision_spi_flash_hw = {
+ .setup = vision_spi_flash_hw_setup,
+ .cleanup = vision_spi_flash_hw_cleanup,
+ .cs_control = vision_spi_flash_hw_cs_control,
+};
+
+/*************************************************************************
+ * SPI SD/MMC host
+ *************************************************************************/
+#define VISION_SPI_MMC_CS EP93XX_GPIO_LINE_G(2)
+#define VISION_SPI_MMC_WP EP93XX_GPIO_LINE_F(0)
+#define VISION_SPI_MMC_CD EP93XX_GPIO_LINE_EGPIO15
+
+static struct gpio vision_spi_mmc_gpios[] = {
+ { VISION_SPI_MMC_WP, GPIOF_DIR_IN, "mmc_spi:wp" },
+ { VISION_SPI_MMC_CD, GPIOF_DIR_IN, "mmc_spi:cd" },
+};
+
+static int vision_spi_mmc_init(struct device *pdev,
+ irqreturn_t (*func)(int, void *), void *pdata)
+{
+ int err;
+
+ err = gpio_request_array(vision_spi_mmc_gpios,
+ ARRAY_SIZE(vision_spi_mmc_gpios));
+ if (err)
+ return err;
+
+ err = gpio_set_debounce(VISION_SPI_MMC_CD, 1);
+ if (err)
+ goto exit_err;
+
+ err = request_irq(gpio_to_irq(VISION_SPI_MMC_CD), func,
+ IRQ_TYPE_EDGE_BOTH, "mmc_spi:cd", pdata);
+ if (err)
+ goto exit_err;
+
+ return 0;
+
+exit_err:
+ gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
+ return err;
+
+}
+
+static void vision_spi_mmc_exit(struct device *pdev, void *pdata)
+{
+ free_irq(gpio_to_irq(VISION_SPI_MMC_CD), pdata);
+ gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
+}
+
+static int vision_spi_mmc_get_ro(struct device *pdev)
+{
+ return !!gpio_get_value(VISION_SPI_MMC_WP);
+}
+
+static int vision_spi_mmc_get_cd(struct device *pdev)
+{
+ return !gpio_get_value(VISION_SPI_MMC_CD);
+}
+
+static struct mmc_spi_platform_data vision_spi_mmc_data = {
+ .init = vision_spi_mmc_init,
+ .exit = vision_spi_mmc_exit,
+ .get_ro = vision_spi_mmc_get_ro,
+ .get_cd = vision_spi_mmc_get_cd,
+ .detect_delay = 100,
+ .powerup_msecs = 100,
+ .ocr_mask = MMC_VDD_32_33 | MMC_VDD_33_34,
+};
+
+static int vision_spi_mmc_hw_setup(struct spi_device *spi)
+{
+ return gpio_request_one(VISION_SPI_MMC_CS, GPIOF_INIT_HIGH,
+ spi->modalias);
+}
+
+static void vision_spi_mmc_hw_cleanup(struct spi_device *spi)
+{
+ gpio_free(VISION_SPI_MMC_CS);
+}
+
+static void vision_spi_mmc_hw_cs_control(struct spi_device *spi, int value)
+{
+ gpio_set_value(VISION_SPI_MMC_CS, value);
+}
+
+static struct ep93xx_spi_chip_ops vision_spi_mmc_hw = {
+ .setup = vision_spi_mmc_hw_setup,
+ .cleanup = vision_spi_mmc_hw_cleanup,
+ .cs_control = vision_spi_mmc_hw_cs_control,
+};
+
+/*************************************************************************
+ * SPI Bus
+ *************************************************************************/
+static struct spi_board_info vision_spi_board_info[] __initdata = {
+ {
+ .modalias = "sst25l",
+ .platform_data = &vision_spi_flash_data,
+ .controller_data = &vision_spi_flash_hw,
+ .max_speed_hz = 20000000,
+ .bus_num = 0,
+ .chip_select = 0,
+ .mode = SPI_MODE_3,
+ }, {
+ .modalias = "mmc_spi",
+ .platform_data = &vision_spi_mmc_data,
+ .controller_data = &vision_spi_mmc_hw,
+ .max_speed_hz = 20000000,
+ .bus_num = 0,
+ .chip_select = 1,
+ .mode = SPI_MODE_3,
+ },
+};
+
+static struct ep93xx_spi_info vision_spi_master __initdata = {
+ .num_chipselect = ARRAY_SIZE(vision_spi_board_info),
+};
+
+/*************************************************************************
+ * Machine Initialization
+ *************************************************************************/
+static void __init vision_init_machine(void)
+{
+ ep93xx_init_devices();
+ ep93xx_register_flash(2, EP93XX_CS6_PHYS_BASE, SZ_64M);
+ ep93xx_register_eth(&vision_eth_data, 1);
+ ep93xx_register_fb(&ep93xxfb_info);
+ ep93xx_register_pwm(1, 0);
+
+ /*
+ * Request the gpio expander's interrupt gpio line now to prevent
+ * the kernel from doing a WARN in gpiolib:gpio_ensure_requested().
+ */
+ if (gpio_request_one(EP93XX_GPIO_LINE_F(7), GPIOF_DIR_IN,
+ "pca9539:74"))
+ pr_warn("cannot request interrupt gpio for pca9539:74\n");
+
+ ep93xx_register_i2c(&vision_i2c_gpio_data, vision_i2c_info,
+ ARRAY_SIZE(vision_i2c_info));
+ ep93xx_register_spi(&vision_spi_master, vision_spi_board_info,
+ ARRAY_SIZE(vision_spi_board_info));
+}
+
+MACHINE_START(VISION_EP9307, "Vision Engraving Systems EP9307")
+ /* Maintainer: H Hartley Sweeten <hsweeten@visionengravers.com> */
+ .boot_params = EP93XX_SDCE0_PHYS_BASE + 0x100,
+ .map_io = vision_map_io,
+ .init_irq = ep93xx_init_irq,
+ .timer = &ep93xx_timer,
+ .init_machine = vision_init_machine,
+MACHINE_END
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ep93xx: add support Vision EP9307 SoM
2011-03-28 18:27 [PATCH] ep93xx: add support Vision EP9307 SoM H Hartley Sweeten
@ 2011-03-28 19:30 ` Ryan Mallon
2011-03-28 19:46 ` H Hartley Sweeten
2011-03-29 12:56 ` Sergei Shtylyov
0 siblings, 2 replies; 7+ messages in thread
From: Ryan Mallon @ 2011-03-28 19:30 UTC (permalink / raw)
To: linux-arm-kernel
On 03/29/2011 07:27 AM, H Hartley Sweeten wrote:
> Add support for Vision Engraving Systems EP9307 based SoM.
>
> Signed-off-by: Hartley Sweeten <hartleys@visionengravers.com>
> Cc: Ryan Mallon <ryan@bluewatersys.com>
Hi Hartley,
Looks mostly good. Couple of minor comments below.
~Ryan
> ---
>
> diff --git a/arch/arm/mach-ep93xx/Kconfig b/arch/arm/mach-ep93xx/Kconfig
> index 3a08b18..97a2493 100644
> --- a/arch/arm/mach-ep93xx/Kconfig
> +++ b/arch/arm/mach-ep93xx/Kconfig
> @@ -182,6 +182,13 @@ config MACH_TS72XX
> Say 'Y' here if you want your kernel to support the
> Technologic Systems TS-72xx board.
>
> +config MACH_VISION_EP9307
> + bool "Support Vision Engraving Systems EP9307 SoM"
> + depends on EP93XX_SDCE0_PHYS_OFFSET
> + help
> + Say 'Y' here if you want your kernel to support the
> + Vision Engraving Systems EP9307 SoM.
> +
> choice
> prompt "Select a UART for early kernel messages"
>
> diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
> index 33ee2c8..bb5974c 100644
> --- a/arch/arm/mach-ep93xx/Makefile
> +++ b/arch/arm/mach-ep93xx/Makefile
> @@ -13,3 +13,4 @@ obj-$(CONFIG_MACH_MICRO9) += micro9.o
> obj-$(CONFIG_MACH_SIM_ONE) += simone.o
> obj-$(CONFIG_MACH_SNAPPER_CL15) += snappercl15.o
> obj-$(CONFIG_MACH_TS72XX) += ts72xx.o
> +obj-$(CONFIG_MACH_VISION_EP9307)+= vision_ep9307.o
> diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c
> new file mode 100644
> index 0000000..cb2d400
> --- /dev/null
> +++ b/arch/arm/mach-ep93xx/vision_ep9307.c
> @@ -0,0 +1,377 @@
> +/*
> + * arch/arm/mach-ep93xx/vision_ep9307.c
> + * Vision Engraving Systems EP9307 SoM support.
> + *
> + * Copyright (C) 2008-2011 Vision Engraving Systems
> + * H Hartley Sweeten <hsweeten@visionengravers.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or (at
> + * your option) any later version.
> + */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/platform_device.h>
> +#include <linux/irq.h>
> +#include <linux/gpio.h>
> +#include <linux/fb.h>
> +#include <linux/io.h>
> +#include <linux/mtd/partitions.h>
> +#include <linux/i2c.h>
> +#include <linux/i2c-gpio.h>
> +#include <linux/i2c/pca953x.h>
> +#include <linux/spi/spi.h>
> +#include <linux/spi/flash.h>
> +#include <linux/spi/mmc_spi.h>
> +#include <linux/mmc/host.h>
> +
> +#include <mach/hardware.h>
> +#include <mach/fb.h>
> +#include <mach/ep93xx_spi.h>
> +
> +#include <asm/mach-types.h>
> +#include <asm/mach/map.h>
> +#include <asm/mach/arch.h>
> +
> +/*************************************************************************
> + * Static I/O mappings for the FPGA
> + *************************************************************************/
> +#define VISION_PHYS_BASE EP93XX_CS7_PHYS_BASE
> +#define VISION_VIRT_BASE 0xfebff000
> +
> +static struct map_desc vision_io_desc[] __initdata = {
> + {
> + .virtual = VISION_VIRT_BASE,
> + .pfn = __phys_to_pfn(VISION_PHYS_BASE),
> + .length = SZ_4K,
> + .type = MT_DEVICE,
> + },
> +};
> +
> +static void __init vision_map_io(void)
> +{
> + ep93xx_map_io();
> +
> + iotable_init(vision_io_desc, ARRAY_SIZE(vision_io_desc));
> +}
> +
> +/*************************************************************************
> + * Ethernet
> + *************************************************************************/
> +static struct ep93xx_eth_data vision_eth_data __initdata = {
> + .phy_id = 1,
> +};
> +
> +/*************************************************************************
> + * Framebuffer
> + *************************************************************************/
> +#define VISION_LCD_ENABLE EP93XX_GPIO_LINE_EGPIO1
> +
> +static int vision_lcd_setup(struct platform_device *pdev)
> +{
> + int err;
> +
> + err = gpio_request_one(VISION_LCD_ENABLE, GPIOF_INIT_HIGH,
> + dev_name(&pdev->dev));
> + if (err)
> + return err;
> +
> + ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_RAS |
> + EP93XX_SYSCON_DEVCFG_RASONP3 |
> + EP93XX_SYSCON_DEVCFG_EXVC);
> +
> + return 0;
> +}
> +
> +static void vision_lcd_teardown(struct platform_device *pdev)
> +{
> + gpio_free(VISION_LCD_ENABLE);
> +}
> +
> +static void vision_lcd_blank(int blank_mode, struct fb_info *info)
> +{
> + if (blank_mode)
> + gpio_set_value(VISION_LCD_ENABLE, 0);
> + else
> + gpio_set_value(VISION_LCD_ENABLE, 1);
This can just be:
gpio_set_value(VISION_LCD_ENABLE, blank_mode ^ 1);
> +}
> +
> +static struct ep93xxfb_mach_info ep93xxfb_info __initdata = {
> + .num_modes = EP93XXFB_USE_MODEDB,
> + .modes = NULL,
> + .default_mode = NULL,
Remove this two NULL assignments and add a comment that the lcd uses the
standard modedb modes.
> + .bpp = 16,
> + .flags = EP93XXFB_USE_SDCSN0 | EP93XXFB_PCLK_FALLING,
> + .setup = vision_lcd_setup,
> + .teardown = vision_lcd_teardown,
> + .blank = vision_lcd_blank,
> +};
> +
> +
> +/*************************************************************************
> + * GPIO Expanders
> + *************************************************************************/
> +#define PCA9539_74_GPIO_BASE (EP93XX_GPIO_LINE_MAX + 1)
> +#define PCA9539_75_GPIO_BASE (PCA9539_74_GPIO_BASE + 16)
> +#define PCA9539_76_GPIO_BASE (PCA9539_75_GPIO_BASE + 16)
> +#define PCA9539_77_GPIO_BASE (PCA9539_76_GPIO_BASE + 16)
> +
> +static struct pca953x_platform_data pca953x_74_gpio_data = {
> + .gpio_base = PCA9539_74_GPIO_BASE,
> + .invert = 0,
> + .irq_base = EP93XX_BOARD_IRQ(0),
> + .context = NULL,
> + .setup = NULL,
> + .teardown = NULL,
Don't need the NULL assignments.
> +};
> +
> +static struct pca953x_platform_data pca953x_75_gpio_data = {
> + .gpio_base = PCA9539_75_GPIO_BASE,
> + .invert = 0,
Don't need the zero assignments.
> + .irq_base = -1,
> +};
> +
> +static struct pca953x_platform_data pca953x_76_gpio_data = {
> + .gpio_base = PCA9539_76_GPIO_BASE,
> + .invert = 0,
> + .irq_base = -1,
> +};
> +
> +static struct pca953x_platform_data pca953x_77_gpio_data = {
> + .gpio_base = PCA9539_77_GPIO_BASE,
> + .invert = 0,
> + .irq_base = -1,
> +};
> +
> +/*************************************************************************
> + * I2C Bus
> + *************************************************************************/
> +static struct i2c_gpio_platform_data vision_i2c_gpio_data __initdata = {
> + .sda_pin = EP93XX_GPIO_LINE_EEDAT,
> + .sda_is_open_drain = 0,
> + .scl_pin = EP93XX_GPIO_LINE_EECLK,
> + .scl_is_open_drain = 0,
> + .udelay = 0, /* default to 100 kHz */
> + .timeout = 0, /* default to 100 ms */
Remove the zero assignments, and just have a comment at the top saying
the the default speed is used.
> +};
> +
> +static struct i2c_board_info vision_i2c_info[] __initdata = {
> + {
> + I2C_BOARD_INFO("isl1208", 0x6f),
> + .irq = IRQ_EP93XX_EXT1,
> + }, {
Nitpick - opening braces should go on a new line.
> + I2C_BOARD_INFO("pca9539", 0x74),
> + .platform_data = &pca953x_74_gpio_data,
> + .irq = gpio_to_irq(EP93XX_GPIO_LINE_F(7)),
> + }, {
> + I2C_BOARD_INFO("pca9539", 0x75),
> + .platform_data = &pca953x_75_gpio_data,
> + }, {
> + I2C_BOARD_INFO("pca9539", 0x76),
> + .platform_data = &pca953x_76_gpio_data,
> + }, {
> + I2C_BOARD_INFO("pca9539", 0x77),
> + .platform_data = &pca953x_77_gpio_data,
> + },
> +};
> +
> +/*************************************************************************
> + * SPI Flash
> + *************************************************************************/
> +#define VISION_SPI_FLASH_CS EP93XX_GPIO_LINE_EGPIO7
> +
> +static struct mtd_partition vision_spi_flash_partitions[] = {
> + {
> + .name = "SPI bootstrap",
> + .offset = 0,
> + .size = SZ_4K,
> + }, {
> + .name = "Bootstrap config",
> + .offset = MTDPART_OFS_APPEND,
> + .size = SZ_4K,
> + }, {
> + .name = "System config",
> + .offset = MTDPART_OFS_APPEND,
> + .size = MTDPART_SIZ_FULL,
> + },
> +};
> +
> +static struct flash_platform_data vision_spi_flash_data = {
> + .name = "SPI Flash",
> + .parts = vision_spi_flash_partitions,
> + .nr_parts = ARRAY_SIZE(vision_spi_flash_partitions),
> +};
> +
> +static int vision_spi_flash_hw_setup(struct spi_device *spi)
> +{
> + return gpio_request_one(VISION_SPI_FLASH_CS, GPIOF_INIT_HIGH,
> + spi->modalias);
> +}
> +
> +static void vision_spi_flash_hw_cleanup(struct spi_device *spi)
> +{
> + gpio_free(VISION_SPI_FLASH_CS);
> +}
> +
> +static void vision_spi_flash_hw_cs_control(struct spi_device *spi, int value)
> +{
> + gpio_set_value(VISION_SPI_FLASH_CS, value);
> +}
> +
> +static struct ep93xx_spi_chip_ops vision_spi_flash_hw = {
> + .setup = vision_spi_flash_hw_setup,
> + .cleanup = vision_spi_flash_hw_cleanup,
> + .cs_control = vision_spi_flash_hw_cs_control,
> +};
> +
> +/*************************************************************************
> + * SPI SD/MMC host
> + *************************************************************************/
> +#define VISION_SPI_MMC_CS EP93XX_GPIO_LINE_G(2)
> +#define VISION_SPI_MMC_WP EP93XX_GPIO_LINE_F(0)
> +#define VISION_SPI_MMC_CD EP93XX_GPIO_LINE_EGPIO15
> +
> +static struct gpio vision_spi_mmc_gpios[] = {
> + { VISION_SPI_MMC_WP, GPIOF_DIR_IN, "mmc_spi:wp" },
> + { VISION_SPI_MMC_CD, GPIOF_DIR_IN, "mmc_spi:cd" },
> +};
> +
> +static int vision_spi_mmc_init(struct device *pdev,
> + irqreturn_t (*func)(int, void *), void *pdata)
> +{
> + int err;
> +
> + err = gpio_request_array(vision_spi_mmc_gpios,
> + ARRAY_SIZE(vision_spi_mmc_gpios));
> + if (err)
> + return err;
> +
> + err = gpio_set_debounce(VISION_SPI_MMC_CD, 1);
> + if (err)
> + goto exit_err;
> +
> + err = request_irq(gpio_to_irq(VISION_SPI_MMC_CD), func,
> + IRQ_TYPE_EDGE_BOTH, "mmc_spi:cd", pdata);
> + if (err)
> + goto exit_err;
> +
> + return 0;
> +
> +exit_err:
> + gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
> + return err;
> +
> +}
> +
> +static void vision_spi_mmc_exit(struct device *pdev, void *pdata)
> +{
> + free_irq(gpio_to_irq(VISION_SPI_MMC_CD), pdata);
> + gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
> +}
> +
> +static int vision_spi_mmc_get_ro(struct device *pdev)
> +{
> + return !!gpio_get_value(VISION_SPI_MMC_WP);
> +}
> +
> +static int vision_spi_mmc_get_cd(struct device *pdev)
> +{
> + return !gpio_get_value(VISION_SPI_MMC_CD);
> +}
> +
> +static struct mmc_spi_platform_data vision_spi_mmc_data = {
> + .init = vision_spi_mmc_init,
> + .exit = vision_spi_mmc_exit,
> + .get_ro = vision_spi_mmc_get_ro,
> + .get_cd = vision_spi_mmc_get_cd,
> + .detect_delay = 100,
> + .powerup_msecs = 100,
> + .ocr_mask = MMC_VDD_32_33 | MMC_VDD_33_34,
> +};
> +
> +static int vision_spi_mmc_hw_setup(struct spi_device *spi)
> +{
> + return gpio_request_one(VISION_SPI_MMC_CS, GPIOF_INIT_HIGH,
> + spi->modalias);
> +}
> +
> +static void vision_spi_mmc_hw_cleanup(struct spi_device *spi)
> +{
> + gpio_free(VISION_SPI_MMC_CS);
> +}
> +
> +static void vision_spi_mmc_hw_cs_control(struct spi_device *spi, int value)
> +{
> + gpio_set_value(VISION_SPI_MMC_CS, value);
> +}
> +
> +static struct ep93xx_spi_chip_ops vision_spi_mmc_hw = {
> + .setup = vision_spi_mmc_hw_setup,
> + .cleanup = vision_spi_mmc_hw_cleanup,
> + .cs_control = vision_spi_mmc_hw_cs_control,
> +};
> +
> +/*************************************************************************
> + * SPI Bus
> + *************************************************************************/
> +static struct spi_board_info vision_spi_board_info[] __initdata = {
> + {
> + .modalias = "sst25l",
> + .platform_data = &vision_spi_flash_data,
> + .controller_data = &vision_spi_flash_hw,
> + .max_speed_hz = 20000000,
> + .bus_num = 0,
> + .chip_select = 0,
Note: Don't delete these zero assignments since they are meaningful :-).
> + .mode = SPI_MODE_3,
> + }, {
> + .modalias = "mmc_spi",
> + .platform_data = &vision_spi_mmc_data,
> + .controller_data = &vision_spi_mmc_hw,
> + .max_speed_hz = 20000000,
> + .bus_num = 0,
> + .chip_select = 1,
> + .mode = SPI_MODE_3,
> + },
> +};
> +
> +static struct ep93xx_spi_info vision_spi_master __initdata = {
> + .num_chipselect = ARRAY_SIZE(vision_spi_board_info),
> +};
> +
> +/*************************************************************************
> + * Machine Initialization
> + *************************************************************************/
> +static void __init vision_init_machine(void)
> +{
> + ep93xx_init_devices();
> + ep93xx_register_flash(2, EP93XX_CS6_PHYS_BASE, SZ_64M);
> + ep93xx_register_eth(&vision_eth_data, 1);
> + ep93xx_register_fb(&ep93xxfb_info);
> + ep93xx_register_pwm(1, 0);
> +
> + /*
> + * Request the gpio expander's interrupt gpio line now to prevent
> + * the kernel from doing a WARN in gpiolib:gpio_ensure_requested().
> + */
> + if (gpio_request_one(EP93XX_GPIO_LINE_F(7), GPIOF_DIR_IN,
> + "pca9539:74"))
> + pr_warn("cannot request interrupt gpio for pca9539:74\n");
> +
> + ep93xx_register_i2c(&vision_i2c_gpio_data, vision_i2c_info,
> + ARRAY_SIZE(vision_i2c_info));
> + ep93xx_register_spi(&vision_spi_master, vision_spi_board_info,
> + ARRAY_SIZE(vision_spi_board_info));
> +}
> +
> +MACHINE_START(VISION_EP9307, "Vision Engraving Systems EP9307")
> + /* Maintainer: H Hartley Sweeten <hsweeten@visionengravers.com> */
> + .boot_params = EP93XX_SDCE0_PHYS_BASE + 0x100,
> + .map_io = vision_map_io,
> + .init_irq = ep93xx_init_irq,
> + .timer = &ep93xx_timer,
> + .init_machine = vision_init_machine,
> +MACHINE_END
With those changes:
Acked-by: Ryan Mallon <ryan@bluewatersys.com>
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ep93xx: add support Vision EP9307 SoM
2011-03-28 19:30 ` Ryan Mallon
@ 2011-03-28 19:46 ` H Hartley Sweeten
2011-03-28 19:48 ` Ryan Mallon
2011-03-29 12:56 ` Sergei Shtylyov
1 sibling, 1 reply; 7+ messages in thread
From: H Hartley Sweeten @ 2011-03-28 19:46 UTC (permalink / raw)
To: linux-arm-kernel
On Monday, March 28, 2011 12:30 PM, Ryan Mallon wrote:
> On 03/29/2011 07:27 AM, H Hartley Sweeten wrote:
>> Add support for Vision Engraving Systems EP9307 based SoM.
>>
>> Signed-off-by: Hartley Sweeten <hartleys@visionengravers.com>
>> Cc: Ryan Mallon <ryan@bluewatersys.com>
>
> Hi Hartley,
>
> Looks mostly good. Couple of minor comments below.
>> +static void vision_lcd_blank(int blank_mode, struct fb_info *info)
>> +{
>> + if (blank_mode)
>> + gpio_set_value(VISION_LCD_ENABLE, 0);
>> + else
>> + gpio_set_value(VISION_LCD_ENABLE, 1);
>
> This can just be:
>
> gpio_set_value(VISION_LCD_ENABLE, blank_mode ^ 1);
That does kind of hide the meaning of blank_mode. Also, it appears blank_mode
is actually an enum not 0 or 1. Do you still feel your way is better?
>> +}
>> +
>> +static struct ep93xxfb_mach_info ep93xxfb_info __initdata = {
>> + .num_modes = EP93XXFB_USE_MODEDB,
>> + .modes = NULL,
>> + .default_mode = NULL,
>
> Remove this two NULL assignments and add a comment that the lcd uses the
> standard modedb modes.
OK.
>> +static struct pca953x_platform_data pca953x_74_gpio_data = {
>> + .gpio_base = PCA9539_74_GPIO_BASE,
>> + .invert = 0,
>> + .irq_base = EP93XX_BOARD_IRQ(0),
>> + .context = NULL,
>> + .setup = NULL,
>> + .teardown = NULL,
>
> Don't need the NULL assignments.
Agreed. I had those in as placeholders until I decided if I needed to use them.
For now they can be removed.
>> +};
>> +
>> +static struct pca953x_platform_data pca953x_75_gpio_data = {
>> + .gpio_base = PCA9539_75_GPIO_BASE,
>> + .invert = 0,
>
> Don't need the zero assignments.
Again, they were put there until I decided I needed them. Will remove for now.
>> +/*************************************************************************
>> + * I2C Bus
>> + *************************************************************************/
>> +static struct i2c_gpio_platform_data vision_i2c_gpio_data __initdata = {
>> + .sda_pin = EP93XX_GPIO_LINE_EEDAT,
>> + .sda_is_open_drain = 0,
>> + .scl_pin = EP93XX_GPIO_LINE_EECLK,
>> + .scl_is_open_drain = 0,
>> + .udelay = 0, /* default to 100 kHz */
>> + .timeout = 0, /* default to 100 ms */
>
> Remove the zero assignments, and just have a comment at the top saying
> the the default speed is used.
OK.
>> +};
>> +
>> +static struct i2c_board_info vision_i2c_info[] __initdata = {
>> + {
>> + I2C_BOARD_INFO("isl1208", 0x6f),
>> + .irq = IRQ_EP93XX_EXT1,
>> + }, {
>
> Nitpick - opening braces should go on a new line.
For array definitions like this it appears the '}, {' is more common.
>> +/*************************************************************************
>> + * SPI Bus
>> + *************************************************************************/
>> +static struct spi_board_info vision_spi_board_info[] __initdata = {
>> + {
>> + .modalias = "sst25l",
>> + .platform_data = &vision_spi_flash_data,
>> + .controller_data = &vision_spi_flash_hw,
>> + .max_speed_hz = 20000000,
>> + .bus_num = 0,
>> + .chip_select = 0,
>
> Note: Don't delete these zero assignments since they are meaningful :-).
Agree.
> With those changes:
I'll post an update later.
Thanks,
Hartley
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ep93xx: add support Vision EP9307 SoM
2011-03-28 19:46 ` H Hartley Sweeten
@ 2011-03-28 19:48 ` Ryan Mallon
2011-03-28 20:22 ` H Hartley Sweeten
0 siblings, 1 reply; 7+ messages in thread
From: Ryan Mallon @ 2011-03-28 19:48 UTC (permalink / raw)
To: linux-arm-kernel
On 03/29/2011 08:46 AM, H Hartley Sweeten wrote:
> On Monday, March 28, 2011 12:30 PM, Ryan Mallon wrote:
>> On 03/29/2011 07:27 AM, H Hartley Sweeten wrote:
>>> Add support for Vision Engraving Systems EP9307 based SoM.
>>>
>>> Signed-off-by: Hartley Sweeten <hartleys@visionengravers.com>
>>> Cc: Ryan Mallon <ryan@bluewatersys.com>
>>
>> Hi Hartley,
>>
>> Looks mostly good. Couple of minor comments below.
>
>>> +static void vision_lcd_blank(int blank_mode, struct fb_info *info)
>>> +{
>>> + if (blank_mode)
>>> + gpio_set_value(VISION_LCD_ENABLE, 0);
>>> + else
>>> + gpio_set_value(VISION_LCD_ENABLE, 1);
>>
>> This can just be:
>>
>> gpio_set_value(VISION_LCD_ENABLE, blank_mode ^ 1);
>
> That does kind of hide the meaning of blank_mode. Also, it appears blank_mode
> is actually an enum not 0 or 1. Do you still feel your way is better?
Ah, okay. I just suggest the above as being slightly more concise. If
you think that it is more clear/correct as is then leave it.
>
>>> +};
>>> +
>>> +static struct i2c_board_info vision_i2c_info[] __initdata = {
>>> + {
>>> + I2C_BOARD_INFO("isl1208", 0x6f),
>>> + .irq = IRQ_EP93XX_EXT1,
>>> + }, {
>>
>> Nitpick - opening braces should go on a new line.
>
> For array definitions like this it appears the '}, {' is more common.
Ok.
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
^ permalink raw reply [flat|nested] 7+ messages in thread* [PATCH] ep93xx: add support Vision EP9307 SoM
2011-03-28 19:48 ` Ryan Mallon
@ 2011-03-28 20:22 ` H Hartley Sweeten
2011-03-28 20:27 ` Ryan Mallon
0 siblings, 1 reply; 7+ messages in thread
From: H Hartley Sweeten @ 2011-03-28 20:22 UTC (permalink / raw)
To: linux-arm-kernel
Add support for Vision Engraving Systems EP9307 based SoM.
Signed-off-by: Hartley Sweeten <hartleys@visionengravers.com>
Cc: Ryan Mallon <ryan@bluewatersys.com>
---
V2: updated based on comments from Ryan Mallon
diff --git a/arch/arm/mach-ep93xx/Kconfig b/arch/arm/mach-ep93xx/Kconfig
index 3a08b18..97a2493 100644
--- a/arch/arm/mach-ep93xx/Kconfig
+++ b/arch/arm/mach-ep93xx/Kconfig
@@ -182,6 +182,13 @@ config MACH_TS72XX
Say 'Y' here if you want your kernel to support the
Technologic Systems TS-72xx board.
+config MACH_VISION_EP9307
+ bool "Support Vision Engraving Systems EP9307 SoM"
+ depends on EP93XX_SDCE0_PHYS_OFFSET
+ help
+ Say 'Y' here if you want your kernel to support the
+ Vision Engraving Systems EP9307 SoM.
+
choice
prompt "Select a UART for early kernel messages"
diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
index 33ee2c8..bb5974c 100644
--- a/arch/arm/mach-ep93xx/Makefile
+++ b/arch/arm/mach-ep93xx/Makefile
@@ -13,3 +13,4 @@ obj-$(CONFIG_MACH_MICRO9) += micro9.o
obj-$(CONFIG_MACH_SIM_ONE) += simone.o
obj-$(CONFIG_MACH_SNAPPER_CL15) += snappercl15.o
obj-$(CONFIG_MACH_TS72XX) += ts72xx.o
+obj-$(CONFIG_MACH_VISION_EP9307)+= vision_ep9307.o
diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c
new file mode 100644
index 0000000..10f6488
--- /dev/null
+++ b/arch/arm/mach-ep93xx/vision_ep9307.c
@@ -0,0 +1,364 @@
+/*
+ * arch/arm/mach-ep93xx/vision_ep9307.c
+ * Vision Engraving Systems EP9307 SoM support.
+ *
+ * Copyright (C) 2008-2011 Vision Engraving Systems
+ * H Hartley Sweeten <hsweeten@visionengravers.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or (at
+ * your option) any later version.
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/platform_device.h>
+#include <linux/irq.h>
+#include <linux/gpio.h>
+#include <linux/fb.h>
+#include <linux/io.h>
+#include <linux/mtd/partitions.h>
+#include <linux/i2c.h>
+#include <linux/i2c-gpio.h>
+#include <linux/i2c/pca953x.h>
+#include <linux/spi/spi.h>
+#include <linux/spi/flash.h>
+#include <linux/spi/mmc_spi.h>
+#include <linux/mmc/host.h>
+
+#include <mach/hardware.h>
+#include <mach/fb.h>
+#include <mach/ep93xx_spi.h>
+
+#include <asm/mach-types.h>
+#include <asm/mach/map.h>
+#include <asm/mach/arch.h>
+
+/*************************************************************************
+ * Static I/O mappings for the FPGA
+ *************************************************************************/
+#define VISION_PHYS_BASE EP93XX_CS7_PHYS_BASE
+#define VISION_VIRT_BASE 0xfebff000
+
+static struct map_desc vision_io_desc[] __initdata = {
+ {
+ .virtual = VISION_VIRT_BASE,
+ .pfn = __phys_to_pfn(VISION_PHYS_BASE),
+ .length = SZ_4K,
+ .type = MT_DEVICE,
+ },
+};
+
+static void __init vision_map_io(void)
+{
+ ep93xx_map_io();
+
+ iotable_init(vision_io_desc, ARRAY_SIZE(vision_io_desc));
+}
+
+/*************************************************************************
+ * Ethernet
+ *************************************************************************/
+static struct ep93xx_eth_data vision_eth_data __initdata = {
+ .phy_id = 1,
+};
+
+/*************************************************************************
+ * Framebuffer
+ *************************************************************************/
+#define VISION_LCD_ENABLE EP93XX_GPIO_LINE_EGPIO1
+
+static int vision_lcd_setup(struct platform_device *pdev)
+{
+ int err;
+
+ err = gpio_request_one(VISION_LCD_ENABLE, GPIOF_INIT_HIGH,
+ dev_name(&pdev->dev));
+ if (err)
+ return err;
+
+ ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_RAS |
+ EP93XX_SYSCON_DEVCFG_RASONP3 |
+ EP93XX_SYSCON_DEVCFG_EXVC);
+
+ return 0;
+}
+
+static void vision_lcd_teardown(struct platform_device *pdev)
+{
+ gpio_free(VISION_LCD_ENABLE);
+}
+
+static void vision_lcd_blank(int blank_mode, struct fb_info *info)
+{
+ if (blank_mode)
+ gpio_set_value(VISION_LCD_ENABLE, 0);
+ else
+ gpio_set_value(VISION_LCD_ENABLE, 1);
+}
+
+static struct ep93xxfb_mach_info ep93xxfb_info __initdata = {
+ .num_modes = EP93XXFB_USE_MODEDB,
+ .bpp = 16,
+ .flags = EP93XXFB_USE_SDCSN0 | EP93XXFB_PCLK_FALLING,
+ .setup = vision_lcd_setup,
+ .teardown = vision_lcd_teardown,
+ .blank = vision_lcd_blank,
+};
+
+
+/*************************************************************************
+ * GPIO Expanders
+ *************************************************************************/
+#define PCA9539_74_GPIO_BASE (EP93XX_GPIO_LINE_MAX + 1)
+#define PCA9539_75_GPIO_BASE (PCA9539_74_GPIO_BASE + 16)
+#define PCA9539_76_GPIO_BASE (PCA9539_75_GPIO_BASE + 16)
+#define PCA9539_77_GPIO_BASE (PCA9539_76_GPIO_BASE + 16)
+
+static struct pca953x_platform_data pca953x_74_gpio_data = {
+ .gpio_base = PCA9539_74_GPIO_BASE,
+ .irq_base = EP93XX_BOARD_IRQ(0),
+};
+
+static struct pca953x_platform_data pca953x_75_gpio_data = {
+ .gpio_base = PCA9539_75_GPIO_BASE,
+ .irq_base = -1,
+};
+
+static struct pca953x_platform_data pca953x_76_gpio_data = {
+ .gpio_base = PCA9539_76_GPIO_BASE,
+ .irq_base = -1,
+};
+
+static struct pca953x_platform_data pca953x_77_gpio_data = {
+ .gpio_base = PCA9539_77_GPIO_BASE,
+ .irq_base = -1,
+};
+
+/*************************************************************************
+ * I2C Bus
+ *************************************************************************/
+static struct i2c_gpio_platform_data vision_i2c_gpio_data __initdata = {
+ .sda_pin = EP93XX_GPIO_LINE_EEDAT,
+ .scl_pin = EP93XX_GPIO_LINE_EECLK,
+};
+
+static struct i2c_board_info vision_i2c_info[] __initdata = {
+ {
+ I2C_BOARD_INFO("isl1208", 0x6f),
+ .irq = IRQ_EP93XX_EXT1,
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x74),
+ .platform_data = &pca953x_74_gpio_data,
+ .irq = gpio_to_irq(EP93XX_GPIO_LINE_F(7)),
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x75),
+ .platform_data = &pca953x_75_gpio_data,
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x76),
+ .platform_data = &pca953x_76_gpio_data,
+ }, {
+ I2C_BOARD_INFO("pca9539", 0x77),
+ .platform_data = &pca953x_77_gpio_data,
+ },
+};
+
+/*************************************************************************
+ * SPI Flash
+ *************************************************************************/
+#define VISION_SPI_FLASH_CS EP93XX_GPIO_LINE_EGPIO7
+
+static struct mtd_partition vision_spi_flash_partitions[] = {
+ {
+ .name = "SPI bootstrap",
+ .offset = 0,
+ .size = SZ_4K,
+ }, {
+ .name = "Bootstrap config",
+ .offset = MTDPART_OFS_APPEND,
+ .size = SZ_4K,
+ }, {
+ .name = "System config",
+ .offset = MTDPART_OFS_APPEND,
+ .size = MTDPART_SIZ_FULL,
+ },
+};
+
+static struct flash_platform_data vision_spi_flash_data = {
+ .name = "SPI Flash",
+ .parts = vision_spi_flash_partitions,
+ .nr_parts = ARRAY_SIZE(vision_spi_flash_partitions),
+};
+
+static int vision_spi_flash_hw_setup(struct spi_device *spi)
+{
+ return gpio_request_one(VISION_SPI_FLASH_CS, GPIOF_INIT_HIGH,
+ spi->modalias);
+}
+
+static void vision_spi_flash_hw_cleanup(struct spi_device *spi)
+{
+ gpio_free(VISION_SPI_FLASH_CS);
+}
+
+static void vision_spi_flash_hw_cs_control(struct spi_device *spi, int value)
+{
+ gpio_set_value(VISION_SPI_FLASH_CS, value);
+}
+
+static struct ep93xx_spi_chip_ops vision_spi_flash_hw = {
+ .setup = vision_spi_flash_hw_setup,
+ .cleanup = vision_spi_flash_hw_cleanup,
+ .cs_control = vision_spi_flash_hw_cs_control,
+};
+
+/*************************************************************************
+ * SPI SD/MMC host
+ *************************************************************************/
+#define VISION_SPI_MMC_CS EP93XX_GPIO_LINE_G(2)
+#define VISION_SPI_MMC_WP EP93XX_GPIO_LINE_F(0)
+#define VISION_SPI_MMC_CD EP93XX_GPIO_LINE_EGPIO15
+
+static struct gpio vision_spi_mmc_gpios[] = {
+ { VISION_SPI_MMC_WP, GPIOF_DIR_IN, "mmc_spi:wp" },
+ { VISION_SPI_MMC_CD, GPIOF_DIR_IN, "mmc_spi:cd" },
+};
+
+static int vision_spi_mmc_init(struct device *pdev,
+ irqreturn_t (*func)(int, void *), void *pdata)
+{
+ int err;
+
+ err = gpio_request_array(vision_spi_mmc_gpios,
+ ARRAY_SIZE(vision_spi_mmc_gpios));
+ if (err)
+ return err;
+
+ err = gpio_set_debounce(VISION_SPI_MMC_CD, 1);
+ if (err)
+ goto exit_err;
+
+ err = request_irq(gpio_to_irq(VISION_SPI_MMC_CD), func,
+ IRQ_TYPE_EDGE_BOTH, "mmc_spi:cd", pdata);
+ if (err)
+ goto exit_err;
+
+ return 0;
+
+exit_err:
+ gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
+ return err;
+
+}
+
+static void vision_spi_mmc_exit(struct device *pdev, void *pdata)
+{
+ free_irq(gpio_to_irq(VISION_SPI_MMC_CD), pdata);
+ gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
+}
+
+static int vision_spi_mmc_get_ro(struct device *pdev)
+{
+ return !!gpio_get_value(VISION_SPI_MMC_WP);
+}
+
+static int vision_spi_mmc_get_cd(struct device *pdev)
+{
+ return !gpio_get_value(VISION_SPI_MMC_CD);
+}
+
+static struct mmc_spi_platform_data vision_spi_mmc_data = {
+ .init = vision_spi_mmc_init,
+ .exit = vision_spi_mmc_exit,
+ .get_ro = vision_spi_mmc_get_ro,
+ .get_cd = vision_spi_mmc_get_cd,
+ .detect_delay = 100,
+ .powerup_msecs = 100,
+ .ocr_mask = MMC_VDD_32_33 | MMC_VDD_33_34,
+};
+
+static int vision_spi_mmc_hw_setup(struct spi_device *spi)
+{
+ return gpio_request_one(VISION_SPI_MMC_CS, GPIOF_INIT_HIGH,
+ spi->modalias);
+}
+
+static void vision_spi_mmc_hw_cleanup(struct spi_device *spi)
+{
+ gpio_free(VISION_SPI_MMC_CS);
+}
+
+static void vision_spi_mmc_hw_cs_control(struct spi_device *spi, int value)
+{
+ gpio_set_value(VISION_SPI_MMC_CS, value);
+}
+
+static struct ep93xx_spi_chip_ops vision_spi_mmc_hw = {
+ .setup = vision_spi_mmc_hw_setup,
+ .cleanup = vision_spi_mmc_hw_cleanup,
+ .cs_control = vision_spi_mmc_hw_cs_control,
+};
+
+/*************************************************************************
+ * SPI Bus
+ *************************************************************************/
+static struct spi_board_info vision_spi_board_info[] __initdata = {
+ {
+ .modalias = "sst25l",
+ .platform_data = &vision_spi_flash_data,
+ .controller_data = &vision_spi_flash_hw,
+ .max_speed_hz = 20000000,
+ .bus_num = 0,
+ .chip_select = 0,
+ .mode = SPI_MODE_3,
+ }, {
+ .modalias = "mmc_spi",
+ .platform_data = &vision_spi_mmc_data,
+ .controller_data = &vision_spi_mmc_hw,
+ .max_speed_hz = 20000000,
+ .bus_num = 0,
+ .chip_select = 1,
+ .mode = SPI_MODE_3,
+ },
+};
+
+static struct ep93xx_spi_info vision_spi_master __initdata = {
+ .num_chipselect = ARRAY_SIZE(vision_spi_board_info),
+};
+
+/*************************************************************************
+ * Machine Initialization
+ *************************************************************************/
+static void __init vision_init_machine(void)
+{
+ ep93xx_init_devices();
+ ep93xx_register_flash(2, EP93XX_CS6_PHYS_BASE, SZ_64M);
+ ep93xx_register_eth(&vision_eth_data, 1);
+ ep93xx_register_fb(&ep93xxfb_info);
+ ep93xx_register_pwm(1, 0);
+
+ /*
+ * Request the gpio expander's interrupt gpio line now to prevent
+ * the kernel from doing a WARN in gpiolib:gpio_ensure_requested().
+ */
+ if (gpio_request_one(EP93XX_GPIO_LINE_F(7), GPIOF_DIR_IN,
+ "pca9539:74"))
+ pr_warn("cannot request interrupt gpio for pca9539:74\n");
+
+ ep93xx_register_i2c(&vision_i2c_gpio_data, vision_i2c_info,
+ ARRAY_SIZE(vision_i2c_info));
+ ep93xx_register_spi(&vision_spi_master, vision_spi_board_info,
+ ARRAY_SIZE(vision_spi_board_info));
+}
+
+MACHINE_START(VISION_EP9307, "Vision Engraving Systems EP9307")
+ /* Maintainer: H Hartley Sweeten <hsweeten@visionengravers.com> */
+ .boot_params = EP93XX_SDCE0_PHYS_BASE + 0x100,
+ .map_io = vision_map_io,
+ .init_irq = ep93xx_init_irq,
+ .timer = &ep93xx_timer,
+ .init_machine = vision_init_machine,
+MACHINE_END
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] ep93xx: add support Vision EP9307 SoM
2011-03-28 20:22 ` H Hartley Sweeten
@ 2011-03-28 20:27 ` Ryan Mallon
0 siblings, 0 replies; 7+ messages in thread
From: Ryan Mallon @ 2011-03-28 20:27 UTC (permalink / raw)
To: linux-arm-kernel
On 03/29/2011 09:22 AM, H Hartley Sweeten wrote:
> Add support for Vision Engraving Systems EP9307 based SoM.
>
> Signed-off-by: Hartley Sweeten <hartleys@visionengravers.com>
> Cc: Ryan Mallon <ryan@bluewatersys.com>
Looks okay to me:
Acked-by: Ryan Mallon <ryan@bluewatersys.com>
> ---
>
> V2: updated based on comments from Ryan Mallon
>
> diff --git a/arch/arm/mach-ep93xx/Kconfig b/arch/arm/mach-ep93xx/Kconfig
> index 3a08b18..97a2493 100644
> --- a/arch/arm/mach-ep93xx/Kconfig
> +++ b/arch/arm/mach-ep93xx/Kconfig
> @@ -182,6 +182,13 @@ config MACH_TS72XX
> Say 'Y' here if you want your kernel to support the
> Technologic Systems TS-72xx board.
>
> +config MACH_VISION_EP9307
> + bool "Support Vision Engraving Systems EP9307 SoM"
> + depends on EP93XX_SDCE0_PHYS_OFFSET
> + help
> + Say 'Y' here if you want your kernel to support the
> + Vision Engraving Systems EP9307 SoM.
> +
> choice
> prompt "Select a UART for early kernel messages"
>
> diff --git a/arch/arm/mach-ep93xx/Makefile b/arch/arm/mach-ep93xx/Makefile
> index 33ee2c8..bb5974c 100644
> --- a/arch/arm/mach-ep93xx/Makefile
> +++ b/arch/arm/mach-ep93xx/Makefile
> @@ -13,3 +13,4 @@ obj-$(CONFIG_MACH_MICRO9) += micro9.o
> obj-$(CONFIG_MACH_SIM_ONE) += simone.o
> obj-$(CONFIG_MACH_SNAPPER_CL15) += snappercl15.o
> obj-$(CONFIG_MACH_TS72XX) += ts72xx.o
> +obj-$(CONFIG_MACH_VISION_EP9307)+= vision_ep9307.o
> diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c
> new file mode 100644
> index 0000000..10f6488
> --- /dev/null
> +++ b/arch/arm/mach-ep93xx/vision_ep9307.c
> @@ -0,0 +1,364 @@
> +/*
> + * arch/arm/mach-ep93xx/vision_ep9307.c
> + * Vision Engraving Systems EP9307 SoM support.
> + *
> + * Copyright (C) 2008-2011 Vision Engraving Systems
> + * H Hartley Sweeten <hsweeten@visionengravers.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or (at
> + * your option) any later version.
> + */
> +
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
> +#include <linux/kernel.h>
> +#include <linux/init.h>
> +#include <linux/platform_device.h>
> +#include <linux/irq.h>
> +#include <linux/gpio.h>
> +#include <linux/fb.h>
> +#include <linux/io.h>
> +#include <linux/mtd/partitions.h>
> +#include <linux/i2c.h>
> +#include <linux/i2c-gpio.h>
> +#include <linux/i2c/pca953x.h>
> +#include <linux/spi/spi.h>
> +#include <linux/spi/flash.h>
> +#include <linux/spi/mmc_spi.h>
> +#include <linux/mmc/host.h>
> +
> +#include <mach/hardware.h>
> +#include <mach/fb.h>
> +#include <mach/ep93xx_spi.h>
> +
> +#include <asm/mach-types.h>
> +#include <asm/mach/map.h>
> +#include <asm/mach/arch.h>
> +
> +/*************************************************************************
> + * Static I/O mappings for the FPGA
> + *************************************************************************/
> +#define VISION_PHYS_BASE EP93XX_CS7_PHYS_BASE
> +#define VISION_VIRT_BASE 0xfebff000
> +
> +static struct map_desc vision_io_desc[] __initdata = {
> + {
> + .virtual = VISION_VIRT_BASE,
> + .pfn = __phys_to_pfn(VISION_PHYS_BASE),
> + .length = SZ_4K,
> + .type = MT_DEVICE,
> + },
> +};
> +
> +static void __init vision_map_io(void)
> +{
> + ep93xx_map_io();
> +
> + iotable_init(vision_io_desc, ARRAY_SIZE(vision_io_desc));
> +}
> +
> +/*************************************************************************
> + * Ethernet
> + *************************************************************************/
> +static struct ep93xx_eth_data vision_eth_data __initdata = {
> + .phy_id = 1,
> +};
> +
> +/*************************************************************************
> + * Framebuffer
> + *************************************************************************/
> +#define VISION_LCD_ENABLE EP93XX_GPIO_LINE_EGPIO1
> +
> +static int vision_lcd_setup(struct platform_device *pdev)
> +{
> + int err;
> +
> + err = gpio_request_one(VISION_LCD_ENABLE, GPIOF_INIT_HIGH,
> + dev_name(&pdev->dev));
> + if (err)
> + return err;
> +
> + ep93xx_devcfg_clear_bits(EP93XX_SYSCON_DEVCFG_RAS |
> + EP93XX_SYSCON_DEVCFG_RASONP3 |
> + EP93XX_SYSCON_DEVCFG_EXVC);
> +
> + return 0;
> +}
> +
> +static void vision_lcd_teardown(struct platform_device *pdev)
> +{
> + gpio_free(VISION_LCD_ENABLE);
> +}
> +
> +static void vision_lcd_blank(int blank_mode, struct fb_info *info)
> +{
> + if (blank_mode)
> + gpio_set_value(VISION_LCD_ENABLE, 0);
> + else
> + gpio_set_value(VISION_LCD_ENABLE, 1);
> +}
> +
> +static struct ep93xxfb_mach_info ep93xxfb_info __initdata = {
> + .num_modes = EP93XXFB_USE_MODEDB,
> + .bpp = 16,
> + .flags = EP93XXFB_USE_SDCSN0 | EP93XXFB_PCLK_FALLING,
> + .setup = vision_lcd_setup,
> + .teardown = vision_lcd_teardown,
> + .blank = vision_lcd_blank,
> +};
> +
> +
> +/*************************************************************************
> + * GPIO Expanders
> + *************************************************************************/
> +#define PCA9539_74_GPIO_BASE (EP93XX_GPIO_LINE_MAX + 1)
> +#define PCA9539_75_GPIO_BASE (PCA9539_74_GPIO_BASE + 16)
> +#define PCA9539_76_GPIO_BASE (PCA9539_75_GPIO_BASE + 16)
> +#define PCA9539_77_GPIO_BASE (PCA9539_76_GPIO_BASE + 16)
> +
> +static struct pca953x_platform_data pca953x_74_gpio_data = {
> + .gpio_base = PCA9539_74_GPIO_BASE,
> + .irq_base = EP93XX_BOARD_IRQ(0),
> +};
> +
> +static struct pca953x_platform_data pca953x_75_gpio_data = {
> + .gpio_base = PCA9539_75_GPIO_BASE,
> + .irq_base = -1,
> +};
> +
> +static struct pca953x_platform_data pca953x_76_gpio_data = {
> + .gpio_base = PCA9539_76_GPIO_BASE,
> + .irq_base = -1,
> +};
> +
> +static struct pca953x_platform_data pca953x_77_gpio_data = {
> + .gpio_base = PCA9539_77_GPIO_BASE,
> + .irq_base = -1,
> +};
> +
> +/*************************************************************************
> + * I2C Bus
> + *************************************************************************/
> +static struct i2c_gpio_platform_data vision_i2c_gpio_data __initdata = {
> + .sda_pin = EP93XX_GPIO_LINE_EEDAT,
> + .scl_pin = EP93XX_GPIO_LINE_EECLK,
> +};
> +
> +static struct i2c_board_info vision_i2c_info[] __initdata = {
> + {
> + I2C_BOARD_INFO("isl1208", 0x6f),
> + .irq = IRQ_EP93XX_EXT1,
> + }, {
> + I2C_BOARD_INFO("pca9539", 0x74),
> + .platform_data = &pca953x_74_gpio_data,
> + .irq = gpio_to_irq(EP93XX_GPIO_LINE_F(7)),
> + }, {
> + I2C_BOARD_INFO("pca9539", 0x75),
> + .platform_data = &pca953x_75_gpio_data,
> + }, {
> + I2C_BOARD_INFO("pca9539", 0x76),
> + .platform_data = &pca953x_76_gpio_data,
> + }, {
> + I2C_BOARD_INFO("pca9539", 0x77),
> + .platform_data = &pca953x_77_gpio_data,
> + },
> +};
> +
> +/*************************************************************************
> + * SPI Flash
> + *************************************************************************/
> +#define VISION_SPI_FLASH_CS EP93XX_GPIO_LINE_EGPIO7
> +
> +static struct mtd_partition vision_spi_flash_partitions[] = {
> + {
> + .name = "SPI bootstrap",
> + .offset = 0,
> + .size = SZ_4K,
> + }, {
> + .name = "Bootstrap config",
> + .offset = MTDPART_OFS_APPEND,
> + .size = SZ_4K,
> + }, {
> + .name = "System config",
> + .offset = MTDPART_OFS_APPEND,
> + .size = MTDPART_SIZ_FULL,
> + },
> +};
> +
> +static struct flash_platform_data vision_spi_flash_data = {
> + .name = "SPI Flash",
> + .parts = vision_spi_flash_partitions,
> + .nr_parts = ARRAY_SIZE(vision_spi_flash_partitions),
> +};
> +
> +static int vision_spi_flash_hw_setup(struct spi_device *spi)
> +{
> + return gpio_request_one(VISION_SPI_FLASH_CS, GPIOF_INIT_HIGH,
> + spi->modalias);
> +}
> +
> +static void vision_spi_flash_hw_cleanup(struct spi_device *spi)
> +{
> + gpio_free(VISION_SPI_FLASH_CS);
> +}
> +
> +static void vision_spi_flash_hw_cs_control(struct spi_device *spi, int value)
> +{
> + gpio_set_value(VISION_SPI_FLASH_CS, value);
> +}
> +
> +static struct ep93xx_spi_chip_ops vision_spi_flash_hw = {
> + .setup = vision_spi_flash_hw_setup,
> + .cleanup = vision_spi_flash_hw_cleanup,
> + .cs_control = vision_spi_flash_hw_cs_control,
> +};
> +
> +/*************************************************************************
> + * SPI SD/MMC host
> + *************************************************************************/
> +#define VISION_SPI_MMC_CS EP93XX_GPIO_LINE_G(2)
> +#define VISION_SPI_MMC_WP EP93XX_GPIO_LINE_F(0)
> +#define VISION_SPI_MMC_CD EP93XX_GPIO_LINE_EGPIO15
> +
> +static struct gpio vision_spi_mmc_gpios[] = {
> + { VISION_SPI_MMC_WP, GPIOF_DIR_IN, "mmc_spi:wp" },
> + { VISION_SPI_MMC_CD, GPIOF_DIR_IN, "mmc_spi:cd" },
> +};
> +
> +static int vision_spi_mmc_init(struct device *pdev,
> + irqreturn_t (*func)(int, void *), void *pdata)
> +{
> + int err;
> +
> + err = gpio_request_array(vision_spi_mmc_gpios,
> + ARRAY_SIZE(vision_spi_mmc_gpios));
> + if (err)
> + return err;
> +
> + err = gpio_set_debounce(VISION_SPI_MMC_CD, 1);
> + if (err)
> + goto exit_err;
> +
> + err = request_irq(gpio_to_irq(VISION_SPI_MMC_CD), func,
> + IRQ_TYPE_EDGE_BOTH, "mmc_spi:cd", pdata);
> + if (err)
> + goto exit_err;
> +
> + return 0;
> +
> +exit_err:
> + gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
> + return err;
> +
> +}
> +
> +static void vision_spi_mmc_exit(struct device *pdev, void *pdata)
> +{
> + free_irq(gpio_to_irq(VISION_SPI_MMC_CD), pdata);
> + gpio_free_array(vision_spi_mmc_gpios, ARRAY_SIZE(vision_spi_mmc_gpios));
> +}
> +
> +static int vision_spi_mmc_get_ro(struct device *pdev)
> +{
> + return !!gpio_get_value(VISION_SPI_MMC_WP);
> +}
> +
> +static int vision_spi_mmc_get_cd(struct device *pdev)
> +{
> + return !gpio_get_value(VISION_SPI_MMC_CD);
> +}
> +
> +static struct mmc_spi_platform_data vision_spi_mmc_data = {
> + .init = vision_spi_mmc_init,
> + .exit = vision_spi_mmc_exit,
> + .get_ro = vision_spi_mmc_get_ro,
> + .get_cd = vision_spi_mmc_get_cd,
> + .detect_delay = 100,
> + .powerup_msecs = 100,
> + .ocr_mask = MMC_VDD_32_33 | MMC_VDD_33_34,
> +};
> +
> +static int vision_spi_mmc_hw_setup(struct spi_device *spi)
> +{
> + return gpio_request_one(VISION_SPI_MMC_CS, GPIOF_INIT_HIGH,
> + spi->modalias);
> +}
> +
> +static void vision_spi_mmc_hw_cleanup(struct spi_device *spi)
> +{
> + gpio_free(VISION_SPI_MMC_CS);
> +}
> +
> +static void vision_spi_mmc_hw_cs_control(struct spi_device *spi, int value)
> +{
> + gpio_set_value(VISION_SPI_MMC_CS, value);
> +}
> +
> +static struct ep93xx_spi_chip_ops vision_spi_mmc_hw = {
> + .setup = vision_spi_mmc_hw_setup,
> + .cleanup = vision_spi_mmc_hw_cleanup,
> + .cs_control = vision_spi_mmc_hw_cs_control,
> +};
> +
> +/*************************************************************************
> + * SPI Bus
> + *************************************************************************/
> +static struct spi_board_info vision_spi_board_info[] __initdata = {
> + {
> + .modalias = "sst25l",
> + .platform_data = &vision_spi_flash_data,
> + .controller_data = &vision_spi_flash_hw,
> + .max_speed_hz = 20000000,
> + .bus_num = 0,
> + .chip_select = 0,
> + .mode = SPI_MODE_3,
> + }, {
> + .modalias = "mmc_spi",
> + .platform_data = &vision_spi_mmc_data,
> + .controller_data = &vision_spi_mmc_hw,
> + .max_speed_hz = 20000000,
> + .bus_num = 0,
> + .chip_select = 1,
> + .mode = SPI_MODE_3,
> + },
> +};
> +
> +static struct ep93xx_spi_info vision_spi_master __initdata = {
> + .num_chipselect = ARRAY_SIZE(vision_spi_board_info),
> +};
> +
> +/*************************************************************************
> + * Machine Initialization
> + *************************************************************************/
> +static void __init vision_init_machine(void)
> +{
> + ep93xx_init_devices();
> + ep93xx_register_flash(2, EP93XX_CS6_PHYS_BASE, SZ_64M);
> + ep93xx_register_eth(&vision_eth_data, 1);
> + ep93xx_register_fb(&ep93xxfb_info);
> + ep93xx_register_pwm(1, 0);
> +
> + /*
> + * Request the gpio expander's interrupt gpio line now to prevent
> + * the kernel from doing a WARN in gpiolib:gpio_ensure_requested().
> + */
> + if (gpio_request_one(EP93XX_GPIO_LINE_F(7), GPIOF_DIR_IN,
> + "pca9539:74"))
> + pr_warn("cannot request interrupt gpio for pca9539:74\n");
> +
> + ep93xx_register_i2c(&vision_i2c_gpio_data, vision_i2c_info,
> + ARRAY_SIZE(vision_i2c_info));
> + ep93xx_register_spi(&vision_spi_master, vision_spi_board_info,
> + ARRAY_SIZE(vision_spi_board_info));
> +}
> +
> +MACHINE_START(VISION_EP9307, "Vision Engraving Systems EP9307")
> + /* Maintainer: H Hartley Sweeten <hsweeten@visionengravers.com> */
> + .boot_params = EP93XX_SDCE0_PHYS_BASE + 0x100,
> + .map_io = vision_map_io,
> + .init_irq = ep93xx_init_irq,
> + .timer = &ep93xx_timer,
> + .init_machine = vision_init_machine,
> +MACHINE_END
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ep93xx: add support Vision EP9307 SoM
2011-03-28 19:30 ` Ryan Mallon
2011-03-28 19:46 ` H Hartley Sweeten
@ 2011-03-29 12:56 ` Sergei Shtylyov
1 sibling, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2011-03-29 12:56 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 28-03-2011 23:30, Ryan Mallon wrote:
>> Add support for Vision Engraving Systems EP9307 based SoM.
>> Signed-off-by: Hartley Sweeten<hartleys@visionengravers.com>
>> Cc: Ryan Mallon<ryan@bluewatersys.com>
> Hi Hartley,
> Looks mostly good. Couple of minor comments below.
> ~Ryan
>> ---
>> diff --git a/arch/arm/mach-ep93xx/vision_ep9307.c b/arch/arm/mach-ep93xx/vision_ep9307.c
>> new file mode 100644
>> index 0000000..cb2d400
>> --- /dev/null
>> +++ b/arch/arm/mach-ep93xx/vision_ep9307.c
>> @@ -0,0 +1,377 @@
[...]
>> +static void vision_lcd_blank(int blank_mode, struct fb_info *info)
>> +{
>> + if (blank_mode)
>> + gpio_set_value(VISION_LCD_ENABLE, 0);
>> + else
>> + gpio_set_value(VISION_LCD_ENABLE, 1);
> This can just be:
>
> gpio_set_value(VISION_LCD_ENABLE, blank_mode ^ 1);
Rather:
gpio_set_value(VISION_LCD_ENABLE, !blank_mode);
WBR, Sergei
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-03-29 12:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 18:27 [PATCH] ep93xx: add support Vision EP9307 SoM H Hartley Sweeten
2011-03-28 19:30 ` Ryan Mallon
2011-03-28 19:46 ` H Hartley Sweeten
2011-03-28 19:48 ` Ryan Mallon
2011-03-28 20:22 ` H Hartley Sweeten
2011-03-28 20:27 ` Ryan Mallon
2011-03-29 12:56 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).