From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 29/29] arm: Fold irq_set_chip/irq_set_handler
Date: Tue, 29 Mar 2011 09:49:52 +0200 [thread overview]
Message-ID: <4D918F20.8050301@atmel.com> (raw)
In-Reply-To: <20110328170653.550118582@linutronix.de>
Le 28/03/2011 19:12, Thomas Gleixner :
> Use irq_set_chip_and_handler() instead. Converted with coccinelle.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
[..]
> arch/arm/mach-at91/gpio.c | 4 ++--
> arch/arm/mach-at91/irq.c | 3 +--
[..]
> Index: linux-2.6-tip/arch/arm/mach-at91/gpio.c
> ===================================================================
> --- linux-2.6-tip.orig/arch/arm/mach-at91/gpio.c
> +++ linux-2.6-tip/arch/arm/mach-at91/gpio.c
> @@ -511,8 +511,8 @@ void __init at91_gpio_irq_setup(void)
> * Can use the "simple" and not "edge" handler since it's
> * shorter, and the AIC handles interrupts sanely.
> */
> - irq_set_chip(pin, &gpio_irqchip);
> - irq_set_handler(pin, handle_simple_irq);
> + irq_set_chip_and_handler(pin, &gpio_irqchip,
> + handle_simple_irq);
> set_irq_flags(pin, IRQF_VALID);
> }
>
> Index: linux-2.6-tip/arch/arm/mach-at91/irq.c
> ===================================================================
> --- linux-2.6-tip.orig/arch/arm/mach-at91/irq.c
> +++ linux-2.6-tip/arch/arm/mach-at91/irq.c
> @@ -143,8 +143,7 @@ void __init at91_aic_init(unsigned int p
> /* Active Low interrupt, with the specified priority */
> at91_sys_write(AT91_AIC_SMR(i), AT91_AIC_SRCTYPE_LOW | priority[i]);
>
> - irq_set_chip(i, &at91_aic_chip);
> - irq_set_handler(i, handle_level_irq);
> + irq_set_chip_and_handler(i, &at91_aic_chip, handle_level_irq);
> set_irq_flags(i, IRQF_VALID | IRQF_PROBE);
>
> /* Perform 8 End Of Interrupt Command to make sure AIC will not Lock out nIRQ */
[..]
Thanks a lot Thomas,
Best regards,
--
Nicolas Ferre
next prev parent reply other threads:[~2011-03-29 7:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 17:12 [patch 00/29] arm: bug fixes and irq cleanup (v2) for .39 Thomas Gleixner
2011-03-28 17:12 ` [patch 01/29] arm: bios32: Remove non exisiting machine code Thomas Gleixner
2011-03-28 17:12 ` [patch 02/29] arm: footbridge: Make cksrc_dc21285_disable() void Thomas Gleixner
2011-03-28 17:12 ` [patch 03/29] arm: at91: at572d940hf: Fix SDRAMC define Thomas Gleixner
2011-03-29 7:46 ` Nicolas Ferre
2011-03-28 17:12 ` [patch 04/29] arm: dove: Use correct GPIO_BASE and remove orion_gpio_init() leftover Thomas Gleixner
2011-03-28 17:12 ` [patch 05/29] arm: ns9xxx: Remove non exisiting machine checks Thomas Gleixner
2011-03-28 17:12 ` [patch 07/29] arm: h720x: Fix irq conversion fallout Thomas Gleixner
2011-03-28 17:12 ` [patch 06/29] arm: nomadik: Remove non existing cpu id check Thomas Gleixner
2011-03-29 5:35 ` Srinidhi Kasagar
2011-03-28 17:12 ` [patch 08/29] arm: tegra: Remove unused bogus irq enable/disable magic Thomas Gleixner
2011-03-28 19:00 ` Colin Cross
2011-03-28 19:13 ` Thomas Gleixner
2011-03-28 17:12 ` [patch 10/29] arm: Use irq flag setter function Thomas Gleixner
2011-03-28 17:12 ` [patch 09/29] arm: Use genirq lockdep helper to set lock class Thomas Gleixner
2011-03-28 17:12 ` [patch 12/29] arm: Cleanup irq_desc access Thomas Gleixner
2011-03-28 17:12 ` [patch 11/29] arm: msm: Convert to new irq chip functions Thomas Gleixner
2011-03-28 17:12 ` [patch 13/29] arm: plat-samsung: Use proper irq accessor functions Thomas Gleixner
2011-03-28 17:12 ` [patch 14/29] arm: stmp3xxx: Use generic_handle_irq() Thomas Gleixner
2011-03-28 17:12 ` [patch 15/29] arm: nomadik: Use local irq state Thomas Gleixner
2011-03-28 17:12 ` [patch 17/29] arm: msm: Use proper irq accessor functions Thomas Gleixner
2011-03-28 17:12 ` [patch 16/29] arm: plat-omap: Cleanup irq_desc access Thomas Gleixner
2011-03-28 17:12 ` [patch 18/29] arm: vt8500: Use proper irq accessors Thomas Gleixner
2011-03-28 17:12 ` [patch 19/29] arm: mxc: Use generic_handle_irq() Thomas Gleixner
2011-03-28 17:12 ` [patch 21/29] arm: ep93xx: Use proper irq accessor functions Thomas Gleixner
2011-03-28 17:12 ` [patch 20/29] arm: gemini: " Thomas Gleixner
2011-03-28 17:12 ` [patch 22/29] arm: davinci: Cleanup irq chip code Thomas Gleixner
2011-03-28 17:12 ` [patch 24/29] arm: gic: Use proper accessor functions Thomas Gleixner
2011-03-28 17:12 ` [patch 23/29] arm: at91: Cleanup irq chip Thomas Gleixner
2011-03-29 8:00 ` Nicolas Ferre
2011-03-28 17:12 ` [patch 25/29] arm: dove: Use proper irq accessor functions Thomas Gleixner
2011-03-28 17:12 ` [patch 26/29] arm: Use generic show_interrupts() Thomas Gleixner
2011-03-28 17:12 ` [patch 28/29] arm: Reorder irq_set_ function calls Thomas Gleixner
2011-03-28 17:12 ` [patch 29/29] arm: Fold irq_set_chip/irq_set_handler Thomas Gleixner
2011-03-29 7:49 ` Nicolas Ferre [this message]
2011-03-28 17:13 ` [patch 27/29] arm: Cleanup the irq namespace Thomas Gleixner
2011-04-18 17:37 ` H Hartley Sweeten
2011-04-19 9:49 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D918F20.8050301@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).