* [PATCH v3] Add mmc device for i.MX23/28
@ 2011-02-21 10:42 Shawn Guo
2011-02-21 10:42 ` [PATCH v3 1/6] ARM: mxs/clock: fix base address missing in name##_set_parent Shawn Guo
` (6 more replies)
0 siblings, 7 replies; 24+ messages in thread
From: Shawn Guo @ 2011-02-21 10:42 UTC (permalink / raw)
To: linux-arm-kernel
This patch set is to add mmc device for i.MX23 and i.MX28.
Regards,
Shawn
^ permalink raw reply [flat|nested] 24+ messages in thread* [PATCH v3 1/6] ARM: mxs/clock: fix base address missing in name##_set_parent 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo @ 2011-02-21 10:42 ` Shawn Guo 2011-02-21 10:42 ` [PATCH v3 2/6] ARM: mxs: make ssp error irq definition consistent Shawn Guo ` (5 subsequent siblings) 6 siblings, 0 replies; 24+ messages in thread From: Shawn Guo @ 2011-02-21 10:42 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/clock-mx23.c | 2 +- arch/arm/mach-mxs/clock-mx28.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c index 350b28c..c19b69a 100644 --- a/arch/arm/mach-mxs/clock-mx23.c +++ b/arch/arm/mach-mxs/clock-mx23.c @@ -347,7 +347,7 @@ static int name##_set_parent(struct clk *clk, struct clk *parent) \ { \ if (parent != clk->parent) { \ __raw_writel(BM_CLKCTRL_CLKSEQ_BYPASS_##bit, \ - HW_CLKCTRL_CLKSEQ_TOG); \ + CLKCTRL_BASE_ADDR + HW_CLKCTRL_CLKSEQ_TOG); \ clk->parent = parent; \ } \ \ diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c index a3b4787..9f4ee36 100644 --- a/arch/arm/mach-mxs/clock-mx28.c +++ b/arch/arm/mach-mxs/clock-mx28.c @@ -483,7 +483,7 @@ static int name##_set_parent(struct clk *clk, struct clk *parent) \ { \ if (parent != clk->parent) { \ __raw_writel(BM_CLKCTRL_CLKSEQ_BYPASS_##bit, \ - HW_CLKCTRL_CLKSEQ_TOG); \ + CLKCTRL_BASE_ADDR + HW_CLKCTRL_CLKSEQ_TOG); \ clk->parent = parent; \ } \ \ -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v3 2/6] ARM: mxs: make ssp error irq definition consistent 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo 2011-02-21 10:42 ` [PATCH v3 1/6] ARM: mxs/clock: fix base address missing in name##_set_parent Shawn Guo @ 2011-02-21 10:42 ` Shawn Guo 2011-02-22 8:20 ` Uwe Kleine-König 2011-02-21 10:42 ` [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device Shawn Guo ` (4 subsequent siblings) 6 siblings, 1 reply; 24+ messages in thread From: Shawn Guo @ 2011-02-21 10:42 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/include/mach/mx23.h | 2 +- arch/arm/mach-mxs/include/mach/mx28.h | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-mxs/include/mach/mx23.h b/arch/arm/mach-mxs/include/mach/mx23.h index 1730c9c..e858692 100644 --- a/arch/arm/mach-mxs/include/mach/mx23.h +++ b/arch/arm/mach-mxs/include/mach/mx23.h @@ -93,7 +93,7 @@ #define MX23_INT_USB_WAKEUP 12 #define MX23_INT_GPMI_DMA 13 #define MX23_INT_SSP1_DMA 14 -#define MX23_INT_SSP_ERROR 15 +#define MX23_INT_SSP1_ERROR 15 #define MX23_INT_GPIO0 16 #define MX23_INT_GPIO1 17 #define MX23_INT_GPIO2 18 diff --git a/arch/arm/mach-mxs/include/mach/mx28.h b/arch/arm/mach-mxs/include/mach/mx28.h index 3f3485a..75d8611 100644 --- a/arch/arm/mach-mxs/include/mach/mx28.h +++ b/arch/arm/mach-mxs/include/mach/mx28.h @@ -163,10 +163,10 @@ #define MX28_INT_USB0 93 #define MX28_INT_USB1_WAKEUP 94 #define MX28_INT_USB0_WAKEUP 95 -#define MX28_INT_SSP0 96 -#define MX28_INT_SSP1 97 -#define MX28_INT_SSP2 98 -#define MX28_INT_SSP3 99 +#define MX28_INT_SSP0_ERROR 96 +#define MX28_INT_SSP1_ERROR 97 +#define MX28_INT_SSP2_ERROR 98 +#define MX28_INT_SSP3_ERROR 99 #define MX28_INT_ENET_SWI 100 #define MX28_INT_ENET_MAC0 101 #define MX28_INT_ENET_MAC1 102 -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v3 2/6] ARM: mxs: make ssp error irq definition consistent 2011-02-21 10:42 ` [PATCH v3 2/6] ARM: mxs: make ssp error irq definition consistent Shawn Guo @ 2011-02-22 8:20 ` Uwe Kleine-König 0 siblings, 0 replies; 24+ messages in thread From: Uwe Kleine-König @ 2011-02-22 8:20 UTC (permalink / raw) To: linux-arm-kernel On Mon, Feb 21, 2011 at 06:42:55PM +0800, Shawn Guo wrote: > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > --- > arch/arm/mach-mxs/include/mach/mx23.h | 2 +- > arch/arm/mach-mxs/include/mach/mx28.h | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-mxs/include/mach/mx23.h b/arch/arm/mach-mxs/include/mach/mx23.h > index 1730c9c..e858692 100644 > --- a/arch/arm/mach-mxs/include/mach/mx23.h > +++ b/arch/arm/mach-mxs/include/mach/mx23.h > @@ -93,7 +93,7 @@ > #define MX23_INT_USB_WAKEUP 12 > #define MX23_INT_GPMI_DMA 13 > #define MX23_INT_SSP1_DMA 14 > -#define MX23_INT_SSP_ERROR 15 > +#define MX23_INT_SSP1_ERROR 15 SSP_ERROR matches the reference manual, but using SSP1 looks correct as there are >1 SSPs. > #define MX23_INT_GPIO0 16 > #define MX23_INT_GPIO1 17 > #define MX23_INT_GPIO2 18 > diff --git a/arch/arm/mach-mxs/include/mach/mx28.h b/arch/arm/mach-mxs/include/mach/mx28.h > index 3f3485a..75d8611 100644 > --- a/arch/arm/mach-mxs/include/mach/mx28.h > +++ b/arch/arm/mach-mxs/include/mach/mx28.h > @@ -163,10 +163,10 @@ > #define MX28_INT_USB0 93 > #define MX28_INT_USB1_WAKEUP 94 > #define MX28_INT_USB0_WAKEUP 95 > -#define MX28_INT_SSP0 96 > -#define MX28_INT_SSP1 97 > -#define MX28_INT_SSP2 98 > -#define MX28_INT_SSP3 99 > +#define MX28_INT_SSP0_ERROR 96 > +#define MX28_INT_SSP1_ERROR 97 > +#define MX28_INT_SSP2_ERROR 98 > +#define MX28_INT_SSP3_ERROR 99 > #define MX28_INT_ENET_SWI 100 > #define MX28_INT_ENET_MAC0 101 > #define MX28_INT_ENET_MAC1 102 Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo 2011-02-21 10:42 ` [PATCH v3 1/6] ARM: mxs/clock: fix base address missing in name##_set_parent Shawn Guo 2011-02-21 10:42 ` [PATCH v3 2/6] ARM: mxs: make ssp error irq definition consistent Shawn Guo @ 2011-02-21 10:42 ` Shawn Guo 2011-02-22 8:31 ` Uwe Kleine-König 2011-02-21 10:42 ` [PATCH v3 4/6] ARM: mxs: fix typo "GPO" in iomux-mx23.h Shawn Guo ` (3 subsequent siblings) 6 siblings, 1 reply; 24+ messages in thread From: Shawn Guo @ 2011-02-21 10:42 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/clock-mx23.c | 16 +++++ arch/arm/mach-mxs/clock-mx28.c | 18 +++++ arch/arm/mach-mxs/devices-mx23.h | 4 + arch/arm/mach-mxs/devices-mx28.h | 4 + arch/arm/mach-mxs/devices/Kconfig | 3 + arch/arm/mach-mxs/devices/Makefile | 1 + arch/arm/mach-mxs/devices/platform-mmc.c | 77 +++++++++++++++++++++++ arch/arm/mach-mxs/include/mach/devices-common.h | 13 ++++ 8 files changed, 136 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mxs/devices/platform-mmc.c diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c index c19b69a..a1ed5f4 100644 --- a/arch/arm/mach-mxs/clock-mx23.c +++ b/arch/arm/mach-mxs/clock-mx23.c @@ -445,6 +445,7 @@ static struct clk_lookup lookups[] = { _REGISTER_CLOCK("rtc", NULL, rtc_clk) _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp_clk) _REGISTER_CLOCK(NULL, "usb", usb_clk) _REGISTER_CLOCK(NULL, "audio", audio_clk) _REGISTER_CLOCK(NULL, "pwm", pwm_clk) @@ -515,6 +516,15 @@ static int clk_misc_init(void) __raw_writel(BM_CLKCTRL_CPU_INTERRUPT_WAIT, CLKCTRL_BASE_ADDR + HW_CLKCTRL_CPU_SET); + /* + * 480 MHz seems too high to be ssp clock source directly, + * so set frac to get a 288 MHz ref_io. + */ + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); + reg &= ~BM_CLKCTRL_FRAC_IOFRAC; + reg |= 30 << BP_CLKCTRL_FRAC_IOFRAC; + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); + return 0; } @@ -522,6 +532,12 @@ int __init mx23_clocks_init(void) { clk_misc_init(); + /* + * source ssp clock from ref_io than ref_xtal, + * as ref_xtal only provides 24 MHz as maximum. + */ + clk_set_parent(&ssp_clk, &ref_io_clk); + clk_enable(&cpu_clk); clk_enable(&hbus_clk); clk_enable(&xbus_clk); diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c index 9f4ee36..aeb7b2c 100644 --- a/arch/arm/mach-mxs/clock-mx28.c +++ b/arch/arm/mach-mxs/clock-mx28.c @@ -619,6 +619,8 @@ static struct clk_lookup lookups[] = { _REGISTER_CLOCK("pll2", NULL, pll2_clk) _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp0_clk) + _REGISTER_CLOCK("mxs-mmc.1", NULL, ssp1_clk) _REGISTER_CLOCK("flexcan.0", NULL, can0_clk) _REGISTER_CLOCK("flexcan.1", NULL, can1_clk) _REGISTER_CLOCK(NULL, "usb0", usb0_clk) @@ -730,6 +732,15 @@ static int clk_misc_init(void) reg |= BM_CLKCTRL_ENET_CLK_OUT_EN; __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_ENET); + /* + * 480 MHz seems too high to be ssp clock source directly, + * so set frac0 to get a 288 MHz ref_io0. + */ + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); + reg &= ~BM_CLKCTRL_FRAC0_IO0FRAC; + reg |= 30 << BP_CLKCTRL_FRAC0_IO0FRAC; + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); + return 0; } @@ -737,6 +748,13 @@ int __init mx28_clocks_init(void) { clk_misc_init(); + /* + * source ssp clock from ref_io0 than ref_xtal, + * as ref_xtal only provides 24 MHz as maximum. + */ + clk_set_parent(&ssp0_clk, &ref_io0_clk); + clk_set_parent(&ssp1_clk, &ref_io0_clk); + clk_enable(&cpu_clk); clk_enable(&hbus_clk); clk_enable(&xbus_clk); diff --git a/arch/arm/mach-mxs/devices-mx23.h b/arch/arm/mach-mxs/devices-mx23.h index 1256788..4419390 100644 --- a/arch/arm/mach-mxs/devices-mx23.h +++ b/arch/arm/mach-mxs/devices-mx23.h @@ -14,3 +14,7 @@ extern const struct amba_device mx23_duart_device __initconst; #define mx23_add_duart() \ mxs_add_duart(&mx23_duart_device) + +extern const struct mxs_mmc_data mx23_mmc_data[] __initconst; +#define mx23_add_mmc(id, pdata) \ + mxs_add_mmc(&mx23_mmc_data[id], pdata) diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h index 3b18304..540639d 100644 --- a/arch/arm/mach-mxs/devices-mx28.h +++ b/arch/arm/mach-mxs/devices-mx28.h @@ -32,3 +32,7 @@ extern const struct mxs_flexcan_data mx28_flexcan_data[] __initconst; mxs_add_flexcan(&mx28_flexcan_data[id], pdata) #define mx28_add_flexcan0(pdata) mx28_add_flexcan(0, pdata) #define mx28_add_flexcan1(pdata) mx28_add_flexcan(1, pdata) + +extern const struct mxs_mmc_data mx28_mmc_data[] __initconst; +#define mx28_add_mmc(id, pdata) \ + mxs_add_mmc(&mx28_mmc_data[id], pdata) diff --git a/arch/arm/mach-mxs/devices/Kconfig b/arch/arm/mach-mxs/devices/Kconfig index 6c65b67..49307f8 100644 --- a/arch/arm/mach-mxs/devices/Kconfig +++ b/arch/arm/mach-mxs/devices/Kconfig @@ -11,3 +11,6 @@ config MXS_HAVE_PLATFORM_FEC config MXS_HAVE_PLATFORM_FLEXCAN select HAVE_CAN_FLEXCAN if CAN bool + +config MXS_HAVE_PLATFORM_MMC + bool diff --git a/arch/arm/mach-mxs/devices/Makefile b/arch/arm/mach-mxs/devices/Makefile index ca7acc4..c0dacfd 100644 --- a/arch/arm/mach-mxs/devices/Makefile +++ b/arch/arm/mach-mxs/devices/Makefile @@ -3,3 +3,4 @@ obj-$(CONFIG_MXS_HAVE_PLATFORM_AUART) += platform-auart.o obj-y += platform-dma.o obj-$(CONFIG_MXS_HAVE_PLATFORM_FEC) += platform-fec.o obj-$(CONFIG_MXS_HAVE_PLATFORM_FLEXCAN) += platform-flexcan.o +obj-$(CONFIG_MXS_HAVE_PLATFORM_MMC) += platform-mmc.o diff --git a/arch/arm/mach-mxs/devices/platform-mmc.c b/arch/arm/mach-mxs/devices/platform-mmc.c new file mode 100644 index 0000000..868def1 --- /dev/null +++ b/arch/arm/mach-mxs/devices/platform-mmc.c @@ -0,0 +1,77 @@ +/* + * Copyright (C) 2010 Pengutronix + * Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> + * + * Copyright 2011 Freescale Semiconductor, Inc. All Rights Reserved. + * + * This program is free software; you can redistribute it and/or modify it under + * the terms of the GNU General Public License version 2 as published by the + * Free Software Foundation. + */ + +#include <linux/compiler.h> +#include <linux/err.h> +#include <linux/init.h> + +#include <mach/mx23.h> +#include <mach/mx28.h> +#include <mach/devices-common.h> + +#define mxs_mmc_data_entry_single(soc, _id, hwid) \ + { \ + .id = _id, \ + .iobase = soc ## _SSP ## hwid ## _BASE_ADDR, \ + .dma = soc ## _DMA_SSP ## hwid, \ + .irq_err = soc ## _INT_SSP ## hwid ## _ERROR, \ + .irq_dma = soc ## _INT_SSP ## hwid ## _DMA, \ + } + +#define mxs_mmc_data_entry(soc, _id, hwid) \ + [_id] = mxs_mmc_data_entry_single(soc, _id, hwid) + + +#ifdef CONFIG_SOC_IMX23 +const struct mxs_mmc_data mx23_mmc_data[] __initconst = { +#define mx23_mmc_data_entry(_id, hwid) \ + mxs_mmc_data_entry(MX23, _id, hwid) + mx23_mmc_data_entry(0, 1), + mx23_mmc_data_entry(1, 2), +}; +#endif + +#ifdef CONFIG_SOC_IMX28 +const struct mxs_mmc_data mx28_mmc_data[] __initconst = { +#define mx28_mmc_data_entry(_id) \ + mxs_mmc_data_entry(MX28, _id, _id) + mx28_mmc_data_entry(0), + mx28_mmc_data_entry(1), +}; +#endif + +struct platform_device *__init mxs_add_mmc( + const struct mxs_mmc_data *data, + const struct mxs_mmc_platform_data *pdata) +{ + struct resource res[] = { + { + .start = data->iobase, + .end = data->iobase + SZ_8K - 1, + .flags = IORESOURCE_MEM, + }, { + .start = data->dma, + .end = data->dma, + .flags = IORESOURCE_DMA, + }, { + .start = data->irq_err, + .end = data->irq_err, + .flags = IORESOURCE_IRQ, + }, { + .start = data->irq_dma, + .end = data->irq_dma, + .flags = IORESOURCE_IRQ, + }, + }; + + return mxs_add_platform_device("mxs-mmc", data->id, + res, ARRAY_SIZE(res), pdata, sizeof(*pdata)); +} diff --git a/arch/arm/mach-mxs/include/mach/devices-common.h b/arch/arm/mach-mxs/include/mach/devices-common.h index e7aefb4..54710c5 100644 --- a/arch/arm/mach-mxs/include/mach/devices-common.h +++ b/arch/arm/mach-mxs/include/mach/devices-common.h @@ -63,3 +63,16 @@ struct mxs_flexcan_data { struct platform_device *__init mxs_add_flexcan( const struct mxs_flexcan_data *data, const struct flexcan_platform_data *pdata); + +/* mmc */ +#include <mach/mmc.h> +struct mxs_mmc_data { + int id; + resource_size_t iobase; + resource_size_t dma; + resource_size_t irq_err; + resource_size_t irq_dma; +}; +struct platform_device *__init mxs_add_mmc( + const struct mxs_mmc_data *data, + const struct mxs_mmc_platform_data *pdata); -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device 2011-02-21 10:42 ` [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device Shawn Guo @ 2011-02-22 8:31 ` Uwe Kleine-König 2011-02-22 12:39 ` Shawn Guo 0 siblings, 1 reply; 24+ messages in thread From: Uwe Kleine-König @ 2011-02-22 8:31 UTC (permalink / raw) To: linux-arm-kernel On Mon, Feb 21, 2011 at 06:42:56PM +0800, Shawn Guo wrote: > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > --- > arch/arm/mach-mxs/clock-mx23.c | 16 +++++ > arch/arm/mach-mxs/clock-mx28.c | 18 +++++ > arch/arm/mach-mxs/devices-mx23.h | 4 + > arch/arm/mach-mxs/devices-mx28.h | 4 + > arch/arm/mach-mxs/devices/Kconfig | 3 + > arch/arm/mach-mxs/devices/Makefile | 1 + > arch/arm/mach-mxs/devices/platform-mmc.c | 77 +++++++++++++++++++++++ > arch/arm/mach-mxs/include/mach/devices-common.h | 13 ++++ > 8 files changed, 136 insertions(+), 0 deletions(-) > create mode 100644 arch/arm/mach-mxs/devices/platform-mmc.c > > diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c > index c19b69a..a1ed5f4 100644 > --- a/arch/arm/mach-mxs/clock-mx23.c > +++ b/arch/arm/mach-mxs/clock-mx23.c > @@ -445,6 +445,7 @@ static struct clk_lookup lookups[] = { > _REGISTER_CLOCK("rtc", NULL, rtc_clk) > _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) > _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) > + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp_clk) > _REGISTER_CLOCK(NULL, "usb", usb_clk) > _REGISTER_CLOCK(NULL, "audio", audio_clk) > _REGISTER_CLOCK(NULL, "pwm", pwm_clk) > @@ -515,6 +516,15 @@ static int clk_misc_init(void) > __raw_writel(BM_CLKCTRL_CPU_INTERRUPT_WAIT, > CLKCTRL_BASE_ADDR + HW_CLKCTRL_CPU_SET); > > + /* > + * 480 MHz seems too high to be ssp clock source directly, > + * so set frac to get a 288 MHz ref_io. > + */ > + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); > + reg &= ~BM_CLKCTRL_FRAC_IOFRAC; > + reg |= 30 << BP_CLKCTRL_FRAC_IOFRAC; > + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); > + > return 0; > } > > @@ -522,6 +532,12 @@ int __init mx23_clocks_init(void) > { > clk_misc_init(); > > + /* > + * source ssp clock from ref_io than ref_xtal, > + * as ref_xtal only provides 24 MHz as maximum. > + */ > + clk_set_parent(&ssp_clk, &ref_io_clk); > + > clk_enable(&cpu_clk); > clk_enable(&hbus_clk); > clk_enable(&xbus_clk); > diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c > index 9f4ee36..aeb7b2c 100644 > --- a/arch/arm/mach-mxs/clock-mx28.c > +++ b/arch/arm/mach-mxs/clock-mx28.c > @@ -619,6 +619,8 @@ static struct clk_lookup lookups[] = { > _REGISTER_CLOCK("pll2", NULL, pll2_clk) > _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) > _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) > + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp0_clk) > + _REGISTER_CLOCK("mxs-mmc.1", NULL, ssp1_clk) > _REGISTER_CLOCK("flexcan.0", NULL, can0_clk) > _REGISTER_CLOCK("flexcan.1", NULL, can1_clk) > _REGISTER_CLOCK(NULL, "usb0", usb0_clk) > @@ -730,6 +732,15 @@ static int clk_misc_init(void) > reg |= BM_CLKCTRL_ENET_CLK_OUT_EN; > __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_ENET); > > + /* > + * 480 MHz seems too high to be ssp clock source directly, > + * so set frac0 to get a 288 MHz ref_io0. > + */ > + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); > + reg &= ~BM_CLKCTRL_FRAC0_IO0FRAC; > + reg |= 30 << BP_CLKCTRL_FRAC0_IO0FRAC; > + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); > + > return 0; > } > > @@ -737,6 +748,13 @@ int __init mx28_clocks_init(void) > { > clk_misc_init(); > > + /* > + * source ssp clock from ref_io0 than ref_xtal, > + * as ref_xtal only provides 24 MHz as maximum. > + */ > + clk_set_parent(&ssp0_clk, &ref_io0_clk); > + clk_set_parent(&ssp1_clk, &ref_io0_clk); > + > clk_enable(&cpu_clk); > clk_enable(&hbus_clk); > clk_enable(&xbus_clk); > diff --git a/arch/arm/mach-mxs/devices-mx23.h b/arch/arm/mach-mxs/devices-mx23.h > index 1256788..4419390 100644 > --- a/arch/arm/mach-mxs/devices-mx23.h > +++ b/arch/arm/mach-mxs/devices-mx23.h > @@ -14,3 +14,7 @@ > extern const struct amba_device mx23_duart_device __initconst; > #define mx23_add_duart() \ > mxs_add_duart(&mx23_duart_device) > + > +extern const struct mxs_mmc_data mx23_mmc_data[] __initconst; > +#define mx23_add_mmc(id, pdata) \ > + mxs_add_mmc(&mx23_mmc_data[id], pdata) mxs_mmc please (not sure about mxs_mxs_mmc_data, but it would be consistent). At least mx23_add_mxs_mmc and mxs_add_mxs_mmc. > diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h > index 3b18304..540639d 100644 > --- a/arch/arm/mach-mxs/devices-mx28.h > +++ b/arch/arm/mach-mxs/devices-mx28.h > @@ -32,3 +32,7 @@ extern const struct mxs_flexcan_data mx28_flexcan_data[] __initconst; > mxs_add_flexcan(&mx28_flexcan_data[id], pdata) > #define mx28_add_flexcan0(pdata) mx28_add_flexcan(0, pdata) > #define mx28_add_flexcan1(pdata) mx28_add_flexcan(1, pdata) > + > +extern const struct mxs_mmc_data mx28_mmc_data[] __initconst; > +#define mx28_add_mmc(id, pdata) \ > + mxs_add_mmc(&mx28_mmc_data[id], pdata) This conflicts with my series, but it's trivial enough to let Sascha handle that. > diff --git a/arch/arm/mach-mxs/devices/Kconfig b/arch/arm/mach-mxs/devices/Kconfig > index 6c65b67..49307f8 100644 > --- a/arch/arm/mach-mxs/devices/Kconfig > +++ b/arch/arm/mach-mxs/devices/Kconfig > @@ -11,3 +11,6 @@ config MXS_HAVE_PLATFORM_FEC > config MXS_HAVE_PLATFORM_FLEXCAN > select HAVE_CAN_FLEXCAN if CAN > bool > + > +config MXS_HAVE_PLATFORM_MMC > + bool ditto MXS_HAVE_PLATFORM_MXS_MMC > diff --git a/arch/arm/mach-mxs/devices/Makefile b/arch/arm/mach-mxs/devices/Makefile > index ca7acc4..c0dacfd 100644 > --- a/arch/arm/mach-mxs/devices/Makefile > +++ b/arch/arm/mach-mxs/devices/Makefile > @@ -3,3 +3,4 @@ obj-$(CONFIG_MXS_HAVE_PLATFORM_AUART) += platform-auart.o > obj-y += platform-dma.o > obj-$(CONFIG_MXS_HAVE_PLATFORM_FEC) += platform-fec.o > obj-$(CONFIG_MXS_HAVE_PLATFORM_FLEXCAN) += platform-flexcan.o > +obj-$(CONFIG_MXS_HAVE_PLATFORM_MMC) += platform-mmc.o > diff --git a/arch/arm/mach-mxs/devices/platform-mmc.c b/arch/arm/mach-mxs/devices/platform-mmc.c > new file mode 100644 > index 0000000..868def1 > --- /dev/null > +++ b/arch/arm/mach-mxs/devices/platform-mmc.c > @@ -0,0 +1,77 @@ > +/* > + * Copyright (C) 2010 Pengutronix > + * Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > + * > + * Copyright 2011 Freescale Semiconductor, Inc. All Rights Reserved. > + * > + * This program is free software; you can redistribute it and/or modify it under > + * the terms of the GNU General Public License version 2 as published by the > + * Free Software Foundation. > + */ > + > +#include <linux/compiler.h> > +#include <linux/err.h> > +#include <linux/init.h> > + > +#include <mach/mx23.h> > +#include <mach/mx28.h> > +#include <mach/devices-common.h> > + > +#define mxs_mmc_data_entry_single(soc, _id, hwid) \ > + { \ > + .id = _id, \ > + .iobase = soc ## _SSP ## hwid ## _BASE_ADDR, \ > + .dma = soc ## _DMA_SSP ## hwid, \ > + .irq_err = soc ## _INT_SSP ## hwid ## _ERROR, \ > + .irq_dma = soc ## _INT_SSP ## hwid ## _DMA, \ > + } > + > +#define mxs_mmc_data_entry(soc, _id, hwid) \ > + [_id] = mxs_mmc_data_entry_single(soc, _id, hwid) > + > + > +#ifdef CONFIG_SOC_IMX23 > +const struct mxs_mmc_data mx23_mmc_data[] __initconst = { > +#define mx23_mmc_data_entry(_id, hwid) \ > + mxs_mmc_data_entry(MX23, _id, hwid) > + mx23_mmc_data_entry(0, 1), > + mx23_mmc_data_entry(1, 2), > +}; hmm, maybe let mxs-mmc.1 use MX23_SSP1_BASE_ADDR? BTW, Sascha pointed out that mxs_mmc_data_entry(MX23, 0, 1), mxs_mmc_data_entry(MX23, 1, 2), is easier than #define mx23_mmc_data_entry(_id, hwid) \ mxs_mmc_data_entry(MX23, _id, hwid) mx23_mmc_data_entry(0, 1), mx23_mmc_data_entry(1, 2), though it has to repeat MX23. > +#endif > + > +#ifdef CONFIG_SOC_IMX28 > +const struct mxs_mmc_data mx28_mmc_data[] __initconst = { > +#define mx28_mmc_data_entry(_id) \ > + mxs_mmc_data_entry(MX28, _id, _id) > + mx28_mmc_data_entry(0), > + mx28_mmc_data_entry(1), > +}; > +#endif hmm, so i.MX28 starts at 0, i.MX23 at 1. Well, that's how it is. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device 2011-02-22 8:31 ` Uwe Kleine-König @ 2011-02-22 12:39 ` Shawn Guo 2011-02-22 18:33 ` Uwe Kleine-König 0 siblings, 1 reply; 24+ messages in thread From: Shawn Guo @ 2011-02-22 12:39 UTC (permalink / raw) To: linux-arm-kernel On Tue, Feb 22, 2011 at 09:31:13AM +0100, Uwe Kleine-K?nig wrote: > On Mon, Feb 21, 2011 at 06:42:56PM +0800, Shawn Guo wrote: > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > --- > > arch/arm/mach-mxs/clock-mx23.c | 16 +++++ > > arch/arm/mach-mxs/clock-mx28.c | 18 +++++ > > arch/arm/mach-mxs/devices-mx23.h | 4 + > > arch/arm/mach-mxs/devices-mx28.h | 4 + > > arch/arm/mach-mxs/devices/Kconfig | 3 + > > arch/arm/mach-mxs/devices/Makefile | 1 + > > arch/arm/mach-mxs/devices/platform-mmc.c | 77 +++++++++++++++++++++++ > > arch/arm/mach-mxs/include/mach/devices-common.h | 13 ++++ > > 8 files changed, 136 insertions(+), 0 deletions(-) > > create mode 100644 arch/arm/mach-mxs/devices/platform-mmc.c > > > > diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c > > index c19b69a..a1ed5f4 100644 > > --- a/arch/arm/mach-mxs/clock-mx23.c > > +++ b/arch/arm/mach-mxs/clock-mx23.c > > @@ -445,6 +445,7 @@ static struct clk_lookup lookups[] = { > > _REGISTER_CLOCK("rtc", NULL, rtc_clk) > > _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) > > _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) > > + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp_clk) > > _REGISTER_CLOCK(NULL, "usb", usb_clk) > > _REGISTER_CLOCK(NULL, "audio", audio_clk) > > _REGISTER_CLOCK(NULL, "pwm", pwm_clk) > > @@ -515,6 +516,15 @@ static int clk_misc_init(void) > > __raw_writel(BM_CLKCTRL_CPU_INTERRUPT_WAIT, > > CLKCTRL_BASE_ADDR + HW_CLKCTRL_CPU_SET); > > > > + /* > > + * 480 MHz seems too high to be ssp clock source directly, > > + * so set frac to get a 288 MHz ref_io. > > + */ > > + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); > > + reg &= ~BM_CLKCTRL_FRAC_IOFRAC; > > + reg |= 30 << BP_CLKCTRL_FRAC_IOFRAC; > > + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); > > + > > return 0; > > } > > > > @@ -522,6 +532,12 @@ int __init mx23_clocks_init(void) > > { > > clk_misc_init(); > > > > + /* > > + * source ssp clock from ref_io than ref_xtal, > > + * as ref_xtal only provides 24 MHz as maximum. > > + */ > > + clk_set_parent(&ssp_clk, &ref_io_clk); > > + > > clk_enable(&cpu_clk); > > clk_enable(&hbus_clk); > > clk_enable(&xbus_clk); > > diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c > > index 9f4ee36..aeb7b2c 100644 > > --- a/arch/arm/mach-mxs/clock-mx28.c > > +++ b/arch/arm/mach-mxs/clock-mx28.c > > @@ -619,6 +619,8 @@ static struct clk_lookup lookups[] = { > > _REGISTER_CLOCK("pll2", NULL, pll2_clk) > > _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) > > _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) > > + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp0_clk) > > + _REGISTER_CLOCK("mxs-mmc.1", NULL, ssp1_clk) > > _REGISTER_CLOCK("flexcan.0", NULL, can0_clk) > > _REGISTER_CLOCK("flexcan.1", NULL, can1_clk) > > _REGISTER_CLOCK(NULL, "usb0", usb0_clk) > > @@ -730,6 +732,15 @@ static int clk_misc_init(void) > > reg |= BM_CLKCTRL_ENET_CLK_OUT_EN; > > __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_ENET); > > > > + /* > > + * 480 MHz seems too high to be ssp clock source directly, > > + * so set frac0 to get a 288 MHz ref_io0. > > + */ > > + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); > > + reg &= ~BM_CLKCTRL_FRAC0_IO0FRAC; > > + reg |= 30 << BP_CLKCTRL_FRAC0_IO0FRAC; > > + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); > > + > > return 0; > > } > > > > @@ -737,6 +748,13 @@ int __init mx28_clocks_init(void) > > { > > clk_misc_init(); > > > > + /* > > + * source ssp clock from ref_io0 than ref_xtal, > > + * as ref_xtal only provides 24 MHz as maximum. > > + */ > > + clk_set_parent(&ssp0_clk, &ref_io0_clk); > > + clk_set_parent(&ssp1_clk, &ref_io0_clk); > > + > > clk_enable(&cpu_clk); > > clk_enable(&hbus_clk); > > clk_enable(&xbus_clk); > > diff --git a/arch/arm/mach-mxs/devices-mx23.h b/arch/arm/mach-mxs/devices-mx23.h > > index 1256788..4419390 100644 > > --- a/arch/arm/mach-mxs/devices-mx23.h > > +++ b/arch/arm/mach-mxs/devices-mx23.h > > @@ -14,3 +14,7 @@ > > extern const struct amba_device mx23_duart_device __initconst; > > #define mx23_add_duart() \ > > mxs_add_duart(&mx23_duart_device) > > + > > +extern const struct mxs_mmc_data mx23_mmc_data[] __initconst; > > +#define mx23_add_mmc(id, pdata) \ > > + mxs_add_mmc(&mx23_mmc_data[id], pdata) > mxs_mmc please (not sure about mxs_mxs_mmc_data, but it would be > consistent). At least mx23_add_mxs_mmc and mxs_add_mxs_mmc. > > > diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h > > index 3b18304..540639d 100644 > > --- a/arch/arm/mach-mxs/devices-mx28.h > > +++ b/arch/arm/mach-mxs/devices-mx28.h > > @@ -32,3 +32,7 @@ extern const struct mxs_flexcan_data mx28_flexcan_data[] __initconst; > > mxs_add_flexcan(&mx28_flexcan_data[id], pdata) > > #define mx28_add_flexcan0(pdata) mx28_add_flexcan(0, pdata) > > #define mx28_add_flexcan1(pdata) mx28_add_flexcan(1, pdata) > > + > > +extern const struct mxs_mmc_data mx28_mmc_data[] __initconst; > > +#define mx28_add_mmc(id, pdata) \ > > + mxs_add_mmc(&mx28_mmc_data[id], pdata) > This conflicts with my series, but it's trivial enough to let Sascha > handle that. > > > diff --git a/arch/arm/mach-mxs/devices/Kconfig b/arch/arm/mach-mxs/devices/Kconfig > > index 6c65b67..49307f8 100644 > > --- a/arch/arm/mach-mxs/devices/Kconfig > > +++ b/arch/arm/mach-mxs/devices/Kconfig > > @@ -11,3 +11,6 @@ config MXS_HAVE_PLATFORM_FEC > > config MXS_HAVE_PLATFORM_FLEXCAN > > select HAVE_CAN_FLEXCAN if CAN > > bool > > + > > +config MXS_HAVE_PLATFORM_MMC > > + bool > ditto MXS_HAVE_PLATFORM_MXS_MMC > > > diff --git a/arch/arm/mach-mxs/devices/Makefile b/arch/arm/mach-mxs/devices/Makefile > > index ca7acc4..c0dacfd 100644 > > --- a/arch/arm/mach-mxs/devices/Makefile > > +++ b/arch/arm/mach-mxs/devices/Makefile > > @@ -3,3 +3,4 @@ obj-$(CONFIG_MXS_HAVE_PLATFORM_AUART) += platform-auart.o > > obj-y += platform-dma.o > > obj-$(CONFIG_MXS_HAVE_PLATFORM_FEC) += platform-fec.o > > obj-$(CONFIG_MXS_HAVE_PLATFORM_FLEXCAN) += platform-flexcan.o > > +obj-$(CONFIG_MXS_HAVE_PLATFORM_MMC) += platform-mmc.o > > diff --git a/arch/arm/mach-mxs/devices/platform-mmc.c b/arch/arm/mach-mxs/devices/platform-mmc.c > > new file mode 100644 > > index 0000000..868def1 > > --- /dev/null > > +++ b/arch/arm/mach-mxs/devices/platform-mmc.c > > @@ -0,0 +1,77 @@ > > +/* > > + * Copyright (C) 2010 Pengutronix > > + * Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > > + * > > + * Copyright 2011 Freescale Semiconductor, Inc. All Rights Reserved. > > + * > > + * This program is free software; you can redistribute it and/or modify it under > > + * the terms of the GNU General Public License version 2 as published by the > > + * Free Software Foundation. > > + */ > > + > > +#include <linux/compiler.h> > > +#include <linux/err.h> > > +#include <linux/init.h> > > + > > +#include <mach/mx23.h> > > +#include <mach/mx28.h> > > +#include <mach/devices-common.h> > > + > > +#define mxs_mmc_data_entry_single(soc, _id, hwid) \ > > + { \ > > + .id = _id, \ > > + .iobase = soc ## _SSP ## hwid ## _BASE_ADDR, \ > > + .dma = soc ## _DMA_SSP ## hwid, \ > > + .irq_err = soc ## _INT_SSP ## hwid ## _ERROR, \ > > + .irq_dma = soc ## _INT_SSP ## hwid ## _DMA, \ > > + } > > + > > +#define mxs_mmc_data_entry(soc, _id, hwid) \ > > + [_id] = mxs_mmc_data_entry_single(soc, _id, hwid) > > + > > + > > +#ifdef CONFIG_SOC_IMX23 > > +const struct mxs_mmc_data mx23_mmc_data[] __initconst = { > > +#define mx23_mmc_data_entry(_id, hwid) \ > > + mxs_mmc_data_entry(MX23, _id, hwid) > > + mx23_mmc_data_entry(0, 1), > > + mx23_mmc_data_entry(1, 2), > > +}; > hmm, maybe let mxs-mmc.1 use MX23_SSP1_BASE_ADDR? > BTW, Sascha pointed out that > > mxs_mmc_data_entry(MX23, 0, 1), > mxs_mmc_data_entry(MX23, 1, 2), > > is easier than > > #define mx23_mmc_data_entry(_id, hwid) \ > mxs_mmc_data_entry(MX23, _id, hwid) > mx23_mmc_data_entry(0, 1), > mx23_mmc_data_entry(1, 2), > This approach was used in mx23 auart device code which Sascha has merged. > though it has to repeat MX23. > > > +#endif > > + > > +#ifdef CONFIG_SOC_IMX28 > > +const struct mxs_mmc_data mx28_mmc_data[] __initconst = { > > +#define mx28_mmc_data_entry(_id) \ > > + mxs_mmc_data_entry(MX28, _id, _id) > > + mx28_mmc_data_entry(0), > > + mx28_mmc_data_entry(1), > > +}; > > +#endif > hmm, so i.MX28 starts at 0, i.MX23 at 1. Well, that's how it is. > -- Regards, Shawn ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device 2011-02-22 12:39 ` Shawn Guo @ 2011-02-22 18:33 ` Uwe Kleine-König 2011-03-16 10:31 ` [PATCH v4 " Uwe Kleine-König 0 siblings, 1 reply; 24+ messages in thread From: Uwe Kleine-König @ 2011-02-22 18:33 UTC (permalink / raw) To: linux-arm-kernel Hello Shawn, On Tue, Feb 22, 2011 at 08:39:41PM +0800, Shawn Guo wrote: > On Tue, Feb 22, 2011 at 09:31:13AM +0100, Uwe Kleine-K?nig wrote: > > On Mon, Feb 21, 2011 at 06:42:56PM +0800, Shawn Guo wrote: > > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > > --- > > > arch/arm/mach-mxs/clock-mx23.c | 16 +++++ > > > arch/arm/mach-mxs/clock-mx28.c | 18 +++++ > > > arch/arm/mach-mxs/devices-mx23.h | 4 + > > > arch/arm/mach-mxs/devices-mx28.h | 4 + > > > arch/arm/mach-mxs/devices/Kconfig | 3 + > > > arch/arm/mach-mxs/devices/Makefile | 1 + > > > arch/arm/mach-mxs/devices/platform-mmc.c | 77 +++++++++++++++++++++++ > > > arch/arm/mach-mxs/include/mach/devices-common.h | 13 ++++ > > > 8 files changed, 136 insertions(+), 0 deletions(-) > > > create mode 100644 arch/arm/mach-mxs/devices/platform-mmc.c > > > > > > diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c > > > index c19b69a..a1ed5f4 100644 > > > --- a/arch/arm/mach-mxs/clock-mx23.c > > > +++ b/arch/arm/mach-mxs/clock-mx23.c > > > @@ -445,6 +445,7 @@ static struct clk_lookup lookups[] = { > > > _REGISTER_CLOCK("rtc", NULL, rtc_clk) > > > _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) > > > _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) > > > + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp_clk) > > > _REGISTER_CLOCK(NULL, "usb", usb_clk) > > > _REGISTER_CLOCK(NULL, "audio", audio_clk) > > > _REGISTER_CLOCK(NULL, "pwm", pwm_clk) > > > @@ -515,6 +516,15 @@ static int clk_misc_init(void) > > > __raw_writel(BM_CLKCTRL_CPU_INTERRUPT_WAIT, > > > CLKCTRL_BASE_ADDR + HW_CLKCTRL_CPU_SET); > > > > > > + /* > > > + * 480 MHz seems too high to be ssp clock source directly, > > > + * so set frac to get a 288 MHz ref_io. > > > + */ > > > + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); > > > + reg &= ~BM_CLKCTRL_FRAC_IOFRAC; > > > + reg |= 30 << BP_CLKCTRL_FRAC_IOFRAC; > > > + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); > > > + > > > return 0; > > > } > > > > > > @@ -522,6 +532,12 @@ int __init mx23_clocks_init(void) > > > { > > > clk_misc_init(); > > > > > > + /* > > > + * source ssp clock from ref_io than ref_xtal, > > > + * as ref_xtal only provides 24 MHz as maximum. > > > + */ > > > + clk_set_parent(&ssp_clk, &ref_io_clk); > > > + > > > clk_enable(&cpu_clk); > > > clk_enable(&hbus_clk); > > > clk_enable(&xbus_clk); > > > diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c > > > index 9f4ee36..aeb7b2c 100644 > > > --- a/arch/arm/mach-mxs/clock-mx28.c > > > +++ b/arch/arm/mach-mxs/clock-mx28.c > > > @@ -619,6 +619,8 @@ static struct clk_lookup lookups[] = { > > > _REGISTER_CLOCK("pll2", NULL, pll2_clk) > > > _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) > > > _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) > > > + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp0_clk) > > > + _REGISTER_CLOCK("mxs-mmc.1", NULL, ssp1_clk) > > > _REGISTER_CLOCK("flexcan.0", NULL, can0_clk) > > > _REGISTER_CLOCK("flexcan.1", NULL, can1_clk) > > > _REGISTER_CLOCK(NULL, "usb0", usb0_clk) > > > @@ -730,6 +732,15 @@ static int clk_misc_init(void) > > > reg |= BM_CLKCTRL_ENET_CLK_OUT_EN; > > > __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_ENET); > > > > > > + /* > > > + * 480 MHz seems too high to be ssp clock source directly, > > > + * so set frac0 to get a 288 MHz ref_io0. > > > + */ > > > + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); > > > + reg &= ~BM_CLKCTRL_FRAC0_IO0FRAC; > > > + reg |= 30 << BP_CLKCTRL_FRAC0_IO0FRAC; > > > + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); > > > + > > > return 0; > > > } > > > > > > @@ -737,6 +748,13 @@ int __init mx28_clocks_init(void) > > > { > > > clk_misc_init(); > > > > > > + /* > > > + * source ssp clock from ref_io0 than ref_xtal, > > > + * as ref_xtal only provides 24 MHz as maximum. > > > + */ > > > + clk_set_parent(&ssp0_clk, &ref_io0_clk); > > > + clk_set_parent(&ssp1_clk, &ref_io0_clk); > > > + > > > clk_enable(&cpu_clk); > > > clk_enable(&hbus_clk); > > > clk_enable(&xbus_clk); > > > diff --git a/arch/arm/mach-mxs/devices-mx23.h b/arch/arm/mach-mxs/devices-mx23.h > > > index 1256788..4419390 100644 > > > --- a/arch/arm/mach-mxs/devices-mx23.h > > > +++ b/arch/arm/mach-mxs/devices-mx23.h > > > @@ -14,3 +14,7 @@ > > > extern const struct amba_device mx23_duart_device __initconst; > > > #define mx23_add_duart() \ > > > mxs_add_duart(&mx23_duart_device) > > > + > > > +extern const struct mxs_mmc_data mx23_mmc_data[] __initconst; > > > +#define mx23_add_mmc(id, pdata) \ > > > + mxs_add_mmc(&mx23_mmc_data[id], pdata) > > mxs_mmc please (not sure about mxs_mxs_mmc_data, but it would be > > consistent). At least mx23_add_mxs_mmc and mxs_add_mxs_mmc. > > > > > diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h > > > index 3b18304..540639d 100644 > > > --- a/arch/arm/mach-mxs/devices-mx28.h > > > +++ b/arch/arm/mach-mxs/devices-mx28.h > > > @@ -32,3 +32,7 @@ extern const struct mxs_flexcan_data mx28_flexcan_data[] __initconst; > > > mxs_add_flexcan(&mx28_flexcan_data[id], pdata) > > > #define mx28_add_flexcan0(pdata) mx28_add_flexcan(0, pdata) > > > #define mx28_add_flexcan1(pdata) mx28_add_flexcan(1, pdata) > > > + > > > +extern const struct mxs_mmc_data mx28_mmc_data[] __initconst; > > > +#define mx28_add_mmc(id, pdata) \ > > > + mxs_add_mmc(&mx28_mmc_data[id], pdata) > > This conflicts with my series, but it's trivial enough to let Sascha > > handle that. > > > > > diff --git a/arch/arm/mach-mxs/devices/Kconfig b/arch/arm/mach-mxs/devices/Kconfig > > > index 6c65b67..49307f8 100644 > > > --- a/arch/arm/mach-mxs/devices/Kconfig > > > +++ b/arch/arm/mach-mxs/devices/Kconfig > > > @@ -11,3 +11,6 @@ config MXS_HAVE_PLATFORM_FEC > > > config MXS_HAVE_PLATFORM_FLEXCAN > > > select HAVE_CAN_FLEXCAN if CAN > > > bool > > > + > > > +config MXS_HAVE_PLATFORM_MMC > > > + bool > > ditto MXS_HAVE_PLATFORM_MXS_MMC > > > > > diff --git a/arch/arm/mach-mxs/devices/Makefile b/arch/arm/mach-mxs/devices/Makefile > > > index ca7acc4..c0dacfd 100644 > > > --- a/arch/arm/mach-mxs/devices/Makefile > > > +++ b/arch/arm/mach-mxs/devices/Makefile > > > @@ -3,3 +3,4 @@ obj-$(CONFIG_MXS_HAVE_PLATFORM_AUART) += platform-auart.o > > > obj-y += platform-dma.o > > > obj-$(CONFIG_MXS_HAVE_PLATFORM_FEC) += platform-fec.o > > > obj-$(CONFIG_MXS_HAVE_PLATFORM_FLEXCAN) += platform-flexcan.o > > > +obj-$(CONFIG_MXS_HAVE_PLATFORM_MMC) += platform-mmc.o > > > diff --git a/arch/arm/mach-mxs/devices/platform-mmc.c b/arch/arm/mach-mxs/devices/platform-mmc.c > > > new file mode 100644 > > > index 0000000..868def1 > > > --- /dev/null > > > +++ b/arch/arm/mach-mxs/devices/platform-mmc.c > > > @@ -0,0 +1,77 @@ > > > +/* > > > + * Copyright (C) 2010 Pengutronix > > > + * Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> > > > + * > > > + * Copyright 2011 Freescale Semiconductor, Inc. All Rights Reserved. > > > + * > > > + * This program is free software; you can redistribute it and/or modify it under > > > + * the terms of the GNU General Public License version 2 as published by the > > > + * Free Software Foundation. > > > + */ > > > + > > > +#include <linux/compiler.h> > > > +#include <linux/err.h> > > > +#include <linux/init.h> > > > + > > > +#include <mach/mx23.h> > > > +#include <mach/mx28.h> > > > +#include <mach/devices-common.h> > > > + > > > +#define mxs_mmc_data_entry_single(soc, _id, hwid) \ > > > + { \ > > > + .id = _id, \ > > > + .iobase = soc ## _SSP ## hwid ## _BASE_ADDR, \ > > > + .dma = soc ## _DMA_SSP ## hwid, \ > > > + .irq_err = soc ## _INT_SSP ## hwid ## _ERROR, \ > > > + .irq_dma = soc ## _INT_SSP ## hwid ## _DMA, \ > > > + } > > > + > > > +#define mxs_mmc_data_entry(soc, _id, hwid) \ > > > + [_id] = mxs_mmc_data_entry_single(soc, _id, hwid) > > > + > > > + > > > +#ifdef CONFIG_SOC_IMX23 > > > +const struct mxs_mmc_data mx23_mmc_data[] __initconst = { > > > +#define mx23_mmc_data_entry(_id, hwid) \ > > > + mxs_mmc_data_entry(MX23, _id, hwid) > > > + mx23_mmc_data_entry(0, 1), > > > + mx23_mmc_data_entry(1, 2), > > > +}; > > hmm, maybe let mxs-mmc.1 use MX23_SSP1_BASE_ADDR? > > BTW, Sascha pointed out that > > > > mxs_mmc_data_entry(MX23, 0, 1), > > mxs_mmc_data_entry(MX23, 1, 2), > > > > is easier than > > > > #define mx23_mmc_data_entry(_id, hwid) \ > > mxs_mmc_data_entry(MX23, _id, hwid) > > mx23_mmc_data_entry(0, 1), > > mx23_mmc_data_entry(1, 2), > > > This approach was used in mx23 auart device code which Sascha has > merged. Yeah, I don't care that much. Do as you prefer. Sascha told me to rework the existing code in a free minute to the two-line variant. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v4 3/6] ARM: mxs: dynamically allocate mmc device 2011-02-22 18:33 ` Uwe Kleine-König @ 2011-03-16 10:31 ` Uwe Kleine-König 0 siblings, 0 replies; 24+ messages in thread From: Uwe Kleine-König @ 2011-03-16 10:31 UTC (permalink / raw) To: linux-arm-kernel From: Shawn Guo <shawn.guo@freescale.com> Signed-off-by: Shawn Guo <shawn.guo@freescale.com> [ukleinek: fix naming to include complete device name in functions] Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> --- Hello, this is not yet ready to be merged as it depends on <mach/mmc.h> which isn't upstream yet. Best regards Uwe arch/arm/mach-mxs/clock-mx23.c | 15 +++++ arch/arm/mach-mxs/clock-mx28.c | 18 ++++++ arch/arm/mach-mxs/devices-mx23.h | 4 + arch/arm/mach-mxs/devices-mx28.h | 4 + arch/arm/mach-mxs/devices/Kconfig | 3 + arch/arm/mach-mxs/devices/Makefile | 1 + arch/arm/mach-mxs/devices/platform-mxs-mmc.c | 73 +++++++++++++++++++++++ arch/arm/mach-mxs/include/mach/devices-common.h | 13 ++++ 8 files changed, 131 insertions(+), 0 deletions(-) create mode 100644 arch/arm/mach-mxs/devices/platform-mxs-mmc.c diff --git a/arch/arm/mach-mxs/clock-mx23.c b/arch/arm/mach-mxs/clock-mx23.c index d133c7f..c3577ea 100644 --- a/arch/arm/mach-mxs/clock-mx23.c +++ b/arch/arm/mach-mxs/clock-mx23.c @@ -521,6 +521,15 @@ static int clk_misc_init(void) __raw_writel(BM_CLKCTRL_CPU_INTERRUPT_WAIT, CLKCTRL_BASE_ADDR + HW_CLKCTRL_CPU_SET); + /* + * 480 MHz seems too high to be ssp clock source directly, + * so set frac to get a 288 MHz ref_io. + */ + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); + reg &= ~BM_CLKCTRL_FRAC_IOFRAC; + reg |= 30 << BP_CLKCTRL_FRAC_IOFRAC; + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC); + return 0; } @@ -528,6 +537,12 @@ int __init mx23_clocks_init(void) { clk_misc_init(); + /* + * source ssp clock from ref_io than ref_xtal, + * as ref_xtal only provides 24 MHz as maximum. + */ + clk_set_parent(&ssp_clk, &ref_io_clk); + clk_enable(&cpu_clk); clk_enable(&hbus_clk); clk_enable(&xbus_clk); diff --git a/arch/arm/mach-mxs/clock-mx28.c b/arch/arm/mach-mxs/clock-mx28.c index bf789f4..ed1ebfd 100644 --- a/arch/arm/mach-mxs/clock-mx28.c +++ b/arch/arm/mach-mxs/clock-mx28.c @@ -619,6 +619,8 @@ static struct clk_lookup lookups[] = { _REGISTER_CLOCK("pll2", NULL, pll2_clk) _REGISTER_CLOCK("mxs-dma-apbh", NULL, hbus_clk) _REGISTER_CLOCK("mxs-dma-apbx", NULL, xbus_clk) + _REGISTER_CLOCK("mxs-mmc.0", NULL, ssp0_clk) + _REGISTER_CLOCK("mxs-mmc.1", NULL, ssp1_clk) _REGISTER_CLOCK("flexcan.0", NULL, can0_clk) _REGISTER_CLOCK("flexcan.1", NULL, can1_clk) _REGISTER_CLOCK(NULL, "usb0", usb0_clk) @@ -738,6 +740,15 @@ static int clk_misc_init(void) reg |= BM_CLKCTRL_ENET_CLK_OUT_EN; __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_ENET); + /* + * 480 MHz seems too high to be ssp clock source directly, + * so set frac0 to get a 288 MHz ref_io0. + */ + reg = __raw_readl(CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); + reg &= ~BM_CLKCTRL_FRAC0_IO0FRAC; + reg |= 30 << BP_CLKCTRL_FRAC0_IO0FRAC; + __raw_writel(reg, CLKCTRL_BASE_ADDR + HW_CLKCTRL_FRAC0); + return 0; } @@ -745,6 +756,13 @@ int __init mx28_clocks_init(void) { clk_misc_init(); + /* + * source ssp clock from ref_io0 than ref_xtal, + * as ref_xtal only provides 24 MHz as maximum. + */ + clk_set_parent(&ssp0_clk, &ref_io0_clk); + clk_set_parent(&ssp1_clk, &ref_io0_clk); + clk_enable(&cpu_clk); clk_enable(&hbus_clk); clk_enable(&xbus_clk); diff --git a/arch/arm/mach-mxs/devices-mx23.h b/arch/arm/mach-mxs/devices-mx23.h index c7e14f4..c6f345f 100644 --- a/arch/arm/mach-mxs/devices-mx23.h +++ b/arch/arm/mach-mxs/devices-mx23.h @@ -21,6 +21,10 @@ extern const struct mxs_auart_data mx23_auart_data[] __initconst; #define mx23_add_auart0() mx23_add_auart(0) #define mx23_add_auart1() mx23_add_auart(1) +extern const struct mxs_mxs_mmc_data mx23_mxs_mmc_data[] __initconst; +#define mx23_add_mxs_mmc(id, pdata) \ + mxs_add_mxs_mmc(&mx23_mxs_mmc_data[id], pdata) + #define mx23_add_mxs_pwm(id) mxs_add_mxs_pwm(MX23_PWM_BASE_ADDR, id) struct platform_device *__init mx23_add_mxsfb( diff --git a/arch/arm/mach-mxs/devices-mx28.h b/arch/arm/mach-mxs/devices-mx28.h index 9d08555..c473edd 100644 --- a/arch/arm/mach-mxs/devices-mx28.h +++ b/arch/arm/mach-mxs/devices-mx28.h @@ -37,6 +37,10 @@ extern const struct mxs_flexcan_data mx28_flexcan_data[] __initconst; extern const struct mxs_i2c_data mx28_mxs_i2c_data[] __initconst; #define mx28_add_mxs_i2c(id) mxs_add_mxs_i2c(&mx28_mxs_i2c_data[id]) +extern const struct mxs_mxs_mmc_data mx28_mxs_mmc_data[] __initconst; +#define mx28_add_mxs_mmc(id, pdata) \ + mxs_add_mxs_mmc(&mx28_mxs_mmc_data[id], pdata) + #define mx28_add_mxs_pwm(id) mxs_add_mxs_pwm(MX28_PWM_BASE_ADDR, id) struct platform_device *__init mx28_add_mxsfb( diff --git a/arch/arm/mach-mxs/devices/Kconfig b/arch/arm/mach-mxs/devices/Kconfig index 1451ad0..acf9eea 100644 --- a/arch/arm/mach-mxs/devices/Kconfig +++ b/arch/arm/mach-mxs/devices/Kconfig @@ -15,6 +15,9 @@ config MXS_HAVE_PLATFORM_FLEXCAN config MXS_HAVE_PLATFORM_MXS_I2C bool +config MXS_HAVE_PLATFORM_MXS_MMC + bool + config MXS_HAVE_PLATFORM_MXS_PWM bool diff --git a/arch/arm/mach-mxs/devices/Makefile b/arch/arm/mach-mxs/devices/Makefile index 0d9bea3..324f282 100644 --- a/arch/arm/mach-mxs/devices/Makefile +++ b/arch/arm/mach-mxs/devices/Makefile @@ -4,5 +4,6 @@ obj-y += platform-dma.o obj-$(CONFIG_MXS_HAVE_PLATFORM_FEC) += platform-fec.o obj-$(CONFIG_MXS_HAVE_PLATFORM_FLEXCAN) += platform-flexcan.o obj-$(CONFIG_MXS_HAVE_PLATFORM_MXS_I2C) += platform-mxs-i2c.o +obj-$(CONFIG_MXS_HAVE_PLATFORM_MXS_MMC) += platform-mxs-mmc.o obj-$(CONFIG_MXS_HAVE_PLATFORM_MXS_PWM) += platform-mxs-pwm.o obj-$(CONFIG_MXS_HAVE_PLATFORM_MXSFB) += platform-mxsfb.o diff --git a/arch/arm/mach-mxs/devices/platform-mxs-mmc.c b/arch/arm/mach-mxs/devices/platform-mxs-mmc.c new file mode 100644 index 0000000..382dacb --- /dev/null +++ b/arch/arm/mach-mxs/devices/platform-mxs-mmc.c @@ -0,0 +1,73 @@ +/* + * Copyright (C) 2010 Pengutronix + * Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de> + * + * Copyright 2011 Freescale Semiconductor, Inc. All Rights Reserved. + * + * This program is free software; you can redistribute it and/or modify it under + * the terms of the GNU General Public License version 2 as published by the + * Free Software Foundation. + */ + +#include <linux/compiler.h> +#include <linux/err.h> +#include <linux/init.h> + +#include <mach/mx23.h> +#include <mach/mx28.h> +#include <mach/devices-common.h> + +#define mxs_mxs_mmc_data_entry_single(soc, _id, hwid) \ + { \ + .id = _id, \ + .iobase = soc ## _SSP ## hwid ## _BASE_ADDR, \ + .dma = soc ## _DMA_SSP ## hwid, \ + .irq_err = soc ## _INT_SSP ## hwid ## _ERROR, \ + .irq_dma = soc ## _INT_SSP ## hwid ## _DMA, \ + } + +#define mxs_mxs_mmc_data_entry(soc, _id, hwid) \ + [_id] = mxs_mxs_mmc_data_entry_single(soc, _id, hwid) + + +#ifdef CONFIG_SOC_IMX23 +const struct mxs_mxs_mmc_data mx23_mxs_mmc_data[] __initconst = { + mxs_mxs_mmc_data_entry(MX23, 0, 1), + mxs_mxs_mmc_data_entry(MX23, 1, 2), +}; +#endif + +#ifdef CONFIG_SOC_IMX28 +const struct mxs_mxs_mmc_data mx28_mxs_mmc_data[] __initconst = { + mxs_mxs_mmc_data_entry(MX28, 0, 0), + mxs_mxs_mmc_data_entry(MX28, 1, 1), +}; +#endif + +struct platform_device *__init mxs_add_mxs_mmc( + const struct mxs_mxs_mmc_data *data, + const struct mxs_mmc_platform_data *pdata) +{ + struct resource res[] = { + { + .start = data->iobase, + .end = data->iobase + SZ_8K - 1, + .flags = IORESOURCE_MEM, + }, { + .start = data->dma, + .end = data->dma, + .flags = IORESOURCE_DMA, + }, { + .start = data->irq_err, + .end = data->irq_err, + .flags = IORESOURCE_IRQ, + }, { + .start = data->irq_dma, + .end = data->irq_dma, + .flags = IORESOURCE_IRQ, + }, + }; + + return mxs_add_platform_device("mxs-mmc", data->id, + res, ARRAY_SIZE(res), pdata, sizeof(*pdata)); +} diff --git a/arch/arm/mach-mxs/include/mach/devices-common.h b/arch/arm/mach-mxs/include/mach/devices-common.h index 71f2448..c5137f1 100644 --- a/arch/arm/mach-mxs/include/mach/devices-common.h +++ b/arch/arm/mach-mxs/include/mach/devices-common.h @@ -73,6 +73,19 @@ struct mxs_i2c_data { }; struct platform_device * __init mxs_add_mxs_i2c(const struct mxs_i2c_data *data); +/* mmc */ +#include <mach/mmc.h> +struct mxs_mxs_mmc_data { + int id; + resource_size_t iobase; + resource_size_t dma; + resource_size_t irq_err; + resource_size_t irq_dma; +}; +struct platform_device *__init mxs_add_mxs_mmc( + const struct mxs_mxs_mmc_data *data, + const struct mxs_mmc_platform_data *pdata); + /* pwm */ struct platform_device *__init mxs_add_mxs_pwm( resource_size_t iobase, int id); -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v3 4/6] ARM: mxs: fix typo "GPO" in iomux-mx23.h 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo ` (2 preceding siblings ...) 2011-02-21 10:42 ` [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device Shawn Guo @ 2011-02-21 10:42 ` Shawn Guo 2011-02-25 20:55 ` Uwe Kleine-König 2011-02-21 10:42 ` [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device Shawn Guo ` (2 subsequent siblings) 6 siblings, 1 reply; 24+ messages in thread From: Shawn Guo @ 2011-02-21 10:42 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/include/mach/iomux-mx23.h | 190 +++++++++++++------------- 1 files changed, 95 insertions(+), 95 deletions(-) diff --git a/arch/arm/mach-mxs/include/mach/iomux-mx23.h b/arch/arm/mach-mxs/include/mach/iomux-mx23.h index 94e5dd8..b0190a4 100644 --- a/arch/arm/mach-mxs/include/mach/iomux-mx23.h +++ b/arch/arm/mach-mxs/include/mach/iomux-mx23.h @@ -254,102 +254,102 @@ #define MX23_PAD_ROTARYB__GPMI_CE3N MXS_IOMUX_PAD_NAKED(2, 8, PAD_MUXSEL_2) /* MUXSEL_GPIO */ -#define MX23_PAD_GPMI_D00__GPO_0_0 MXS_IOMUX_PAD_NAKED(0, 0, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D01__GPO_0_1 MXS_IOMUX_PAD_NAKED(0, 1, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D02__GPO_0_2 MXS_IOMUX_PAD_NAKED(0, 2, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D03__GPO_0_3 MXS_IOMUX_PAD_NAKED(0, 3, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D04__GPO_0_4 MXS_IOMUX_PAD_NAKED(0, 4, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D05__GPO_0_5 MXS_IOMUX_PAD_NAKED(0, 5, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D06__GPO_0_6 MXS_IOMUX_PAD_NAKED(0, 6, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D07__GPO_0_7 MXS_IOMUX_PAD_NAKED(0, 7, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D08__GPO_0_8 MXS_IOMUX_PAD_NAKED(0, 8, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D09__GPO_0_9 MXS_IOMUX_PAD_NAKED(0, 9, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D10__GPO_0_10 MXS_IOMUX_PAD_NAKED(0, 10, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D11__GPO_0_11 MXS_IOMUX_PAD_NAKED(0, 11, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D12__GPO_0_12 MXS_IOMUX_PAD_NAKED(0, 12, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D13__GPO_0_13 MXS_IOMUX_PAD_NAKED(0, 13, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D14__GPO_0_14 MXS_IOMUX_PAD_NAKED(0, 14, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_D15__GPO_0_15 MXS_IOMUX_PAD_NAKED(0, 15, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_CLE__GPO_0_16 MXS_IOMUX_PAD_NAKED(0, 16, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_ALE__GPO_0_17 MXS_IOMUX_PAD_NAKED(0, 17, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_CE2N__GPO_0_18 MXS_IOMUX_PAD_NAKED(0, 18, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_RDY0__GPO_0_19 MXS_IOMUX_PAD_NAKED(0, 19, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_RDY1__GPO_0_20 MXS_IOMUX_PAD_NAKED(0, 20, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_RDY2__GPO_0_21 MXS_IOMUX_PAD_NAKED(0, 21, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_RDY3__GPO_0_22 MXS_IOMUX_PAD_NAKED(0, 22, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_WPN__GPO_0_23 MXS_IOMUX_PAD_NAKED(0, 23, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_WRN__GPO_0_24 MXS_IOMUX_PAD_NAKED(0, 24, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_RDN__GPO_0_25 MXS_IOMUX_PAD_NAKED(0, 25, PAD_MUXSEL_GPIO) -#define MX23_PAD_AUART1_CTS__GPO_0_26 MXS_IOMUX_PAD_NAKED(0, 26, PAD_MUXSEL_GPIO) -#define MX23_PAD_AUART1_RTS__GPO_0_27 MXS_IOMUX_PAD_NAKED(0, 27, PAD_MUXSEL_GPIO) -#define MX23_PAD_AUART1_RX__GPO_0_28 MXS_IOMUX_PAD_NAKED(0, 28, PAD_MUXSEL_GPIO) -#define MX23_PAD_AUART1_TX__GPO_0_29 MXS_IOMUX_PAD_NAKED(0, 29, PAD_MUXSEL_GPIO) -#define MX23_PAD_I2C_SCL__GPO_0_30 MXS_IOMUX_PAD_NAKED(0, 30, PAD_MUXSEL_GPIO) -#define MX23_PAD_I2C_SDA__GPO_0_31 MXS_IOMUX_PAD_NAKED(0, 31, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D00__GPIO_0_0 MXS_IOMUX_PAD_NAKED(0, 0, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D01__GPIO_0_1 MXS_IOMUX_PAD_NAKED(0, 1, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D02__GPIO_0_2 MXS_IOMUX_PAD_NAKED(0, 2, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D03__GPIO_0_3 MXS_IOMUX_PAD_NAKED(0, 3, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D04__GPIO_0_4 MXS_IOMUX_PAD_NAKED(0, 4, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D05__GPIO_0_5 MXS_IOMUX_PAD_NAKED(0, 5, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D06__GPIO_0_6 MXS_IOMUX_PAD_NAKED(0, 6, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D07__GPIO_0_7 MXS_IOMUX_PAD_NAKED(0, 7, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D08__GPIO_0_8 MXS_IOMUX_PAD_NAKED(0, 8, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D09__GPIO_0_9 MXS_IOMUX_PAD_NAKED(0, 9, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D10__GPIO_0_10 MXS_IOMUX_PAD_NAKED(0, 10, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D11__GPIO_0_11 MXS_IOMUX_PAD_NAKED(0, 11, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D12__GPIO_0_12 MXS_IOMUX_PAD_NAKED(0, 12, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D13__GPIO_0_13 MXS_IOMUX_PAD_NAKED(0, 13, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D14__GPIO_0_14 MXS_IOMUX_PAD_NAKED(0, 14, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_D15__GPIO_0_15 MXS_IOMUX_PAD_NAKED(0, 15, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_CLE__GPIO_0_16 MXS_IOMUX_PAD_NAKED(0, 16, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_ALE__GPIO_0_17 MXS_IOMUX_PAD_NAKED(0, 17, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_CE2N__GPIO_0_18 MXS_IOMUX_PAD_NAKED(0, 18, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_RDY0__GPIO_0_19 MXS_IOMUX_PAD_NAKED(0, 19, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_RDY1__GPIO_0_20 MXS_IOMUX_PAD_NAKED(0, 20, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_RDY2__GPIO_0_21 MXS_IOMUX_PAD_NAKED(0, 21, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_RDY3__GPIO_0_22 MXS_IOMUX_PAD_NAKED(0, 22, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_WPN__GPIO_0_23 MXS_IOMUX_PAD_NAKED(0, 23, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_WRN__GPIO_0_24 MXS_IOMUX_PAD_NAKED(0, 24, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_RDN__GPIO_0_25 MXS_IOMUX_PAD_NAKED(0, 25, PAD_MUXSEL_GPIO) +#define MX23_PAD_AUART1_CTS__GPIO_0_26 MXS_IOMUX_PAD_NAKED(0, 26, PAD_MUXSEL_GPIO) +#define MX23_PAD_AUART1_RTS__GPIO_0_27 MXS_IOMUX_PAD_NAKED(0, 27, PAD_MUXSEL_GPIO) +#define MX23_PAD_AUART1_RX__GPIO_0_28 MXS_IOMUX_PAD_NAKED(0, 28, PAD_MUXSEL_GPIO) +#define MX23_PAD_AUART1_TX__GPIO_0_29 MXS_IOMUX_PAD_NAKED(0, 29, PAD_MUXSEL_GPIO) +#define MX23_PAD_I2C_SCL__GPIO_0_30 MXS_IOMUX_PAD_NAKED(0, 30, PAD_MUXSEL_GPIO) +#define MX23_PAD_I2C_SDA__GPIO_0_31 MXS_IOMUX_PAD_NAKED(0, 31, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D00__GPO_1_0 MXS_IOMUX_PAD_NAKED(1, 0, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D01__GPO_1_1 MXS_IOMUX_PAD_NAKED(1, 1, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D02__GPO_1_2 MXS_IOMUX_PAD_NAKED(1, 2, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D03__GPO_1_3 MXS_IOMUX_PAD_NAKED(1, 3, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D04__GPO_1_4 MXS_IOMUX_PAD_NAKED(1, 4, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D05__GPO_1_5 MXS_IOMUX_PAD_NAKED(1, 5, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D06__GPO_1_6 MXS_IOMUX_PAD_NAKED(1, 6, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D07__GPO_1_7 MXS_IOMUX_PAD_NAKED(1, 7, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D08__GPO_1_8 MXS_IOMUX_PAD_NAKED(1, 8, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D09__GPO_1_9 MXS_IOMUX_PAD_NAKED(1, 9, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D10__GPO_1_10 MXS_IOMUX_PAD_NAKED(1, 10, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D11__GPO_1_11 MXS_IOMUX_PAD_NAKED(1, 11, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D12__GPO_1_12 MXS_IOMUX_PAD_NAKED(1, 12, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D13__GPO_1_13 MXS_IOMUX_PAD_NAKED(1, 13, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D14__GPO_1_14 MXS_IOMUX_PAD_NAKED(1, 14, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D15__GPO_1_15 MXS_IOMUX_PAD_NAKED(1, 15, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D16__GPO_1_16 MXS_IOMUX_PAD_NAKED(1, 16, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_D17__GPO_1_17 MXS_IOMUX_PAD_NAKED(1, 17, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_RESET__GPO_1_18 MXS_IOMUX_PAD_NAKED(1, 18, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_RS__GPO_1_19 MXS_IOMUX_PAD_NAKED(1, 19, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_WR__GPO_1_20 MXS_IOMUX_PAD_NAKED(1, 20, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_CS__GPO_1_21 MXS_IOMUX_PAD_NAKED(1, 21, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_DOTCK__GPO_1_22 MXS_IOMUX_PAD_NAKED(1, 22, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_ENABLE__GPO_1_23 MXS_IOMUX_PAD_NAKED(1, 23, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_HSYNC__GPO_1_24 MXS_IOMUX_PAD_NAKED(1, 24, PAD_MUXSEL_GPIO) -#define MX23_PAD_LCD_VSYNC__GPO_1_25 MXS_IOMUX_PAD_NAKED(1, 25, PAD_MUXSEL_GPIO) -#define MX23_PAD_PWM0__GPO_1_26 MXS_IOMUX_PAD_NAKED(1, 26, PAD_MUXSEL_GPIO) -#define MX23_PAD_PWM1__GPO_1_27 MXS_IOMUX_PAD_NAKED(1, 27, PAD_MUXSEL_GPIO) -#define MX23_PAD_PWM2__GPO_1_28 MXS_IOMUX_PAD_NAKED(1, 28, PAD_MUXSEL_GPIO) -#define MX23_PAD_PWM3__GPO_1_29 MXS_IOMUX_PAD_NAKED(1, 29, PAD_MUXSEL_GPIO) -#define MX23_PAD_PWM4__GPO_1_30 MXS_IOMUX_PAD_NAKED(1, 30, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D00__GPIO_1_0 MXS_IOMUX_PAD_NAKED(1, 0, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D01__GPIO_1_1 MXS_IOMUX_PAD_NAKED(1, 1, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D02__GPIO_1_2 MXS_IOMUX_PAD_NAKED(1, 2, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D03__GPIO_1_3 MXS_IOMUX_PAD_NAKED(1, 3, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D04__GPIO_1_4 MXS_IOMUX_PAD_NAKED(1, 4, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D05__GPIO_1_5 MXS_IOMUX_PAD_NAKED(1, 5, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D06__GPIO_1_6 MXS_IOMUX_PAD_NAKED(1, 6, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D07__GPIO_1_7 MXS_IOMUX_PAD_NAKED(1, 7, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D08__GPIO_1_8 MXS_IOMUX_PAD_NAKED(1, 8, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D09__GPIO_1_9 MXS_IOMUX_PAD_NAKED(1, 9, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D10__GPIO_1_10 MXS_IOMUX_PAD_NAKED(1, 10, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D11__GPIO_1_11 MXS_IOMUX_PAD_NAKED(1, 11, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D12__GPIO_1_12 MXS_IOMUX_PAD_NAKED(1, 12, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D13__GPIO_1_13 MXS_IOMUX_PAD_NAKED(1, 13, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D14__GPIO_1_14 MXS_IOMUX_PAD_NAKED(1, 14, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D15__GPIO_1_15 MXS_IOMUX_PAD_NAKED(1, 15, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D16__GPIO_1_16 MXS_IOMUX_PAD_NAKED(1, 16, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_D17__GPIO_1_17 MXS_IOMUX_PAD_NAKED(1, 17, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_RESET__GPIO_1_18 MXS_IOMUX_PAD_NAKED(1, 18, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_RS__GPIO_1_19 MXS_IOMUX_PAD_NAKED(1, 19, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_WR__GPIO_1_20 MXS_IOMUX_PAD_NAKED(1, 20, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_CS__GPIO_1_21 MXS_IOMUX_PAD_NAKED(1, 21, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_DOTCK__GPIO_1_22 MXS_IOMUX_PAD_NAKED(1, 22, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_ENABLE__GPIO_1_23 MXS_IOMUX_PAD_NAKED(1, 23, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_HSYNC__GPIO_1_24 MXS_IOMUX_PAD_NAKED(1, 24, PAD_MUXSEL_GPIO) +#define MX23_PAD_LCD_VSYNC__GPIO_1_25 MXS_IOMUX_PAD_NAKED(1, 25, PAD_MUXSEL_GPIO) +#define MX23_PAD_PWM0__GPIO_1_26 MXS_IOMUX_PAD_NAKED(1, 26, PAD_MUXSEL_GPIO) +#define MX23_PAD_PWM1__GPIO_1_27 MXS_IOMUX_PAD_NAKED(1, 27, PAD_MUXSEL_GPIO) +#define MX23_PAD_PWM2__GPIO_1_28 MXS_IOMUX_PAD_NAKED(1, 28, PAD_MUXSEL_GPIO) +#define MX23_PAD_PWM3__GPIO_1_29 MXS_IOMUX_PAD_NAKED(1, 29, PAD_MUXSEL_GPIO) +#define MX23_PAD_PWM4__GPIO_1_30 MXS_IOMUX_PAD_NAKED(1, 30, PAD_MUXSEL_GPIO) -#define MX23_PAD_SSP1_CMD__GPO_2_0 MXS_IOMUX_PAD_NAKED(2, 0, PAD_MUXSEL_GPIO) -#define MX23_PAD_SSP1_DETECT__GPO_2_1 MXS_IOMUX_PAD_NAKED(2, 1, PAD_MUXSEL_GPIO) -#define MX23_PAD_SSP1_DATA0__GPO_2_2 MXS_IOMUX_PAD_NAKED(2, 2, PAD_MUXSEL_GPIO) -#define MX23_PAD_SSP1_DATA1__GPO_2_3 MXS_IOMUX_PAD_NAKED(2, 3, PAD_MUXSEL_GPIO) -#define MX23_PAD_SSP1_DATA2__GPO_2_4 MXS_IOMUX_PAD_NAKED(2, 4, PAD_MUXSEL_GPIO) -#define MX23_PAD_SSP1_DATA3__GPO_2_5 MXS_IOMUX_PAD_NAKED(2, 5, PAD_MUXSEL_GPIO) -#define MX23_PAD_SSP1_SCK__GPO_2_6 MXS_IOMUX_PAD_NAKED(2, 6, PAD_MUXSEL_GPIO) -#define MX23_PAD_ROTARYA__GPO_2_7 MXS_IOMUX_PAD_NAKED(2, 7, PAD_MUXSEL_GPIO) -#define MX23_PAD_ROTARYB__GPO_2_8 MXS_IOMUX_PAD_NAKED(2, 8, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A00__GPO_2_9 MXS_IOMUX_PAD_NAKED(2, 9, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A01__GPO_2_10 MXS_IOMUX_PAD_NAKED(2, 10, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A02__GPO_2_11 MXS_IOMUX_PAD_NAKED(2, 11, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A03__GPO_2_12 MXS_IOMUX_PAD_NAKED(2, 12, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A04__GPO_2_13 MXS_IOMUX_PAD_NAKED(2, 13, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A05__GPO_2_14 MXS_IOMUX_PAD_NAKED(2, 14, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A06__GPO_2_15 MXS_IOMUX_PAD_NAKED(2, 15, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A07__GPO_2_16 MXS_IOMUX_PAD_NAKED(2, 16, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A08__GPO_2_17 MXS_IOMUX_PAD_NAKED(2, 17, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A09__GPO_2_18 MXS_IOMUX_PAD_NAKED(2, 18, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A10__GPO_2_19 MXS_IOMUX_PAD_NAKED(2, 19, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A11__GPO_2_20 MXS_IOMUX_PAD_NAKED(2, 20, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_A12__GPO_2_21 MXS_IOMUX_PAD_NAKED(2, 21, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_BA0__GPO_2_22 MXS_IOMUX_PAD_NAKED(2, 22, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_BA1__GPO_2_23 MXS_IOMUX_PAD_NAKED(2, 23, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_CASN__GPO_2_24 MXS_IOMUX_PAD_NAKED(2, 24, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_CE0N__GPO_2_25 MXS_IOMUX_PAD_NAKED(2, 25, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_CE1N__GPO_2_26 MXS_IOMUX_PAD_NAKED(2, 26, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_CE1N__GPO_2_27 MXS_IOMUX_PAD_NAKED(2, 27, PAD_MUXSEL_GPIO) -#define MX23_PAD_GPMI_CE0N__GPO_2_28 MXS_IOMUX_PAD_NAKED(2, 28, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_CKE__GPO_2_29 MXS_IOMUX_PAD_NAKED(2, 29, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_RASN__GPO_2_30 MXS_IOMUX_PAD_NAKED(2, 30, PAD_MUXSEL_GPIO) -#define MX23_PAD_EMI_WEN__GPO_2_31 MXS_IOMUX_PAD_NAKED(2, 31, PAD_MUXSEL_GPIO) +#define MX23_PAD_SSP1_CMD__GPIO_2_0 MXS_IOMUX_PAD_NAKED(2, 0, PAD_MUXSEL_GPIO) +#define MX23_PAD_SSP1_DETECT__GPIO_2_1 MXS_IOMUX_PAD_NAKED(2, 1, PAD_MUXSEL_GPIO) +#define MX23_PAD_SSP1_DATA0__GPIO_2_2 MXS_IOMUX_PAD_NAKED(2, 2, PAD_MUXSEL_GPIO) +#define MX23_PAD_SSP1_DATA1__GPIO_2_3 MXS_IOMUX_PAD_NAKED(2, 3, PAD_MUXSEL_GPIO) +#define MX23_PAD_SSP1_DATA2__GPIO_2_4 MXS_IOMUX_PAD_NAKED(2, 4, PAD_MUXSEL_GPIO) +#define MX23_PAD_SSP1_DATA3__GPIO_2_5 MXS_IOMUX_PAD_NAKED(2, 5, PAD_MUXSEL_GPIO) +#define MX23_PAD_SSP1_SCK__GPIO_2_6 MXS_IOMUX_PAD_NAKED(2, 6, PAD_MUXSEL_GPIO) +#define MX23_PAD_ROTARYA__GPIO_2_7 MXS_IOMUX_PAD_NAKED(2, 7, PAD_MUXSEL_GPIO) +#define MX23_PAD_ROTARYB__GPIO_2_8 MXS_IOMUX_PAD_NAKED(2, 8, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A00__GPIO_2_9 MXS_IOMUX_PAD_NAKED(2, 9, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A01__GPIO_2_10 MXS_IOMUX_PAD_NAKED(2, 10, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A02__GPIO_2_11 MXS_IOMUX_PAD_NAKED(2, 11, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A03__GPIO_2_12 MXS_IOMUX_PAD_NAKED(2, 12, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A04__GPIO_2_13 MXS_IOMUX_PAD_NAKED(2, 13, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A05__GPIO_2_14 MXS_IOMUX_PAD_NAKED(2, 14, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A06__GPIO_2_15 MXS_IOMUX_PAD_NAKED(2, 15, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A07__GPIO_2_16 MXS_IOMUX_PAD_NAKED(2, 16, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A08__GPIO_2_17 MXS_IOMUX_PAD_NAKED(2, 17, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A09__GPIO_2_18 MXS_IOMUX_PAD_NAKED(2, 18, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A10__GPIO_2_19 MXS_IOMUX_PAD_NAKED(2, 19, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A11__GPIO_2_20 MXS_IOMUX_PAD_NAKED(2, 20, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_A12__GPIO_2_21 MXS_IOMUX_PAD_NAKED(2, 21, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_BA0__GPIO_2_22 MXS_IOMUX_PAD_NAKED(2, 22, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_BA1__GPIO_2_23 MXS_IOMUX_PAD_NAKED(2, 23, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_CASN__GPIO_2_24 MXS_IOMUX_PAD_NAKED(2, 24, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_CE0N__GPIO_2_25 MXS_IOMUX_PAD_NAKED(2, 25, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_CE1N__GPIO_2_26 MXS_IOMUX_PAD_NAKED(2, 26, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_CE1N__GPIO_2_27 MXS_IOMUX_PAD_NAKED(2, 27, PAD_MUXSEL_GPIO) +#define MX23_PAD_GPMI_CE0N__GPIO_2_28 MXS_IOMUX_PAD_NAKED(2, 28, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_CKE__GPIO_2_29 MXS_IOMUX_PAD_NAKED(2, 29, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_RASN__GPIO_2_30 MXS_IOMUX_PAD_NAKED(2, 30, PAD_MUXSEL_GPIO) +#define MX23_PAD_EMI_WEN__GPIO_2_31 MXS_IOMUX_PAD_NAKED(2, 31, PAD_MUXSEL_GPIO) #endif /* __MACH_IOMUX_MX23_H__ */ -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v3 4/6] ARM: mxs: fix typo "GPO" in iomux-mx23.h 2011-02-21 10:42 ` [PATCH v3 4/6] ARM: mxs: fix typo "GPO" in iomux-mx23.h Shawn Guo @ 2011-02-25 20:55 ` Uwe Kleine-König 0 siblings, 0 replies; 24+ messages in thread From: Uwe Kleine-König @ 2011-02-25 20:55 UTC (permalink / raw) To: linux-arm-kernel Hello, On Mon, Feb 21, 2011 at 06:42:57PM +0800, Shawn Guo wrote: > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> Assuming this is just s/GPO/GPIO/ ... Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo ` (3 preceding siblings ...) 2011-02-21 10:42 ` [PATCH v3 4/6] ARM: mxs: fix typo "GPO" in iomux-mx23.h Shawn Guo @ 2011-02-21 10:42 ` Shawn Guo 2011-02-21 17:42 ` Wolfram Sang ` (2 more replies) 2011-02-21 10:42 ` [PATCH v3 6/6] ARM: mxs/mx28evk: " Shawn Guo 2011-02-21 17:40 ` [PATCH v3] Add mmc device for i.MX23/28 Wolfram Sang 6 siblings, 3 replies; 24+ messages in thread From: Shawn Guo @ 2011-02-21 10:42 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/Kconfig | 1 + arch/arm/mach-mxs/mach-mx23evk.c | 47 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig index cd2fbdf..f47fae3 100644 --- a/arch/arm/mach-mxs/Kconfig +++ b/arch/arm/mach-mxs/Kconfig @@ -19,6 +19,7 @@ config MACH_MX23EVK bool "Support MX23EVK Platform" select SOC_IMX23 select MXS_HAVE_AMBA_DUART + select MXS_HAVE_PLATFORM_MMC default y help Include support for MX23EVK platform. This includes specific diff --git a/arch/arm/mach-mxs/mach-mx23evk.c b/arch/arm/mach-mxs/mach-mx23evk.c index aa06400..21519e3 100644 --- a/arch/arm/mach-mxs/mach-mx23evk.c +++ b/arch/arm/mach-mxs/mach-mx23evk.c @@ -26,17 +26,64 @@ #include "devices-mx23.h" +#define MX23EVK_MMC0_WRITE_PROTECT MXS_GPIO_NR(1, 30) +#define MX23EVK_MMC0_SLOT_POWER MXS_GPIO_NR(1, 29) + static const iomux_cfg_t mx23evk_pads[] __initconst = { /* duart */ MX23_PAD_PWM0__DUART_RX | MXS_PAD_4MA, MX23_PAD_PWM1__DUART_TX | MXS_PAD_4MA, + + /* mmc */ + MX23_PAD_SSP1_DATA0__SSP1_DATA0 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DATA1__SSP1_DATA1 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DATA2__SSP1_DATA2 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DATA3__SSP1_DATA3 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D08__SSP1_DATA4 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D09__SSP1_DATA5 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D10__SSP1_DATA6 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D11__SSP1_DATA7 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_CMD__SSP1_CMD | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DETECT__SSP1_DETECT | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + MX23_PAD_SSP1_SCK__SSP1_SCK | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* write protect */ + MX23_PAD_PWM4__GPIO_1_30 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* slot power enable */ + MX23_PAD_PWM3__GPIO_1_29 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), +}; + +static struct mxs_mmc_platform_data mx23_mmc_pdata __initdata = { + .wp_gpio = MX23EVK_MMC0_WRITE_PROTECT, + .flags = SLOTF_8_BIT_CAPABLE, }; static void __init mx23evk_init(void) { + int ret; + mxs_iomux_setup_multiple_pads(mx23evk_pads, ARRAY_SIZE(mx23evk_pads)); mx23_add_duart(); + + /* power on mmc slot by writing 0 to the gpio */ + ret = gpio_request_one(MX23EVK_MMC0_SLOT_POWER, GPIOF_DIR_OUT, + "mmc0-slot-power"); + if (ret) + pr_warn("failed to request gpio mmc0-slot-power: %d\n", ret); + mx23_add_mmc(0, &mx23_mmc_pdata); } static void __init mx23evk_timer_init(void) -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device 2011-02-21 10:42 ` [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device Shawn Guo @ 2011-02-21 17:42 ` Wolfram Sang 2011-02-22 8:33 ` Uwe Kleine-König 2011-02-22 8:49 ` [PATCH v4] " Shawn Guo 2 siblings, 0 replies; 24+ messages in thread From: Wolfram Sang @ 2011-02-21 17:42 UTC (permalink / raw) To: linux-arm-kernel > +static struct mxs_mmc_platform_data mx23_mmc_pdata __initdata = { Minor nit: Maybe mx23evk_mmc_pdata? (same for next patch) -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110221/dc4416a5/attachment.sig> ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device 2011-02-21 10:42 ` [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device Shawn Guo 2011-02-21 17:42 ` Wolfram Sang @ 2011-02-22 8:33 ` Uwe Kleine-König 2011-02-22 12:22 ` Shawn Guo 2011-02-22 8:49 ` [PATCH v4] " Shawn Guo 2 siblings, 1 reply; 24+ messages in thread From: Uwe Kleine-König @ 2011-02-22 8:33 UTC (permalink / raw) To: linux-arm-kernel On Mon, Feb 21, 2011 at 06:42:58PM +0800, Shawn Guo wrote: > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > --- > arch/arm/mach-mxs/Kconfig | 1 + > arch/arm/mach-mxs/mach-mx23evk.c | 47 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 48 insertions(+), 0 deletions(-) > > diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig > index cd2fbdf..f47fae3 100644 > --- a/arch/arm/mach-mxs/Kconfig > +++ b/arch/arm/mach-mxs/Kconfig > @@ -19,6 +19,7 @@ config MACH_MX23EVK > bool "Support MX23EVK Platform" > select SOC_IMX23 > select MXS_HAVE_AMBA_DUART > + select MXS_HAVE_PLATFORM_MMC > default y > help > Include support for MX23EVK platform. This includes specific > diff --git a/arch/arm/mach-mxs/mach-mx23evk.c b/arch/arm/mach-mxs/mach-mx23evk.c > index aa06400..21519e3 100644 > --- a/arch/arm/mach-mxs/mach-mx23evk.c > +++ b/arch/arm/mach-mxs/mach-mx23evk.c > @@ -26,17 +26,64 @@ > > #include "devices-mx23.h" > > +#define MX23EVK_MMC0_WRITE_PROTECT MXS_GPIO_NR(1, 30) > +#define MX23EVK_MMC0_SLOT_POWER MXS_GPIO_NR(1, 29) > + > static const iomux_cfg_t mx23evk_pads[] __initconst = { > /* duart */ > MX23_PAD_PWM0__DUART_RX | MXS_PAD_4MA, > MX23_PAD_PWM1__DUART_TX | MXS_PAD_4MA, > + > + /* mmc */ > + MX23_PAD_SSP1_DATA0__SSP1_DATA0 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_SSP1_DATA1__SSP1_DATA1 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_SSP1_DATA2__SSP1_DATA2 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_SSP1_DATA3__SSP1_DATA3 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_GPMI_D08__SSP1_DATA4 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_GPMI_D09__SSP1_DATA5 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_GPMI_D10__SSP1_DATA6 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_GPMI_D11__SSP1_DATA7 | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_SSP1_CMD__SSP1_CMD | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > + MX23_PAD_SSP1_DETECT__SSP1_DETECT | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > + MX23_PAD_SSP1_SCK__SSP1_SCK | > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > + /* write protect */ > + MX23_PAD_PWM4__GPIO_1_30 | > + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > + /* slot power enable */ > + MX23_PAD_PWM3__GPIO_1_29 | > + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > +}; > + > +static struct mxs_mmc_platform_data mx23_mmc_pdata __initdata = { > + .wp_gpio = MX23EVK_MMC0_WRITE_PROTECT, > + .flags = SLOTF_8_BIT_CAPABLE, can this be const? > }; > > static void __init mx23evk_init(void) > { > + int ret; > + > mxs_iomux_setup_multiple_pads(mx23evk_pads, ARRAY_SIZE(mx23evk_pads)); > > mx23_add_duart(); > + > + /* power on mmc slot by writing 0 to the gpio */ > + ret = gpio_request_one(MX23EVK_MMC0_SLOT_POWER, GPIOF_DIR_OUT, > + "mmc0-slot-power"); > + if (ret) > + pr_warn("failed to request gpio mmc0-slot-power: %d\n", ret); > + mx23_add_mmc(0, &mx23_mmc_pdata); > } > > static void __init mx23evk_timer_init(void) > -- > 1.7.1 -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ | ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device 2011-02-22 8:33 ` Uwe Kleine-König @ 2011-02-22 12:22 ` Shawn Guo 0 siblings, 0 replies; 24+ messages in thread From: Shawn Guo @ 2011-02-22 12:22 UTC (permalink / raw) To: linux-arm-kernel Hi Uwe, On Tue, Feb 22, 2011 at 09:33:44AM +0100, Uwe Kleine-K?nig wrote: > On Mon, Feb 21, 2011 at 06:42:58PM +0800, Shawn Guo wrote: > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > --- > > arch/arm/mach-mxs/Kconfig | 1 + > > arch/arm/mach-mxs/mach-mx23evk.c | 47 ++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 48 insertions(+), 0 deletions(-) > > > > diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig > > index cd2fbdf..f47fae3 100644 > > --- a/arch/arm/mach-mxs/Kconfig > > +++ b/arch/arm/mach-mxs/Kconfig > > @@ -19,6 +19,7 @@ config MACH_MX23EVK > > bool "Support MX23EVK Platform" > > select SOC_IMX23 > > select MXS_HAVE_AMBA_DUART > > + select MXS_HAVE_PLATFORM_MMC > > default y > > help > > Include support for MX23EVK platform. This includes specific > > diff --git a/arch/arm/mach-mxs/mach-mx23evk.c b/arch/arm/mach-mxs/mach-mx23evk.c > > index aa06400..21519e3 100644 > > --- a/arch/arm/mach-mxs/mach-mx23evk.c > > +++ b/arch/arm/mach-mxs/mach-mx23evk.c > > @@ -26,17 +26,64 @@ > > > > #include "devices-mx23.h" > > > > +#define MX23EVK_MMC0_WRITE_PROTECT MXS_GPIO_NR(1, 30) > > +#define MX23EVK_MMC0_SLOT_POWER MXS_GPIO_NR(1, 29) > > + > > static const iomux_cfg_t mx23evk_pads[] __initconst = { > > /* duart */ > > MX23_PAD_PWM0__DUART_RX | MXS_PAD_4MA, > > MX23_PAD_PWM1__DUART_TX | MXS_PAD_4MA, > > + > > + /* mmc */ > > + MX23_PAD_SSP1_DATA0__SSP1_DATA0 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_SSP1_DATA1__SSP1_DATA1 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_SSP1_DATA2__SSP1_DATA2 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_SSP1_DATA3__SSP1_DATA3 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_GPMI_D08__SSP1_DATA4 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_GPMI_D09__SSP1_DATA5 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_GPMI_D10__SSP1_DATA6 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_GPMI_D11__SSP1_DATA7 | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_SSP1_CMD__SSP1_CMD | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), > > + MX23_PAD_SSP1_DETECT__SSP1_DETECT | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > > + MX23_PAD_SSP1_SCK__SSP1_SCK | > > + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > > + /* write protect */ > > + MX23_PAD_PWM4__GPIO_1_30 | > > + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > > + /* slot power enable */ > > + MX23_PAD_PWM3__GPIO_1_29 | > > + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), > > +}; > > + > > +static struct mxs_mmc_platform_data mx23_mmc_pdata __initdata = { > > + .wp_gpio = MX23EVK_MMC0_WRITE_PROTECT, > > + .flags = SLOTF_8_BIT_CAPABLE, > can this be const? > Do you care this much to see a new version of the patch? -- Regards, Shawn ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v4] ARM: mxs/mx23evk: add mmc device 2011-02-21 10:42 ` [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device Shawn Guo 2011-02-21 17:42 ` Wolfram Sang 2011-02-22 8:33 ` Uwe Kleine-König @ 2011-02-22 8:49 ` Shawn Guo 2011-02-22 10:35 ` Wolfram Sang 2 siblings, 1 reply; 24+ messages in thread From: Shawn Guo @ 2011-02-22 8:49 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/Kconfig | 1 + arch/arm/mach-mxs/mach-mx23evk.c | 47 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 48 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig index cd2fbdf..f47fae3 100644 --- a/arch/arm/mach-mxs/Kconfig +++ b/arch/arm/mach-mxs/Kconfig @@ -19,6 +19,7 @@ config MACH_MX23EVK bool "Support MX23EVK Platform" select SOC_IMX23 select MXS_HAVE_AMBA_DUART + select MXS_HAVE_PLATFORM_MMC default y help Include support for MX23EVK platform. This includes specific diff --git a/arch/arm/mach-mxs/mach-mx23evk.c b/arch/arm/mach-mxs/mach-mx23evk.c index aa06400..d690fa0 100644 --- a/arch/arm/mach-mxs/mach-mx23evk.c +++ b/arch/arm/mach-mxs/mach-mx23evk.c @@ -26,17 +26,64 @@ #include "devices-mx23.h" +#define MX23EVK_MMC0_WRITE_PROTECT MXS_GPIO_NR(1, 30) +#define MX23EVK_MMC0_SLOT_POWER MXS_GPIO_NR(1, 29) + static const iomux_cfg_t mx23evk_pads[] __initconst = { /* duart */ MX23_PAD_PWM0__DUART_RX | MXS_PAD_4MA, MX23_PAD_PWM1__DUART_TX | MXS_PAD_4MA, + + /* mmc */ + MX23_PAD_SSP1_DATA0__SSP1_DATA0 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DATA1__SSP1_DATA1 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DATA2__SSP1_DATA2 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DATA3__SSP1_DATA3 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D08__SSP1_DATA4 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D09__SSP1_DATA5 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D10__SSP1_DATA6 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_GPMI_D11__SSP1_DATA7 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_CMD__SSP1_CMD | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX23_PAD_SSP1_DETECT__SSP1_DETECT | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + MX23_PAD_SSP1_SCK__SSP1_SCK | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* write protect */ + MX23_PAD_PWM4__GPIO_1_30 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* slot power enable */ + MX23_PAD_PWM3__GPIO_1_29 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), +}; + +static struct mxs_mmc_platform_data mx23evk_mmc_pdata __initdata = { + .wp_gpio = MX23EVK_MMC0_WRITE_PROTECT, + .flags = SLOTF_8_BIT_CAPABLE, }; static void __init mx23evk_init(void) { + int ret; + mxs_iomux_setup_multiple_pads(mx23evk_pads, ARRAY_SIZE(mx23evk_pads)); mx23_add_duart(); + + /* power on mmc slot by writing 0 to the gpio */ + ret = gpio_request_one(MX23EVK_MMC0_SLOT_POWER, GPIOF_DIR_OUT, + "mmc0-slot-power"); + if (ret) + pr_warn("failed to request gpio mmc0-slot-power: %d\n", ret); + mx23_add_mmc(0, &mx23evk_mmc_pdata); } static void __init mx23evk_timer_init(void) -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4] ARM: mxs/mx23evk: add mmc device 2011-02-22 8:49 ` [PATCH v4] " Shawn Guo @ 2011-02-22 10:35 ` Wolfram Sang 0 siblings, 0 replies; 24+ messages in thread From: Wolfram Sang @ 2011-02-22 10:35 UTC (permalink / raw) To: linux-arm-kernel On Tue, Feb 22, 2011 at 04:49:19PM +0800, Shawn Guo wrote: > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> Acked-by: Wolfram Sang <w.sang@pengutronix.de> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110222/a246e02b/attachment.sig> ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3 6/6] ARM: mxs/mx28evk: add mmc device 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo ` (4 preceding siblings ...) 2011-02-21 10:42 ` [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device Shawn Guo @ 2011-02-21 10:42 ` Shawn Guo 2011-02-22 8:50 ` [PATCH v4] " Shawn Guo 2011-02-21 17:40 ` [PATCH v3] Add mmc device for i.MX23/28 Wolfram Sang 6 siblings, 1 reply; 24+ messages in thread From: Shawn Guo @ 2011-02-21 10:42 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/Kconfig | 1 + arch/arm/mach-mxs/mach-mx28evk.c | 96 +++++++++++++++++++++++++++++++++++++- 2 files changed, 95 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig index f47fae3..287e0f8 100644 --- a/arch/arm/mach-mxs/Kconfig +++ b/arch/arm/mach-mxs/Kconfig @@ -30,6 +30,7 @@ config MACH_MX28EVK select SOC_IMX28 select MXS_HAVE_AMBA_DUART select MXS_HAVE_PLATFORM_FEC + select MXS_HAVE_PLATFORM_MMC select MXS_OCOTP default y help diff --git a/arch/arm/mach-mxs/mach-mx28evk.c b/arch/arm/mach-mxs/mach-mx28evk.c index e8db99f..75597c1 100644 --- a/arch/arm/mach-mxs/mach-mx28evk.c +++ b/arch/arm/mach-mxs/mach-mx28evk.c @@ -28,8 +28,13 @@ #include "devices-mx28.h" #include "gpio.h" -#define MX28EVK_FEC_PHY_POWER MXS_GPIO_NR(2, 15) -#define MX28EVK_FEC_PHY_RESET MXS_GPIO_NR(4, 13) +#define MX28EVK_FEC_PHY_POWER MXS_GPIO_NR(2, 15) +#define MX28EVK_FEC_PHY_RESET MXS_GPIO_NR(4, 13) + +#define MX28EVK_MMC0_WRITE_PROTECT MXS_GPIO_NR(2, 12) +#define MX28EVK_MMC1_WRITE_PROTECT MXS_GPIO_NR(0, 28) +#define MX28EVK_MMC0_SLOT_POWER MXS_GPIO_NR(3, 28) +#define MX28EVK_MMC1_SLOT_POWER MXS_GPIO_NR(3, 29) static const iomux_cfg_t mx28evk_pads[] __initconst = { /* duart */ @@ -76,6 +81,66 @@ static const iomux_cfg_t mx28evk_pads[] __initconst = { /* phy reset line */ MX28_PAD_ENET0_RX_CLK__GPIO_4_13 | (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + + /* mmc0 */ + MX28_PAD_SSP0_DATA0__SSP0_D0 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA1__SSP0_D1 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA2__SSP0_D2 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA3__SSP0_D3 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA4__SSP0_D4 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA5__SSP0_D5 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA6__SSP0_D6 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA7__SSP0_D7 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_CMD__SSP0_CMD | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + MX28_PAD_SSP0_SCK__SSP0_SCK | + (MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* write protect */ + MX28_PAD_SSP1_SCK__GPIO_2_12 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* slot power enable */ + MX28_PAD_PWM3__GPIO_3_28 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + + /* mmc1 */ + MX28_PAD_GPMI_D00__SSP1_D0 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D01__SSP1_D1 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D02__SSP1_D2 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D03__SSP1_D3 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D04__SSP1_D4 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D05__SSP1_D5 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D06__SSP1_D6 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D07__SSP1_D7 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_RDY1__SSP1_CMD | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_RDY0__SSP1_CARD_DETECT | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + MX28_PAD_GPMI_WRN__SSP1_SCK | + (MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* write protect */ + MX28_PAD_GPMI_RESETN__GPIO_0_28 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* slot power enable */ + MX28_PAD_PWM4__GPIO_3_29 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), }; /* fec */ @@ -159,12 +224,39 @@ error: return -ETIMEDOUT; } +static struct mxs_mmc_platform_data mx28_mmc_pdata[] __initdata = { + { + /* mmc0 */ + .wp_gpio = MX28EVK_MMC0_WRITE_PROTECT, + .flags = SLOTF_8_BIT_CAPABLE, + }, { + /* mmc1 */ + .wp_gpio = MX28EVK_MMC1_WRITE_PROTECT, + .flags = SLOTF_8_BIT_CAPABLE, + }, +}; + static void __init mx28evk_init(void) { + int ret; + mxs_iomux_setup_multiple_pads(mx28evk_pads, ARRAY_SIZE(mx28evk_pads)); mx28_add_duart(); + /* power on mmc slot by writing 0 to the gpio */ + ret = gpio_request_one(MX28EVK_MMC0_SLOT_POWER, GPIOF_DIR_OUT, + "mmc0-slot-power"); + if (ret) + pr_warn("failed to request gpio mmc0-slot-power: %d\n", ret); + mx28_add_mmc(0, &mx28_mmc_pdata[0]); + + ret = gpio_request_one(MX28EVK_MMC1_SLOT_POWER, GPIOF_DIR_OUT, + "mmc1-slot-power"); + if (ret) + pr_warn("failed to request gpio mmc1-slot-power: %d\n", ret); + mx28_add_mmc(1, &mx28_mmc_pdata[1]); + if (mx28evk_fec_get_mac()) pr_warn("%s: failed on fec mac setup\n", __func__); -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4] ARM: mxs/mx28evk: add mmc device 2011-02-21 10:42 ` [PATCH v3 6/6] ARM: mxs/mx28evk: " Shawn Guo @ 2011-02-22 8:50 ` Shawn Guo 2011-02-22 10:35 ` Wolfram Sang 2011-03-25 11:46 ` mx28 sdio problems (was: Re: [PATCH v4] ARM: mxs/mx28evk: add mmc device) Marc Kleine-Budde 0 siblings, 2 replies; 24+ messages in thread From: Shawn Guo @ 2011-02-22 8:50 UTC (permalink / raw) To: linux-arm-kernel Signed-off-by: Shawn Guo <shawn.guo@freescale.com> --- arch/arm/mach-mxs/Kconfig | 1 + arch/arm/mach-mxs/mach-mx28evk.c | 96 +++++++++++++++++++++++++++++++++++++- 2 files changed, 95 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mxs/Kconfig b/arch/arm/mach-mxs/Kconfig index f47fae3..287e0f8 100644 --- a/arch/arm/mach-mxs/Kconfig +++ b/arch/arm/mach-mxs/Kconfig @@ -30,6 +30,7 @@ config MACH_MX28EVK select SOC_IMX28 select MXS_HAVE_AMBA_DUART select MXS_HAVE_PLATFORM_FEC + select MXS_HAVE_PLATFORM_MMC select MXS_OCOTP default y help diff --git a/arch/arm/mach-mxs/mach-mx28evk.c b/arch/arm/mach-mxs/mach-mx28evk.c index e8db99f..d5fb2f3 100644 --- a/arch/arm/mach-mxs/mach-mx28evk.c +++ b/arch/arm/mach-mxs/mach-mx28evk.c @@ -28,8 +28,13 @@ #include "devices-mx28.h" #include "gpio.h" -#define MX28EVK_FEC_PHY_POWER MXS_GPIO_NR(2, 15) -#define MX28EVK_FEC_PHY_RESET MXS_GPIO_NR(4, 13) +#define MX28EVK_FEC_PHY_POWER MXS_GPIO_NR(2, 15) +#define MX28EVK_FEC_PHY_RESET MXS_GPIO_NR(4, 13) + +#define MX28EVK_MMC0_WRITE_PROTECT MXS_GPIO_NR(2, 12) +#define MX28EVK_MMC1_WRITE_PROTECT MXS_GPIO_NR(0, 28) +#define MX28EVK_MMC0_SLOT_POWER MXS_GPIO_NR(3, 28) +#define MX28EVK_MMC1_SLOT_POWER MXS_GPIO_NR(3, 29) static const iomux_cfg_t mx28evk_pads[] __initconst = { /* duart */ @@ -76,6 +81,66 @@ static const iomux_cfg_t mx28evk_pads[] __initconst = { /* phy reset line */ MX28_PAD_ENET0_RX_CLK__GPIO_4_13 | (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + + /* mmc0 */ + MX28_PAD_SSP0_DATA0__SSP0_D0 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA1__SSP0_D1 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA2__SSP0_D2 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA3__SSP0_D3 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA4__SSP0_D4 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA5__SSP0_D5 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA6__SSP0_D6 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DATA7__SSP0_D7 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_CMD__SSP0_CMD | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_SSP0_DETECT__SSP0_CARD_DETECT | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + MX28_PAD_SSP0_SCK__SSP0_SCK | + (MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* write protect */ + MX28_PAD_SSP1_SCK__GPIO_2_12 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* slot power enable */ + MX28_PAD_PWM3__GPIO_3_28 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + + /* mmc1 */ + MX28_PAD_GPMI_D00__SSP1_D0 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D01__SSP1_D1 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D02__SSP1_D2 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D03__SSP1_D3 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D04__SSP1_D4 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D05__SSP1_D5 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D06__SSP1_D6 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_D07__SSP1_D7 | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_RDY1__SSP1_CMD | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_PULLUP), + MX28_PAD_GPMI_RDY0__SSP1_CARD_DETECT | + (MXS_PAD_8MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + MX28_PAD_GPMI_WRN__SSP1_SCK | + (MXS_PAD_12MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* write protect */ + MX28_PAD_GPMI_RESETN__GPIO_0_28 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), + /* slot power enable */ + MX28_PAD_PWM4__GPIO_3_29 | + (MXS_PAD_4MA | MXS_PAD_3V3 | MXS_PAD_NOPULL), }; /* fec */ @@ -159,12 +224,39 @@ error: return -ETIMEDOUT; } +static struct mxs_mmc_platform_data mx28evk_mmc_pdata[] __initdata = { + { + /* mmc0 */ + .wp_gpio = MX28EVK_MMC0_WRITE_PROTECT, + .flags = SLOTF_8_BIT_CAPABLE, + }, { + /* mmc1 */ + .wp_gpio = MX28EVK_MMC1_WRITE_PROTECT, + .flags = SLOTF_8_BIT_CAPABLE, + }, +}; + static void __init mx28evk_init(void) { + int ret; + mxs_iomux_setup_multiple_pads(mx28evk_pads, ARRAY_SIZE(mx28evk_pads)); mx28_add_duart(); + /* power on mmc slot by writing 0 to the gpio */ + ret = gpio_request_one(MX28EVK_MMC0_SLOT_POWER, GPIOF_DIR_OUT, + "mmc0-slot-power"); + if (ret) + pr_warn("failed to request gpio mmc0-slot-power: %d\n", ret); + mx28_add_mmc(0, &mx28evk_mmc_pdata[0]); + + ret = gpio_request_one(MX28EVK_MMC1_SLOT_POWER, GPIOF_DIR_OUT, + "mmc1-slot-power"); + if (ret) + pr_warn("failed to request gpio mmc1-slot-power: %d\n", ret); + mx28_add_mmc(1, &mx28evk_mmc_pdata[1]); + if (mx28evk_fec_get_mac()) pr_warn("%s: failed on fec mac setup\n", __func__); -- 1.7.1 ^ permalink raw reply related [flat|nested] 24+ messages in thread
* [PATCH v4] ARM: mxs/mx28evk: add mmc device 2011-02-22 8:50 ` [PATCH v4] " Shawn Guo @ 2011-02-22 10:35 ` Wolfram Sang 2011-03-25 11:46 ` mx28 sdio problems (was: Re: [PATCH v4] ARM: mxs/mx28evk: add mmc device) Marc Kleine-Budde 1 sibling, 0 replies; 24+ messages in thread From: Wolfram Sang @ 2011-02-22 10:35 UTC (permalink / raw) To: linux-arm-kernel On Tue, Feb 22, 2011 at 04:50:24PM +0800, Shawn Guo wrote: > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> Acked-by: Wolfram Sang <w.sang@pengutronix.de> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110222/f5d6699c/attachment.sig> ^ permalink raw reply [flat|nested] 24+ messages in thread
* mx28 sdio problems (was: Re: [PATCH v4] ARM: mxs/mx28evk: add mmc device) 2011-02-22 8:50 ` [PATCH v4] " Shawn Guo 2011-02-22 10:35 ` Wolfram Sang @ 2011-03-25 11:46 ` Marc Kleine-Budde 2011-03-26 14:13 ` Shawn Guo 1 sibling, 1 reply; 24+ messages in thread From: Marc Kleine-Budde @ 2011-03-25 11:46 UTC (permalink / raw) To: linux-arm-kernel On 02/22/2011 09:50 AM, Shawn Guo wrote: > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> I ported these patches to current mainline (the to be released 2.6.39-rc1). mmc works with sd and sdhc cards without problems on my mx28evk. However sdio doesn't work. When I plug a sdio wlan card the kernel gives me the following error messages in a loop: [ 1002.760000] mmc1: new SDIO card at address 0001 [ 1003.760000] mmc1: card 0001 removed [ 1003.810000] mmc1: new SDIO card at address 0001 [ 1004.810000] mmc1: card 0001 removed Any hints how to debug? cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 262 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110325/5ebbd956/attachment.sig> ^ permalink raw reply [flat|nested] 24+ messages in thread
* mx28 sdio problems (was: Re: [PATCH v4] ARM: mxs/mx28evk: add mmc device) 2011-03-25 11:46 ` mx28 sdio problems (was: Re: [PATCH v4] ARM: mxs/mx28evk: add mmc device) Marc Kleine-Budde @ 2011-03-26 14:13 ` Shawn Guo 2011-03-29 10:05 ` mx28 sdio problems Marc Kleine-Budde 0 siblings, 1 reply; 24+ messages in thread From: Shawn Guo @ 2011-03-26 14:13 UTC (permalink / raw) To: linux-arm-kernel On Fri, Mar 25, 2011 at 12:46:37PM +0100, Marc Kleine-Budde wrote: > On 02/22/2011 09:50 AM, Shawn Guo wrote: > > Signed-off-by: Shawn Guo <shawn.guo@freescale.com> > > I ported these patches to current mainline (the to be released > 2.6.39-rc1). mmc works with sd and sdhc cards without problems on my > mx28evk. > > However sdio doesn't work. When I plug a sdio wlan card the kernel gives > me the following error messages in a loop: > > [ 1002.760000] mmc1: new SDIO card at address 0001 > [ 1003.760000] mmc1: card 0001 removed > [ 1003.810000] mmc1: new SDIO card at address 0001 > [ 1004.810000] mmc1: card 0001 removed > > Any hints how to debug? > The only problem I had when testing an Atheros sdio wifi cards was the shortage of power supply on slot1 (internal regulator powered). The slot2 on mx28evk just works out of box with this sdio card. You also rework the board to get the slot1 be powered by external regulator just like slot2. -- Regards, Shawn ^ permalink raw reply [flat|nested] 24+ messages in thread
* mx28 sdio problems 2011-03-26 14:13 ` Shawn Guo @ 2011-03-29 10:05 ` Marc Kleine-Budde 0 siblings, 0 replies; 24+ messages in thread From: Marc Kleine-Budde @ 2011-03-29 10:05 UTC (permalink / raw) To: linux-arm-kernel On 03/26/2011 03:13 PM, Shawn Guo wrote: > On Fri, Mar 25, 2011 at 12:46:37PM +0100, Marc Kleine-Budde wrote: >> On 02/22/2011 09:50 AM, Shawn Guo wrote: >>> Signed-off-by: Shawn Guo <shawn.guo@freescale.com> >> >> I ported these patches to current mainline (the to be released >> 2.6.39-rc1). mmc works with sd and sdhc cards without problems on my >> mx28evk. >> >> However sdio doesn't work. When I plug a sdio wlan card the kernel gives >> me the following error messages in a loop: >> >> [ 1002.760000] mmc1: new SDIO card at address 0001 >> [ 1003.760000] mmc1: card 0001 removed >> [ 1003.810000] mmc1: new SDIO card at address 0001 >> [ 1004.810000] mmc1: card 0001 removed >> >> Any hints how to debug? >> > The only problem I had when testing an Atheros sdio wifi cards was > the shortage of power supply on slot1 (internal regulator powered). > The slot2 on mx28evk just works out of box with this sdio card. You > also rework the board to get the slot1 be powered by external > regulator just like slot2. I just received an atheros sd25, the card gets recognized. No driver to test more. However with the old card the problem remains. On my sheeva plug I see the same problems with the old card. cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 262 bytes Desc: OpenPGP digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110329/a2ea84e9/attachment.sig> ^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v3] Add mmc device for i.MX23/28 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo ` (5 preceding siblings ...) 2011-02-21 10:42 ` [PATCH v3 6/6] ARM: mxs/mx28evk: " Shawn Guo @ 2011-02-21 17:40 ` Wolfram Sang 6 siblings, 0 replies; 24+ messages in thread From: Wolfram Sang @ 2011-02-21 17:40 UTC (permalink / raw) To: linux-arm-kernel On Mon, Feb 21, 2011 at 06:42:53PM +0800, Shawn Guo wrote: > This patch set is to add mmc device for i.MX23 and i.MX28. Patches 1-4 Tested-by: Wolfram Sang <w.sang@pengutronix.de> -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 198 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110221/6ae2de27/attachment.sig> ^ permalink raw reply [flat|nested] 24+ messages in thread
end of thread, other threads:[~2011-03-29 10:05 UTC | newest] Thread overview: 24+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-02-21 10:42 [PATCH v3] Add mmc device for i.MX23/28 Shawn Guo 2011-02-21 10:42 ` [PATCH v3 1/6] ARM: mxs/clock: fix base address missing in name##_set_parent Shawn Guo 2011-02-21 10:42 ` [PATCH v3 2/6] ARM: mxs: make ssp error irq definition consistent Shawn Guo 2011-02-22 8:20 ` Uwe Kleine-König 2011-02-21 10:42 ` [PATCH v3 3/6] ARM: mxs: dynamically allocate mmc device Shawn Guo 2011-02-22 8:31 ` Uwe Kleine-König 2011-02-22 12:39 ` Shawn Guo 2011-02-22 18:33 ` Uwe Kleine-König 2011-03-16 10:31 ` [PATCH v4 " Uwe Kleine-König 2011-02-21 10:42 ` [PATCH v3 4/6] ARM: mxs: fix typo "GPO" in iomux-mx23.h Shawn Guo 2011-02-25 20:55 ` Uwe Kleine-König 2011-02-21 10:42 ` [PATCH v3 5/6] ARM: mxs/mx23evk: add mmc device Shawn Guo 2011-02-21 17:42 ` Wolfram Sang 2011-02-22 8:33 ` Uwe Kleine-König 2011-02-22 12:22 ` Shawn Guo 2011-02-22 8:49 ` [PATCH v4] " Shawn Guo 2011-02-22 10:35 ` Wolfram Sang 2011-02-21 10:42 ` [PATCH v3 6/6] ARM: mxs/mx28evk: " Shawn Guo 2011-02-22 8:50 ` [PATCH v4] " Shawn Guo 2011-02-22 10:35 ` Wolfram Sang 2011-03-25 11:46 ` mx28 sdio problems (was: Re: [PATCH v4] ARM: mxs/mx28evk: add mmc device) Marc Kleine-Budde 2011-03-26 14:13 ` Shawn Guo 2011-03-29 10:05 ` mx28 sdio problems Marc Kleine-Budde 2011-02-21 17:40 ` [PATCH v3] Add mmc device for i.MX23/28 Wolfram Sang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).