linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] OMAP: l3: fixes and cleanup
Date: Wed, 30 Mar 2011 12:15:26 +0530	[thread overview]
Message-ID: <4D92D186.1070302@ti.com> (raw)
In-Reply-To: <1301419219-30547-1-git-send-email-omar.ramirez@ti.com>

Omar,

On 3/29/2011 10:50 PM, Omar Ramirez Luna wrote:
> Based on the comments received for the first patch:
> OMAP3: l3: fix for "irq 10: nobody cared" message[1],
> and quick skimming through the code.
>
> Although there are still parenthesis that are not needed
> because of operator precedence, they were left for clarity.
>
> E.g.:
> (error>>  32)&  0xffff;
>
> clear = (L3_AGENT_STATUS_CLEAR_IA<<  int_type) |
>          L3_AGENT_STATUS_CLEAR_TA;
>
> ---
> [1] https://patchwork.kernel.org/patch/665141/
>
> Omar Ramirez Luna (5):
>    OMAP3: l3: fix for "irq 10: nobody cared" message
>    OMAP3: l3: fix omap3_l3_probe error path
>    OMAP3: l3: minor cleanup for error message, parenthesis and extra
>      lines
>    OMAP4: l3: fix omap4_l3_probe error path
>    OMAP4: l3: minor cleanup for parenthesis and extra spaces
>
Thanks for the cleanup. I have reviewed the series and it looks
good to me.
I would suggest to fold similar changes like,
- PATCH 2/5 and PATCH 4/5 into one patch
- PATCH 3/5 and PATCH 5/5 into one patch

With this update you can add my ack for this series

>   arch/arm/mach-omap2/omap_l3_noc.c |   51 ++++++++++++++++--------------------
>   arch/arm/mach-omap2/omap_l3_smx.c |   46 ++++++++++++---------------------
>   2 files changed, 40 insertions(+), 57 deletions(-)
>

  parent reply	other threads:[~2011-03-30  6:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 17:20 [PATCH 0/5] OMAP: l3: fixes and cleanup Omar Ramirez Luna
2011-03-29 17:20 ` [PATCH 1/5] OMAP3: l3: fix for "irq 10: nobody cared" message Omar Ramirez Luna
2011-03-30  6:27   ` Santosh Shilimkar
2011-03-29 17:20 ` [PATCH 2/5] OMAP3: l3: fix omap3_l3_probe error path Omar Ramirez Luna
2011-03-30  6:36   ` Santosh Shilimkar
2011-03-29 17:20 ` [PATCH 3/5] OMAP3: l3: minor cleanup for error message, parenthesis and extra lines Omar Ramirez Luna
2011-03-29 17:20 ` [PATCH 4/5] OMAP4: l3: fix omap4_l3_probe error path Omar Ramirez Luna
2011-03-29 17:20 ` [PATCH 5/5] OMAP4: l3: minor cleanup for parenthesis and extra spaces Omar Ramirez Luna
2011-03-30  6:45 ` Santosh Shilimkar [this message]
2011-03-31 22:05   ` [PATCH 0/5] OMAP: l3: fixes and cleanup Ramirez Luna, Omar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D92D186.1070302@ti.com \
    --to=santosh.shilimkar@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).