From mboxrd@z Thu Jan  1 00:00:00 1970
From: ameya.palande@nokia.com (Ameya Palande)
Date: Thu, 31 Mar 2011 18:30:32 +0300
Subject: [PATCHv2] omap: rx51: Platform support for lp5523 led chip
In-Reply-To: <20110331142635.GF5465@legolas.emea.dhcp.ti.com>
References: <alpine.DEB.1.10.1103311524420.2634@esdhcp041196.research.nokia.com>
	<1301578692-29286-1-git-send-email-ameya.palande@nokia.com>
	<20110331142635.GF5465@legolas.emea.dhcp.ti.com>
Message-ID: <4D949E18.6090704@nokia.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Felipe,

On 03/31/2011 05:26 PM, ext Felipe Balbi wrote:
> Hi,
>
> On Thu, Mar 31, 2011 at 04:38:12PM +0300, Ameya Palande wrote:
>> +static int rx51_lp5523_setup(void)
>> +{
>> +	int err;
>> +
>> +	err = gpio_request_one(RX51_LP5523_CHIP_EN_GPIO, GPIOF_DIR_OUT,
>> +			"lp5523_enable");
>> +	if (err<  0) {
>> +		pr_err("Unable to get lp5523_enable GPIO\n");
>> +		return err;
>> +	}
>> +
>> +	return err;
>
> isn't enough to return gpio_request_one(RX51_LP5523_CHIP_EN_GPIO,
> GPIOF_DIR_OUT, "lp5523_enable"); ??

But then we won't know the failure reason for lp5523_probe()
I would prefer printing an error!

Cheers,
Ameya.