From: ameya.palande@nokia.com (Ameya Palande)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] omap: rx51: Platform support for lp5523 led chip
Date: Fri, 1 Apr 2011 12:58:16 +0300 [thread overview]
Message-ID: <4D95A1B8.2090007@nokia.com> (raw)
In-Reply-To: <20110331154421.GN5465@legolas.emea.dhcp.ti.com>
Hi Felipe,
On 03/31/2011 06:44 PM, ext Felipe Balbi wrote:
> On Thu, Mar 31, 2011 at 06:30:32PM +0300, Ameya Palande wrote:
>> Hi Felipe,
>>
>> On 03/31/2011 05:26 PM, ext Felipe Balbi wrote:
>>> Hi,
>>>
>>> On Thu, Mar 31, 2011 at 04:38:12PM +0300, Ameya Palande wrote:
>>>> +static int rx51_lp5523_setup(void)
>>>> +{
>>>> + int err;
>>>> +
>>>> + err = gpio_request_one(RX51_LP5523_CHIP_EN_GPIO, GPIOF_DIR_OUT,
>>>> + "lp5523_enable");
>>>> + if (err< 0) {
>>>> + pr_err("Unable to get lp5523_enable GPIO\n");
>>>> + return err;
>>>> + }
>>>> +
>>>> + return err;
>>>
>>> isn't enough to return gpio_request_one(RX51_LP5523_CHIP_EN_GPIO,
>>> GPIOF_DIR_OUT, "lp5523_enable"); ??
>>
>> But then we won't know the failure reason for lp5523_probe()
>> I would prefer printing an error!
>
> see that both gpio_request() and gpio_direction_output() have debugging
> prints for error cases ;-)
Agreed :) Thanks for the review!
Will send v3.
Cheers,
Ameya.
next prev parent reply other threads:[~2011-04-01 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-31 12:17 [PATCH] omap: rx51: Platform support for lp5523 led chip Ameya Palande
2011-03-31 12:27 ` Felipe Balbi
2011-03-31 12:27 ` Aaro Koskinen
2011-03-31 13:38 ` [PATCHv2] " Ameya Palande
2011-03-31 13:50 ` Jarkko Nikula
2011-03-31 14:26 ` Felipe Balbi
2011-03-31 15:30 ` Ameya Palande
2011-03-31 15:44 ` Felipe Balbi
2011-04-01 9:58 ` Ameya Palande [this message]
2011-04-01 10:16 ` [PATCHv3] " Ameya Palande
2011-04-05 12:03 ` Felipe Balbi
2011-05-31 12:55 ` Tony Lindgren
2011-04-05 12:00 ` [PATCHv2] " Ameya Palande
2011-04-05 12:03 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D95A1B8.2090007@nokia.com \
--to=ameya.palande@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).