linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dbaryshkov@gmail.com (Dmitry Eremin-Solenikov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] mioa701: drop udc_is_connected
Date: Fri, 01 Apr 2011 18:50:48 +0400	[thread overview]
Message-ID: <4D95E648.5000906@gmail.com> (raw)
In-Reply-To: <4D95DCD9.80007@ru.mvista.com>

On 01.04.2011 18:10, Sergei Shtylyov wrote:
> Dmitry Eremin-Solenikov wrote:
>
>> Mioa701 is a pxa270 machine and pxa27x_udc driver doesn't pay any
>> attention
>> to udc_is_connected, so drop it.
>
> You seem to be moving is_usb_connected(), not dropping it...

It may seem to be a bad wording. I'm dropping 
pxa2xx_udc_mach_info.udc_is_connected() callback assignment. The 
is_usb_connected() function is still used by pda-power driver.

>
>> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> ---
>> arch/arm/mach-pxa/mioa701.c | 11 +++++------
>> 1 files changed, 5 insertions(+), 6 deletions(-)
>>
>> diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c
>> index dd13bb6..f69a3c7 100644
>> --- a/arch/arm/mach-pxa/mioa701.c
>> +++ b/arch/arm/mach-pxa/mioa701.c
>> @@ -402,13 +402,7 @@ static void gsm_exit(void)
>> /*
>> * USB UDC
>> */
>> -static int is_usb_connected(void)
>> -{
>> - return !gpio_get_value(GPIO13_nUSB_DETECT);
>> -}
>> -
>> static struct pxa2xx_udc_mach_info mioa701_udc_info = {
>> - .udc_is_connected = is_usb_connected,
>> .gpio_pullup = GPIO22_USB_ENABLE,
>> };
>>
>> @@ -596,6 +590,11 @@ static int is_ac_connected(void)
>> return gpio_get_value(GPIO96_AC_DETECT);
>> }
>>
>> +static int is_usb_connected(void)
>> +{
>> + return !gpio_get_value(GPIO13_nUSB_DETECT);
>> +}
>> +
>> static void mioa701_set_charge(int flags)
>> {
>> gpio_set_value(GPIO9_CHARGE_EN, (flags == PDA_POWER_CHARGE_USB));
>
> WBR, Sergei


-- 
With best wishes
Dmitry

  reply	other threads:[~2011-04-01 14:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-01 13:56 [PATCH 1/7] balloon3: drop udc_is_connected Dmitry Eremin-Solenikov
2011-04-01 13:56 ` [PATCH 2/7] mioa701: " Dmitry Eremin-Solenikov
2011-04-01 14:10   ` Sergei Shtylyov
2011-04-01 14:50     ` Dmitry Eremin-Solenikov [this message]
2011-04-04  6:58       ` Eric Miao
2011-04-01 13:56 ` [PATCH 3/7] stargate2: udc_is_connected is ignored for pxa27x, drop it Dmitry Eremin-Solenikov
2011-04-01 13:56 ` [PATCH 4/7] pxa25x: separate lubbock handling to lubbock-usb transceiver Dmitry Eremin-Solenikov
2011-04-04  7:01   ` Eric Miao
2011-04-04  7:04     ` Eric Miao
2011-04-06 21:21       ` Dmitry Eremin-Solenikov
2011-04-07  1:48         ` Eric Miao
2011-07-01 11:48           ` Dmitry Eremin-Solenikov
2011-07-05  7:26             ` Eric Miao
2011-07-05 13:26               ` Greg KH
2011-07-05 14:35                 ` Dmitry Eremin-Solenikov
2011-04-01 13:56 ` [PATCH 5/7] lubbock: switch to using lubbock_usb_xceiv transceiver Dmitry Eremin-Solenikov
2011-04-01 13:56 ` [PATCH 6/7] pxa25x: drop handling of udc_is_connected Dmitry Eremin-Solenikov
2011-04-01 19:02   ` Sergei Shtylyov
2011-04-02 14:46     ` Dmitry Eremin-Solenikov
2011-04-01 13:56 ` [PATCH 7/7] gpio-vbus: ask for vbus_draw regulator before registering xceiv Dmitry Eremin-Solenikov
2011-04-18  8:42   ` Eric Miao
2011-05-02 23:38     ` Greg KH
2011-05-03  8:46       ` [PATCH] " Dmitry Eremin-Solenikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D95E648.5000906@gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).