From: fabio.estevam@freescale.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds: provide helper to register "leds-gpio" devices
Date: Tue, 5 Apr 2011 13:13:28 -0300 [thread overview]
Message-ID: <4D9B3FA8.1010407@freescale.com> (raw)
In-Reply-To: <1301992655-8514-1-git-send-email-u.kleine-koenig@pengutronix.de>
Hi Uwe,
On 4/5/2011 5:37 AM, Uwe Kleine-K?nig wrote:
> This function makes a deep copy of the platform data to allow it to live
> in init memory.
> The definition cannot go into leds-gpio.c because it needs to be builtin
> to be usable by platforms.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
I tested your patch on a MX53EVK board, but I could only build it after unselecting the mmc driver.
This is the error I got when mmc was selected:
CC drivers/mmc/card/mmc_test.o
LD drivers/mmc/card/built-in.o
CC drivers/mmc/core/sdio_io.o
In file included from include/linux/mmc/host.h:13,
from drivers/mmc/core/sdio_io.c:12:
include/linux/leds.h:220: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'gpio_led_register_device'
make[3]: *** [drivers/mmc/core/sdio_io.o] Error 1
make[2]: *** [drivers/mmc/core] Error 2
make[1]: *** [drivers/mmc] Error 2
make: *** [drivers] Error 2
Regards,
Fabio Estevam
next prev parent reply other threads:[~2011-04-05 16:13 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 17:06 [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds Fabio Estevam
2011-04-04 17:06 ` [PATCH v2 2/2] ARM: mx5/mx53_evk.c: Add LED support Fabio Estevam
2011-04-04 17:19 ` [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds Sascha Hauer
2011-04-04 17:42 ` Uwe Kleine-König
2011-04-04 17:52 ` Russell King - ARM Linux
2011-04-04 18:06 ` H Hartley Sweeten
2011-04-04 18:17 ` Russell King - ARM Linux
2011-04-04 21:52 ` H Hartley Sweeten
2011-04-05 7:30 ` Uwe Kleine-König
2011-04-05 7:40 ` Russell King - ARM Linux
2011-04-05 7:43 ` Uwe Kleine-König
2011-04-05 7:47 ` Russell King - ARM Linux
2011-04-05 7:51 ` Uwe Kleine-König
2011-04-05 7:59 ` Russell King - ARM Linux
2011-04-05 8:32 ` Uwe Kleine-König
2011-04-05 8:43 ` Russell King - ARM Linux
2011-04-05 8:46 ` Uwe Kleine-König
2011-04-05 8:37 ` [PATCH] leds: provide helper to register "leds-gpio" devices Uwe Kleine-König
2011-04-05 16:13 ` Fabio Estevam [this message]
2011-04-05 16:29 ` Fabio Estevam
2011-04-05 18:12 ` H Hartley Sweeten
2011-04-05 16:33 ` Russell King - ARM Linux
2011-04-05 20:24 ` [PATCH v2] " Uwe Kleine-König
2011-04-06 11:45 ` Fabio Estevam
2011-04-06 11:52 ` Richard Purdie
2011-04-06 12:33 ` Uwe Kleine-König
2011-04-06 13:38 ` Richard Purdie
2011-04-11 20:35 ` [PATCH v3] " Uwe Kleine-König
2011-04-12 21:48 ` Russell King - ARM Linux
2011-04-13 6:23 ` Uwe Kleine-König
2011-05-06 21:03 ` Richard Purdie
2011-05-09 8:00 ` Uwe Kleine-König
2011-04-26 15:08 ` Uwe Kleine-König
2011-05-06 8:25 ` Uwe Kleine-König
2011-05-09 22:02 ` Andrew Morton
2011-05-09 22:17 ` Russell King - ARM Linux
2011-05-10 6:45 ` Uwe Kleine-König
2011-05-10 7:31 ` Uwe Kleine-König
2011-05-10 8:50 ` [PATCH v4] " Uwe Kleine-König
2011-05-10 8:50 ` [PATCH] [wip] ARM: imx: register "leds-gpio" device using new helper function Uwe Kleine-König
2011-05-10 22:26 ` H Hartley Sweeten
2011-05-11 6:22 ` Uwe Kleine-König
2011-05-10 23:02 ` H Hartley Sweeten
2011-04-19 23:19 ` [PATCH] leds: provide helper to register "leds-gpio" devices Andrew Morton
2011-04-19 23:24 ` Russell King - ARM Linux
2011-04-19 23:50 ` Andrew Morton
2011-04-05 16:41 ` [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9B3FA8.1010407@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).