From: viresh.kumar@st.com (viresh kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail
Date: Wed, 6 Apr 2011 15:40:26 +0530 [thread overview]
Message-ID: <4D9C3C12.4090408@st.com> (raw)
In-Reply-To: <1302081865-2962-5-git-send-email-u.kleine-koenig@pengutronix.de>
On 04/06/2011 02:54 PM, Uwe Kleine-K?nig wrote:
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
> ---
> Hello,
>
> I wasn't sure what to return when dev_set_drvdata is called with
> dev=NULL. I choosed 0, but -EINVAL would be OK for me, too. What do you
> think?
Uwe,
I feel -EINVAL would be more appropriate here.
Return value of 0 would mean drvdata is set properly, which is not the case.
Otherwise, patch series looks fine to me. Please add my reviewed-by for all patches.
Reviewed-by: Viresh Kumar <viresh.kumar@st.com>
--
viresh
next prev parent reply other threads:[~2011-04-06 10:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 4:33 [RFC] device.h: add device_set_platdata routine Viresh Kumar
2011-03-01 7:59 ` Uwe Kleine-König
2011-03-01 8:27 ` viresh kumar
2011-03-01 9:05 ` Uwe Kleine-König
2011-03-01 9:13 ` viresh kumar
2011-03-01 15:34 ` Greg KH
2011-04-06 9:24 ` [PATCH 1/5] driver core/platform_device_add_data: set platform_data to NULL if !data Uwe Kleine-König
2011-04-11 18:50 ` Uwe Kleine-König
2011-04-11 19:07 ` Greg KH
2011-04-06 9:24 ` [PATCH 2/5] driver core/platform_device_add_data: free platform data before overwriting Uwe Kleine-König
2011-04-06 9:24 ` [PATCH 3/5] driver core/platform_device_add_resources: set resource to NULL if !res Uwe Kleine-König
2011-04-06 9:24 ` [PATCH 4/5] driver core/platform_device_add_resources: free resource before overwriting Uwe Kleine-König
2011-04-06 9:24 ` [PATCH 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail Uwe Kleine-König
2011-04-06 9:36 ` Michał Mirosław
2011-04-06 11:06 ` Uwe Kleine-König
2011-04-06 11:25 ` Michał Mirosław
2011-04-11 18:42 ` [PATCH v2] " Uwe Kleine-König
2011-04-19 23:58 ` Greg KH
2011-04-20 7:42 ` Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 1/5] driver core/platform_device_add_data: set platform_data to NULL if !data Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 2/5] driver core/platform_device_add_data: free platform data before overwriting Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 3/5] driver core/platform_device_add_resources: set resource to NULL if !res Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 4/5] driver core/platform_device_add_resources: free resource before overwriting Uwe Kleine-König
2011-04-20 7:44 ` [PATCH v2 5/5] driver core: let dev_set_drvdata return int instead of void as it can fail Uwe Kleine-König
2011-04-29 8:12 ` Russell King - ARM Linux
2011-04-29 9:16 ` Uwe Kleine-König
2011-04-20 16:17 ` [PATCH v2] " Greg KH
2011-04-20 9:09 ` Michał Mirosław
2011-04-20 16:15 ` Greg KH
2011-04-20 17:59 ` Michał Mirosław
2011-04-06 10:10 ` viresh kumar [this message]
2011-04-06 11:41 ` [PATCH 5/5] " Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9C3C12.4090408@st.com \
--to=viresh.kumar@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).