From: jic23@cam.ac.uk (Jonathan Cameron)
To: linux-arm-kernel@lists.infradead.org
Subject: gpio.h interaction with other headers issue on pxa (maybe arm in general?)
Date: Wed, 06 Apr 2011 15:11:01 +0100 [thread overview]
Message-ID: <4D9C7475.6080900@cam.ac.uk> (raw)
Dear all,
Doing a quick test build of drivers staging/iio/gyro/adis16080_core.c for pxa27x
gave me:
CHECK drivers/staging/iio/gyro/adis16080_core.c
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:57:48: error: Expected ; at end of declaration
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:57:48: error: got read_cpuid_id
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:59:16: error: Expected ; at the end of type declaration
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:59:16: error: got }
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:60:1: error: Expected ; at the end of type declaration
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:60:1: error: got }
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:64:16: error: Expected ; at the end of type declaration
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:64:16: error: got }
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:65:1: error: Expected ; at the end of type declaration
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:65:1: error: got }
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:69:16: error: Expected ; at the end of type declaration
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:69:16: error: got }
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:70:1: error: Expected ; at the end of type declaration
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:70:1: error: got }
/home/jic23/src/kernel/onwards/arch/arm/include/asm/cputype.h:59:16: error: undefined identifier '__val'
Simply reorder the header includes to have kernel.h before gpio.h fixes this, but is it an indication of
an underlying problem that should have a more general fix?
Give the driver was developed on blackfin, I'm guessing it's fine for them and given
Greg's testing on x86 and friends I guess it is fine there as well.
Jonathan
next reply other threads:[~2011-04-06 14:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 14:11 Jonathan Cameron [this message]
2011-04-07 1:23 ` gpio.h interaction with other headers issue on pxa (maybe arm in general?) Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D9C7475.6080900@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).