From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/4] MTD : add the common code for GPMI controller driver
Date: Thu, 14 Apr 2011 14:40:58 +0800 [thread overview]
Message-ID: <4DA696FA.90804@freescale.com> (raw)
In-Reply-To: <19878.38524.705271.384302@ipc1.ka-ro>
hi:
> Hi,
>
> Huang Shijie writes:
>>>> + this->swap_block_mark = true;
>>>> + if (GPMI_IS_MX23(this))
>>>> + this->swap_block_mark = false;
>>>>
>>> if ... else ...?
>> else is "true" by default.
>>
> I meant it would be clearer to do:
> if (GPMI_IS_MX23(this))
> this->swap_block_mark = false;
> else
> this->swap_block_mark = true;
>
:)
thanks.
Huang Shijie
> Lothar Wa?mann
next prev parent reply other threads:[~2011-04-14 6:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 6:24 [PATCH v5 0/4] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-04-13 6:24 ` [PATCH v5 3/4] MTD : add support for imx23 and imx28 Huang Shijie
2011-04-13 6:24 ` [PATCH v5 4/4] MTD : add GPMI driver in the config and Makefile Huang Shijie
2011-07-08 18:23 ` [PATCH v5 2/4] MTD : add the common code for GPMI controller driver Huang Shijie
2011-04-13 19:54 ` Lothar Waßmann
2011-04-14 2:20 ` Huang Shijie
2011-04-14 6:38 ` Lothar Waßmann
2011-04-14 6:40 ` Huang Shijie [this message]
2011-04-14 6:24 ` Lothar Waßmann
2011-04-14 6:36 ` Huang Shijie
2011-07-08 18:24 ` [PATCH v5 1/4] ARM: add GPMI support for imx23/imx28 Huang Shijie
2011-04-13 7:41 ` Lothar Waßmann
2011-04-13 9:42 ` Huang Shijie
2011-04-13 9:03 ` Uwe Kleine-König
2011-04-13 9:52 ` Huang Shijie
2011-04-13 10:03 ` Uwe Kleine-König
2011-04-13 10:49 ` Huang Shijie
2011-04-13 11:43 ` Shawn Guo
2011-04-13 13:25 ` Huang Shijie
2011-04-13 13:51 ` Uwe Kleine-König
2011-04-14 1:19 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA696FA.90804@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).