From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: mxs: add GPMI support for imx23/imx28
Date: Fri, 15 Apr 2011 16:13:43 +0800 [thread overview]
Message-ID: <4DA7FE37.7030808@freescale.com> (raw)
In-Reply-To: <20110415080621.GL31990@pengutronix.de>
> On Fri, Apr 15, 2011 at 04:01:47PM +0800, Huang Shijie wrote:
>> +#define GPMI_NFC_DRIVER_NAME "gpmi-nfc"
>> +#define GPMI_NFC_DRIVER_MX23 "imx23-gpmi-nfc"
>> +#define GPMI_NFC_DRIVER_MX28 "imx28-gpmi-nfc"
>> +#define GPMI_NFC_DRIVER_MX50 "imx50-gpmi-nfc"
> Is it sensible to keep these when they are only used in a single .c
> file?
>
I also use these in gpmi driver for distinguish platform id.
Do i have to remove these lines , and use the hardcode?
next prev parent reply other threads:[~2011-04-15 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 8:01 [PATCH 1/2] ARM: mxs: add GPMI support for imx23/imx28 Huang Shijie
2011-04-15 8:01 ` [PATCH 2/2] ARM: mxs: add GPMI device " Huang Shijie
2011-04-15 8:12 ` Uwe Kleine-König
2011-04-15 8:33 ` Huang Shijie
2011-04-15 8:06 ` [PATCH 1/2] ARM: mxs: add GPMI support " Uwe Kleine-König
2011-04-15 8:13 ` Huang Shijie [this message]
2011-04-15 8:42 ` Uwe Kleine-König
2011-04-15 8:50 ` Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DA7FE37.7030808@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).