From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (viresh kumar) Date: Tue, 19 Apr 2011 11:53:29 +0530 Subject: [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from callback routine. In-Reply-To: <438BB0150E931F4B9CE701519A44630108519E1BE6@bgsmsx502.gar.corp.intel.com> References: <438BB0150E931F4B9CE701519A44630108519E1BE6@bgsmsx502.gar.corp.intel.com> Message-ID: <4DAD2A61.4020406@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 04/19/2011 11:42 AM, Koul, Vinod wrote: > On 04/18/2011 04:20 PM, viresh kumar wrote: >> >> Resubmission of new transfer must be allowed from callbacks. For this release >> lock before calling callback routine and enable them again. > Why would you like to do that? > > IMO it's not a good thing as you are essentially doing it in your tasklet... > Make sure the submit() is done by client before this and you use it to start > next transaction in you tasklet and let client know in callback txn is > finished. > Vinod, I initiated this discussion few days back on a separate thread: http://www.spinics.net/lists/arm-kernel/msg121139.html And so implemented this. -- viresh