From: plyatov@gmail.com (Igor Plyatov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-at91: gsia18s board improvements and bug fixes
Date: Wed, 20 Apr 2011 15:43:23 +0400 [thread overview]
Message-ID: <4DAEC6DB.8000600@gmail.com> (raw)
In-Reply-To: <20110420105120.GI4204@game.jcrosoft.org>
Hello Jean-Christophe!
> On 13:23 Wed 20 Apr , Igor Plyatov wrote:
>> * AT91_PIN_Pxxx port names replaced by human readable GPO_xxxx, GPI_xxxx,
> I do not see the improvement
This does not mean that here is no it for all!
This is very noticeable improvement for me regarding to schematic and
source code maintenance.
>> GPIO_xxxx names. This simplify source code and schematic maintenance.
>> * Active logic levels and default states corrected for GPOs.
>> * Replace small functions which use platform_register_device() by its direct
>> calls.
> ditto here
Source code is and more clean and simple now.
>> * Remove GPIO_CARD_UNMOUNT_1 gpio_keys_button, because it not used.
>> * debounce_interval added for critical buttons.
>> * Remove unneeded GPI setup code for buttons, because this done by corresponding
>> driver.
>> * pcf8574x_0x20_setup() and pcf8574x_0x20_teardown functions small refactoring.
> Best Regards,
> J.
next prev parent reply other threads:[~2011-04-20 11:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 9:23 [PATCH] mach-at91: gsia18s board improvements and bug fixes Igor Plyatov
2011-04-20 10:51 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-20 11:43 ` Igor Plyatov [this message]
2011-04-21 14:56 ` Nicolas Ferre
2011-04-22 5:00 ` Igor Plyatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAEC6DB.8000600@gmail.com \
--to=plyatov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).