linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/14] at91: move register clocks to soc generic init
Date: Tue, 26 Apr 2011 15:13:31 +1200	[thread overview]
Message-ID: <4DB6385B.40703@bluewatersys.com> (raw)
In-Reply-To: <1303780300-2205-1-git-send-email-plagnioj@jcrosoft.com>

On 04/26/2011 01:11 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Cc: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: Patrice Vilchez <patrice.vilchez@atmel.com>

Looks good.

Reviewed-by: Ryan Mallon <ryan@bluewatersys.com>

> ---
>  arch/arm/mach-at91/at572d940hf.c |    4 +---
>  arch/arm/mach-at91/at91cap9.c    |    4 +---
>  arch/arm/mach-at91/at91rm9200.c  |    4 +---
>  arch/arm/mach-at91/at91sam9260.c |    4 +---
>  arch/arm/mach-at91/at91sam9261.c |    4 +---
>  arch/arm/mach-at91/at91sam9263.c |    4 +---
>  arch/arm/mach-at91/at91sam9g45.c |    4 +---
>  arch/arm/mach-at91/at91sam9rl.c  |    4 +---
>  arch/arm/mach-at91/soc.c         |    3 +++
>  arch/arm/mach-at91/soc.h         |    1 +
>  10 files changed, 12 insertions(+), 24 deletions(-)
> 
> diff --git a/arch/arm/mach-at91/at572d940hf.c b/arch/arm/mach-at91/at572d940hf.c
> index 66405af..7d7a4f2 100644
> --- a/arch/arm/mach-at91/at572d940hf.c
> +++ b/arch/arm/mach-at91/at572d940hf.c
> @@ -370,9 +370,6 @@ static void __init at572d940hf_initialize(unsigned long main_clock)
>  
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
> -
> -	/* Register the processor-specific clocks */
> -	at572d940hf_register_clocks();
>  }
>  
>  /* --------------------------------------------------------------------
> @@ -425,6 +422,7 @@ struct at91_dev_resource at572d940hf_pit __initdata = {
>  struct at91_soc __initdata at572d940hf_soc = {
>  	.name = "at572d940hf",
>  	.default_irq_priority = at572d940hf_default_irq_priority,
> +	.register_clocks = at572d940hf_register_clocks,
>  	.init = at572d940hf_initialize,
>  	.gpio = {
>  		.resource = at572d940hf_pios,
> diff --git a/arch/arm/mach-at91/at91cap9.c b/arch/arm/mach-at91/at91cap9.c
> index dd5e858..c304d9c 100644
> --- a/arch/arm/mach-at91/at91cap9.c
> +++ b/arch/arm/mach-at91/at91cap9.c
> @@ -368,9 +368,6 @@ static void __init at91cap9_initialize(unsigned long main_clock)
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
>  
> -	/* Register the processor-specific clocks */
> -	at91cap9_register_clocks();
> -
>  	/* Remember the silicon revision */
>  	if (cpu_is_at91cap9_revB())
>  		system_rev = 0xB;
> @@ -428,6 +425,7 @@ struct at91_dev_resource at91cap9_pit __initdata = {
>  struct at91_soc __initdata at91cap9_soc = {
>  	.name = "at91cap9",
>  	.default_irq_priority = at91cap9_default_irq_priority,
> +	.register_clocks = at91cap9_register_clocks,
>  	.init = at91cap9_initialize,
>  	.gpio = {
>  		.resource = at91cap9_pios,
> diff --git a/arch/arm/mach-at91/at91rm9200.c b/arch/arm/mach-at91/at91rm9200.c
> index 7b9d3a4..f5f5711 100644
> --- a/arch/arm/mach-at91/at91rm9200.c
> +++ b/arch/arm/mach-at91/at91rm9200.c
> @@ -330,9 +330,6 @@ static void __init at91rm9200_initialize(unsigned long main_clock)
>  
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
> -
> -	/* Register the processor-specific clocks */
> -	at91rm9200_register_clocks();
>  }
>  
>  
> @@ -386,6 +383,7 @@ struct at91_dev_resource at91rm9200_st __initdata = {
>  struct at91_soc __initdata at91rm9200_soc = {
>  	.name = "at91rm9200",
>  	.default_irq_priority = at91rm9200_default_irq_priority,
> +	.register_clocks = at91rm9200_register_clocks,
>  	.init = at91rm9200_initialize,
>  	.gpio = {
>  		.resource = at91rm9200_pios,
> diff --git a/arch/arm/mach-at91/at91sam9260.c b/arch/arm/mach-at91/at91sam9260.c
> index 0567556b..7a2d10b 100644
> --- a/arch/arm/mach-at91/at91sam9260.c
> +++ b/arch/arm/mach-at91/at91sam9260.c
> @@ -362,9 +362,6 @@ static void __init at91sam9260_initialize(unsigned long main_clock)
>  
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
> -
> -	/* Register the processor-specific clocks */
> -	at91sam9260_register_clocks();
>  }
>  
>  /* --------------------------------------------------------------------
> @@ -417,6 +414,7 @@ struct at91_dev_resource at91sam9260_pit __initdata = {
>  struct at91_soc __initdata at91sam9260_soc = {
>  	.name = "at91sam9260",
>  	.default_irq_priority = at91sam9260_default_irq_priority,
> +	.register_clocks = at91sam9260_register_clocks,
>  	.init = at91sam9260_initialize,
>  	.gpio = {
>  		.resource = at91sam9260_pios,
> diff --git a/arch/arm/mach-at91/at91sam9261.c b/arch/arm/mach-at91/at91sam9261.c
> index 603c6fe..a2ee99d 100644
> --- a/arch/arm/mach-at91/at91sam9261.c
> +++ b/arch/arm/mach-at91/at91sam9261.c
> @@ -328,9 +328,6 @@ static void __init at91sam9261_initialize(unsigned long main_clock)
>  
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
> -
> -	/* Register the processor-specific clocks */
> -	at91sam9261_register_clocks();
>  }
>  
>  /* --------------------------------------------------------------------
> @@ -383,6 +380,7 @@ struct at91_dev_resource at91sam9261_pit __initdata = {
>  struct at91_soc __initdata at91sam9261_soc = {
>  	.name = "at91sam9261",
>  	.default_irq_priority = at91sam9261_default_irq_priority,
> +	.register_clocks = at91sam9261_register_clocks,
>  	.init = at91sam9261_initialize,
>  	.gpio = {
>  		.resource = at91sam9261_pios,
> diff --git a/arch/arm/mach-at91/at91sam9263.c b/arch/arm/mach-at91/at91sam9263.c
> index e7ff884..0b9a6b4 100644
> --- a/arch/arm/mach-at91/at91sam9263.c
> +++ b/arch/arm/mach-at91/at91sam9263.c
> @@ -337,9 +337,6 @@ static void __init at91sam9263_initialize(unsigned long main_clock)
>  
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
> -
> -	/* Register the processor-specific clocks */
> -	at91sam9263_register_clocks();
>  }
>  
>  /* --------------------------------------------------------------------
> @@ -392,6 +389,7 @@ struct at91_dev_resource at91sam9263_pit __initdata = {
>  struct at91_soc __initdata at91sam9263_soc = {
>  	.name = "at91sam9263",
>  	.default_irq_priority = at91sam9263_default_irq_priority,
> +	.register_clocks = at91sam9263_register_clocks,
>  	.init = at91sam9263_initialize,
>  	.gpio = {
>  		.resource = at91sam9263_pios,
> diff --git a/arch/arm/mach-at91/at91sam9g45.c b/arch/arm/mach-at91/at91sam9g45.c
> index 077eecf..96cfc16 100644
> --- a/arch/arm/mach-at91/at91sam9g45.c
> +++ b/arch/arm/mach-at91/at91sam9g45.c
> @@ -355,9 +355,6 @@ static void __init at91sam9g45_initialize(unsigned long main_clock)
>  
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
> -
> -	/* Register the processor-specific clocks */
> -	at91sam9g45_register_clocks();
>  }
>  
>  /* --------------------------------------------------------------------
> @@ -410,6 +407,7 @@ struct at91_dev_resource at91sam9g45_pit __initdata = {
>  struct at91_soc __initdata at91sam9g45_soc = {
>  	.name = "at91sam9g45",
>  	.default_irq_priority = at91sam9g45_default_irq_priority,
> +	.register_clocks = at91sam9g45_register_clocks,
>  	.init = at91sam9g45_initialize,
>  	.gpio = {
>  		.resource = at91sam9g45_pios,
> diff --git a/arch/arm/mach-at91/at91sam9rl.c b/arch/arm/mach-at91/at91sam9rl.c
> index 7623617..638e921 100644
> --- a/arch/arm/mach-at91/at91sam9rl.c
> +++ b/arch/arm/mach-at91/at91sam9rl.c
> @@ -321,9 +321,6 @@ static void __init at91sam9rl_initialize(unsigned long main_clock)
>  
>  	/* Init clock subsystem */
>  	at91_clock_init(main_clock);
> -
> -	/* Register the processor-specific clocks */
> -	at91sam9rl_register_clocks();
>  }
>  
>  /* --------------------------------------------------------------------
> @@ -376,6 +373,7 @@ struct at91_dev_resource at91sam9rl_pit __initdata = {
>  struct at91_soc __initdata at91sam9rl_soc = {
>  	.name = "at91sam9rl",
>  	.default_irq_priority = at91sam9rl_default_irq_priority,
> +	.register_clocks = at91sam9rl_register_clocks,
>  	.init = at91sam9rl_initialize,
>  	.gpio = {
>  		.resource = at91sam9rl_pios,
> diff --git a/arch/arm/mach-at91/soc.c b/arch/arm/mach-at91/soc.c
> index 1b05997..c82d219 100644
> --- a/arch/arm/mach-at91/soc.c
> +++ b/arch/arm/mach-at91/soc.c
> @@ -117,6 +117,9 @@ void __init at91_initialize(unsigned long main_clock)
>  
>  	current_soc.init(main_clock);
>  
> +	/* Register the processor-specific clocks */
> +	current_soc.register_clocks();
> +
>  	/* Register GPIO subsystem */
>  	at91_add_gpio();
>  }
> diff --git a/arch/arm/mach-at91/soc.h b/arch/arm/mach-at91/soc.h
> index a60ac0a..ca8b30e 100644
> --- a/arch/arm/mach-at91/soc.h
> +++ b/arch/arm/mach-at91/soc.h
> @@ -16,6 +16,7 @@ struct at91_soc {
>  	struct at91_dev_resource *pit;
>  	struct at91_dev_resource *st;
>  
> +	void (*register_clocks)(void);
>  	void (*init)(unsigned long main_clock);
>  };
>  


-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

  reply	other threads:[~2011-04-26  3:13 UTC|newest]

Thread overview: 85+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-25 18:08 [PATCH 0/14] at91: factorize soc init and switch to early platform Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 01/14] at91rm9200: introduce at91rm9200_set_type to specficy cpu package Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 02/14] at91: introduce commom AT91_BASE_SYS Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 21:48   ` Ryan Mallon
2011-04-26  4:27     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 03/14] at91: factorize at91 interrupts init to soc Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 21:52   ` Ryan Mallon
2011-04-25 22:11   ` H Hartley Sweeten
2011-04-26 17:29     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-26 22:04       ` Andrew Victor
2011-04-26 23:39         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28 11:43   ` Russell King - ARM Linux
2011-04-25 18:31 ` [PATCH 04/14 v2] at91: merge board usb-a9260 and usb-a9263 together Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 05/14] at91: use structure to store the current soc Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 22:08   ` Ryan Mallon
2011-04-26  4:21     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-26  4:44       ` Ryan Mallon
2011-04-26  6:42         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-26 20:22           ` Ryan Mallon
2011-04-26 23:45             ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-27  0:13               ` Ryan Mallon
2011-04-27  1:27                 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-27  1:47                   ` Ryan Mallon
2011-04-27  3:18                     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-27  3:41                       ` Ryan Mallon
2011-04-28 14:04       ` Andrew Victor
2011-04-28 14:10         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28 20:20           ` Ryan Mallon
2011-04-28 23:06             ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28 23:24               ` Ryan Mallon
2011-04-29  2:10                 ` Ryan Mallon
2011-04-29  8:32                   ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-29  8:35                 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-29  8:50                   ` Ryan Mallon
2011-05-02 15:38         ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02 20:25           ` Ryan Mallon
2011-05-02 20:24             ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02 20:38               ` Ryan Mallon
2011-05-02 20:51                 ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02 21:27                   ` Ryan Mallon
2011-05-02 21:29                     ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02 22:05                       ` Ryan Mallon
2011-05-02 22:06                         ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02 22:32                           ` Ryan Mallon
2011-05-02 22:41                             ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-02 23:16                     ` Russell King - ARM Linux
2011-05-02 23:16                       ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 06/14 v3] at91: switch to CLKDEV_LOOKUP Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 07/14] at91: switch gpio to early platfrom device Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 22:51   ` Ryan Mallon
2011-04-26  4:11     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 08/14] at91: move gpio to drivers/gpio Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 09/14] at91: switch pit timer to early platform devices Jean-Christophe PLAGNIOL-VILLARD
2011-04-28  5:07   ` Ryan Mallon
2011-04-28 11:23   ` Andrew Victor
2011-04-28 11:34     ` Russell King - ARM Linux
2011-04-28 13:15       ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28 16:56         ` Andrew Victor
2011-04-28 17:33           ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28 18:15           ` Russell King - ARM Linux
2011-04-28 20:47             ` Andrew Victor
2011-04-28 21:46               ` Russell King - ARM Linux
2011-04-28 23:38                 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-29  9:28                   ` Russell King - ARM Linux
2011-04-30  1:36                     ` Jean-Christophe PLAGNIOL-VILLARD
2011-05-08 10:08                       ` Russell King - ARM Linux
2011-05-08 10:44                         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-29  7:55               ` Greg Ungerer
2011-04-29  6:08       ` Tony Lindgren
2011-04-29  8:31         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:31 ` [PATCH 10/14] at91: switch st " Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 18:40 ` [PATCH 11/14] at91: move pit timer to drivers/clocksource Jean-Christophe PLAGNIOL-VILLARD
2011-04-25 19:14 ` [PATCH 12/14] at91: move st " Jean-Christophe PLAGNIOL-VILLARD
2011-04-26  1:11 ` [PATCH 13/14] at91: move register clocks to soc generic init Jean-Christophe PLAGNIOL-VILLARD
2011-04-26  3:13   ` Ryan Mallon [this message]
2011-04-26  1:11 ` [PATCH 14/14] at91: move clock subsystem init " Jean-Christophe PLAGNIOL-VILLARD
2011-04-26  3:13   ` Ryan Mallon
2011-04-26  4:13     ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-26  4:32       ` Ryan Mallon
2011-04-26  4:32         ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-27 21:13 ` [PATCH 0/14] at91: factorize soc init and switch to early platform Ryan Mallon
2011-04-28  2:26   ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28  2:41   ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28  3:59     ` Ryan Mallon
2011-04-28  4:14       ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DB6385B.40703@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).