From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 01/12] ARM: gic: add per-cpu interrupt multiplexer
Date: Mon, 25 Apr 2011 21:00:33 -0700 [thread overview]
Message-ID: <4DB64361.4050904@codeaurora.org> (raw)
In-Reply-To: <1303326501-15664-2-git-send-email-marc.zyngier@arm.com>
Just minor comments. I'm not a GIC or IRQ expert (yet).
On 4/20/2011 12:08 PM, Marc Zyngier wrote:
> @@ -312,17 +414,39 @@ static void __init gic_dist_init(struct gic_chip_data *gic,
> * Limit number of interrupts registered to the platform maximum
> */
> irq_limit = gic->irq_offset + gic_irqs;
> - if (WARN_ON(irq_limit > NR_IRQS))
> + if (WARN_ON((irq_limit) > NR_IRQS))
() are RFC leftovers?
> irq_limit = NR_IRQS;
>
> /*
> * Setup the Linux IRQ subsystem.
> */
> for (i = irq_start; i < irq_limit; i++) {
> - irq_set_chip_and_handler(i, &gic_chip, handle_fasteoi_irq);
> +#ifdef CONFIG_ARM_GIC_VPPI
> + if (nrvppis && gic_irq_is_ppi(gic, i))
> + irq_set_chip_and_handler(i, &gic_chip, gic_handle_ppi);
> + else
> +#endif
> + {
> + irq_set_chip_and_handler(i, &gic_chip,
> + handle_fasteoi_irq);
> + set_irq_flags(i, IRQF_VALID | IRQF_PROBE);
> + }
> + irq_set_chip_data(i, gic);
> + }
> +
> +#ifdef CONFIG_ARM_GIC_VPPI
> + if (!nrvppis)
> + goto out;
> + gic->vppi_base = irq_alloc_descs(-1, 0, nrvppis, 0);
> + if (unlikely(WARN_ON(gic->vppi_base < 0)))
WARN_ON should already have an unlikely in it.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-04-26 4:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 19:08 [RFC PATCH 00/12] Consolidating GIC per-cpu interrupts Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 01/12] ARM: gic: add per-cpu interrupt multiplexer Marc Zyngier
2011-04-25 20:17 ` Abhijeet Dharmapurikar
2011-04-26 9:08 ` Marc Zyngier
2011-04-26 4:00 ` Stephen Boyd [this message]
2011-04-26 9:12 ` Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 02/12] ARM: smp_twd: add support for remapped PPI interrupts Marc Zyngier
2011-04-25 17:04 ` Stephen Boyd
2011-04-26 9:05 ` Marc Zyngier
2011-04-26 16:21 ` Stephen Boyd
2011-04-26 16:53 ` Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 03/12] ARM: omap4: use remapped PPI interrupts for local timer Marc Zyngier
2011-04-29 7:24 ` Santosh Shilimkar
2011-05-03 16:18 ` Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 04/12] ARM: versatile: " Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 05/12] ARM: shmobile: " Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 06/12] ARM: ux500: " Marc Zyngier
2011-04-21 8:44 ` Srinidhi KASAGAR
2011-04-21 8:53 ` Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 07/12] ARM: tegra: " Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 08/12] ARM: msm: " Marc Zyngier
2011-04-26 17:13 ` Stephen Boyd
2011-05-03 16:15 ` Marc Zyngier
2011-05-03 17:38 ` Stephen Boyd
2011-05-03 19:04 ` Russell King - ARM Linux
2011-05-04 5:47 ` Stephen Boyd
2011-05-04 18:45 ` Jeff Ohlstein
2011-05-05 1:17 ` Stephen Boyd
2011-04-20 19:08 ` [RFC PATCH 09/12] ARM: exynos4: " Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 10/12] ARM: gic: remove previous local timer interrupt handling Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 11/12] ARM: gic: add compute_irqnr macro for exynos4 Marc Zyngier
2011-04-20 19:08 ` [RFC PATCH 12/12] ARM: SMP: automatically select ARM_GIC_VPPI Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB64361.4050904@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).