From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 23/23] at91: Remove mAgic and ISI device code
Date: Tue, 26 Apr 2011 17:30:29 +1200 [thread overview]
Message-ID: <4DB65875.2030402@bluewatersys.com> (raw)
In-Reply-To: <20110426043924.GI12904@game.jcrosoft.org>
On 04/26/2011 04:39 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:12 Fri 22 Apr , Ryan Mallon wrote:
>> On 22/04/11 05:33, H Hartley Sweeten wrote:
>>> On Wednesday, April 20, 2011 10:42 PM, Ryan Mallon wrote:
>>>>
>>>> The AT572D940HF mAgic device and the AT91SAM9263 ISI device do not
>>>> have drivers yet and therefore the platform code in arch/arm/mach-at91
>>>> is unused and can be removed.
>>>
>>> Is anyone planning on adding these drivers?
>>>
>>> I wonder if it makes sense to add the infrastructure to devices.[ch] and
>>> convert the users even it the drivers are not in mainline yet?
>>
>> I removed them because there is currently a push to reduce the size of
>> the ARM tree. The ISI code has been there since 2008 and the mAgic
>> device code since 2009 without drivers. The ISI device at least is
>> supported on more than one variant, but only had code present for the
>> AT91SAM9263.
>>
>> I think it is better to remove them now, and then if/when drivers get
>> added the support code can be added to the common framework.
> NACK I do not want to remove code just to reduce line code for soc
>
> factorize ok
> remove soc resources no
>
> for the ISI I plan to add it but I work on something else by now
>
> and some patch have already been send to the v4l ML
I'm fine with keeping them if there is driver support, but they do need
to be moved into the common framework. However I don't think it is worth
keeping dead code just be a driver _might_ appear. The mAgic code has
been sitting in the the kernel for over two years with no users.
Especially with the current push to reduce the size of the ARM tree, it
needs to go.
~Ryan
--
Bluewater Systems Ltd - ARM Technology Solution Centre
Ryan Mallon 5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com New Zealand
Phone: +64 3 3779127 Freecall: Australia 1800 148 751
Fax: +64 3 3779135 USA 1800 261 2934
next prev parent reply other threads:[~2011-04-26 5:30 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-21 5:41 [PATCH v2 00/23] at91: Replace duplicate device initialisation code with Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 01/23] at91: Add common devices framework Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 02/23] at91: Make Ethernet device common Ryan Mallon
2011-04-21 23:02 ` H Hartley Sweeten
2011-04-25 20:16 ` Ryan Mallon
2011-04-26 4:35 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-26 5:26 ` Ryan Mallon
2011-04-21 23:19 ` H Hartley Sweeten
2011-04-25 20:15 ` Ryan Mallon
2011-04-28 9:15 ` Russell King - ARM Linux
2011-04-28 17:57 ` H Hartley Sweeten
2011-04-28 18:31 ` Russell King - ARM Linux
2011-04-28 20:46 ` H Hartley Sweeten
2011-04-29 19:32 ` Uwe Kleine-König
2011-04-28 21:34 ` Ryan Mallon
2011-04-28 21:54 ` Russell King - ARM Linux
2011-04-21 5:41 ` [PATCH v2 03/23] at91: Make USB OHCI/EHCI devices common Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 04/23] at91: Make UDC device common Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 05/23] at91: Make MMC " Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 06/23] at91: Make NAND " Ryan Mallon
2011-04-21 5:41 ` [PATCH v2 07/23] at91: Make TWI " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 08/23] at91: Make SPI " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 09/23] at91: Make TCB " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 10/23] at91: Make RTT " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 11/23] at91: Make watchdog " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 13/23] at91: Make PWM " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 14/23] at91: Make SSC " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 15/23] at91: Make AC97 " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 16/23] at91: Make LCD controller " Ryan Mallon
2011-04-21 7:02 ` Uwe Kleine-König
2011-04-21 7:13 ` Ryan Mallon
2011-04-21 12:43 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-21 5:42 ` [PATCH v2 17/23] at91: Make touchscreen " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 18/23] at91: Make HDMAC " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 19/23] at91: Make RTC " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 20/23] at91: Make high speed USB gadget " Ryan Mallon
2011-04-21 21:21 ` H Hartley Sweeten
2011-04-21 21:28 ` Ryan Mallon
2011-04-21 21:53 ` H Hartley Sweeten
2011-04-21 5:42 ` [PATCH v2 21/23] at91: Make compact flash " Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 22/23] at91: Move at91sam9263 CAN device to common devices Ryan Mallon
2011-04-21 5:42 ` [PATCH v2 23/23] at91: Remove mAgic and ISI device code Ryan Mallon
2011-04-21 17:33 ` H Hartley Sweeten
2011-04-21 20:12 ` Ryan Mallon
2011-04-26 4:39 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-26 5:30 ` Ryan Mallon [this message]
2011-04-28 9:19 ` Russell King - ARM Linux
2011-04-28 9:23 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-21 5:43 ` [PATCH v2 12/23] at91: Make UART devices common Ryan Mallon
2011-04-21 17:02 ` [PATCH v2 00/23] at91: Replace duplicate device initialisation code with H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB65875.2030402@bluewatersys.com \
--to=ryan@bluewatersys.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).