From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Wed, 27 Apr 2011 14:05:18 +0400 Subject: [PATCH v4 03/11] da850: pruss platform specific additions. In-Reply-To: <0A4FA4CFE83C4DD4BA36491027E93552@subhasishg> References: <1303474109-6212-1-git-send-email-subhasish@mistralsolutions.com> <1303474109-6212-4-git-send-email-subhasish@mistralsolutions.com> <4DB6A736.3030609@mvista.com> <0A4FA4CFE83C4DD4BA36491027E93552@subhasishg> Message-ID: <4DB7EA5E.7000507@mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 27-04-2011 10:43, Subhasish Ghosh wrote: >>> #include >>> @@ -73,6 +75,7 @@ extern unsigned int da850_max_speed; >>> #define DA8XX_DDR2_CTL_BASE 0xb0000000 >>> #define DA8XX_ARM_RAM_BASE 0xffff0000 >>> #define DA8XX_SHARED_RAM_BASE 0x80000000 >>> +#define DA8XX_PRUSS_MEM_BASE 0x01C30000 >> Keep the list sorted please. Also, this macro doesn't seem used outside >> devices-da8xx.c, so should be moved there... > SG - But would it not be better to have all device addresses at the same place. They are not at the same place already -- which is intentional. The ones used locally in devices-da8xx.c should be #define'd there. WBR, Sergei