[PATCH V3 2/7] dmaengine/dw_dmac: Replace spin_lock* with irqsave variants

[viresh.kumar@st.com (viresh kumar)]

On 04/28/2011 10:40 PM, Russell King - ARM Linux wrote:
> On Wed, Apr 27, 2011 at 03:06:44PM +0530, Viresh Kumar wrote:
>> @@ -407,6 +410,8 @@ EXPORT_SYMBOL(dw_dma_get_dst_addr);
>>  static void dwc_handle_cyclic(struct dw_dma *dw, struct dw_dma_chan *dwc,
>>  		u32 status_block, u32 status_err, u32 status_xfer)
>>  {
>> +	unsigned long flags;
>> +
>>  	if (status_block & dwc->mask) {
>>  		void (*callback)(void *param);
>>  		void *callback_param;
>> @@ -418,9 +423,9 @@ static void dwc_handle_cyclic(struct dw_dma *dw, struct dw_dma_chan *dwc,
>>  		callback = dwc->cdesc->period_callback;
>>  		callback_param = dwc->cdesc->period_callback_param;
>>  		if (callback) {
>> -			spin_unlock(&dwc->lock);
>> +			spin_unlock_irqrestore(&dwc->lock, flags);
>>  			callback(callback_param);
>> -			spin_lock(&dwc->lock);
>> +			spin_lock_irqsave(&dwc->lock, flags);
> 
> I'm really not convinced that this is anywhere near correct.  I'm
> surprised this doesn't spit out a compiler warning.
> 

Sorry, this is done by mistake.

-- 
viresh