From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Tue, 10 May 2011 14:05:00 +0200 Subject: [PATCH] dmaengine: at_hdmac: pause: no need to wait for FIFO empty In-Reply-To: <4DC927DF.1060808@ru.mvista.com> References: <1304957497-22814-1-git-send-email-nicolas.ferre@atmel.com> <4DC927DF.1060808@ru.mvista.com> Message-ID: <4DC929EC.6040706@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 10/05/2011 13:56, Sergei Shtylyov : > Hello. > > On 09-05-2011 20:11, Nicolas Ferre wrote: > >> The addition of the pause feature to atc_control an active wait was >> introduced >> to check the FIFO empty event. > > Couldn't parse this -- did you forget "with"at the start of the > statement? Absolutely. A comma can also improve things... is it better like this? " With the addition of the "pause" feature, an active wait loop was introduced to check the "FIFO empty" event. " Vinod, tell me if you want me to send a new patch. >> This event was not always happening and >> a timout contition was needed. >> But, in some cases, this event depend on the peripheral connected to the >> channel that is paused: FIFO becomes empty if the peripheral consumes >> data. >> The timeout is pretty difficult to evaluate. Moreover, this check is not >> needed. >> In conclusion, it seems sensible to entirely remove the checking of >> "FIFO empty" status when pausing. > >> Signed-off-by: Nicolas Ferre > > WBR, Sergei Thanks, best regards, -- Nicolas Ferre