linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: ryan@bluewatersys.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] ep93xx DMA patches
Date: Tue, 24 May 2011 08:10:20 +1200	[thread overview]
Message-ID: <4DDABF2C.2010708@bluewatersys.com> (raw)
In-Reply-To: <cover.1306082097.git.mika.westerberg@iki.fi>

On 23/05/11 05:03, Mika Westerberg wrote:
> Hello all,
> 
> Motivation of this series was to add DMA support for the ep93xx SPI driver.
> However, current platform DMA code didn't support the M2M channels which were
> required for SPI (and IDE) peripherals.
> 
> Ryan Mallon suggested that maybe we should integrate both M2M and M2P code
> under the dmaengine API. The purpose of this series is to do just that and
> convert all the existing users to use that new API.
> 
> Patches 1-4 add dmaengine driver and convert the existing users to dmaengine
> API. The last patch adds DMA support for the SPI driver.
> 
> I've been testing these on TS-7260 (ep9302) connected to SPI EEPROM, and
> Sim.One (ep9307) with mmc_spi and AC'97 audio.
> 
> memcpy() testing has been done by running drivers/dma/dmatest.ko.
> 
> Regards,
> MW

Hi Mika,

I've had a quick look through the patch series, and I can't see any
problems with it. Thanks especially for the thorough documentation in
the code. Unfortunately I don't have access to any ep93xx hardware at
the moment to do testing. Does anybody else have hardware with I2S audio
to test? It sounds like the SPI code is pretty well tested already?

Like Hartley said, it looks like this reduces the size of
arch/arm/mach-ep93xx and gets rid of our custom DMA implementation, so
we would really like this to get merged.

Also, can you please update my email in the patches to
"rmallon at gmail.com" (add my Signed-off-by if you want).

Thanks,
~Ryan

> 
> Mika Westerberg (5):
>   dmaengine: add ep93xx DMA support
>   ep93xx: add dmaengine platform code
>   ASoC: ep93xx: convert to use the DMA engine API
>   ep93xx: remove the old M2P DMA code
>   spi/ep93xx: add DMA support
> 
>  Documentation/spi/ep93xx_spi                   |   10 +
>  arch/arm/mach-ep93xx/Makefile                  |    2 +-
>  arch/arm/mach-ep93xx/core.c                    |    6 +-
>  arch/arm/mach-ep93xx/dma-m2p.c                 |  411 -------
>  arch/arm/mach-ep93xx/dma.c                     |  108 ++
>  arch/arm/mach-ep93xx/include/mach/dma.h        |  190 ++---
>  arch/arm/mach-ep93xx/include/mach/ep93xx_spi.h |    2 +
>  drivers/dma/Kconfig                            |    7 +
>  drivers/dma/Makefile                           |    1 +
>  drivers/dma/ep93xx_dma.c                       | 1356 ++++++++++++++++++++++++
>  drivers/spi/ep93xx_spi.c                       |  303 +++++-
>  sound/soc/ep93xx/ep93xx-ac97.c                 |    4 +-
>  sound/soc/ep93xx/ep93xx-i2s.c                  |    4 +-
>  sound/soc/ep93xx/ep93xx-pcm.c                  |  137 ++--
>  14 files changed, 1929 insertions(+), 612 deletions(-)
>  delete mode 100644 arch/arm/mach-ep93xx/dma-m2p.c
>  create mode 100644 arch/arm/mach-ep93xx/dma.c
>  create mode 100644 drivers/dma/ep93xx_dma.c
> 

  parent reply	other threads:[~2011-05-23 20:10 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-22 17:03 [PATCH 0/5] ep93xx DMA patches Mika Westerberg
2011-05-22 17:03 ` [PATCH 1/5] dmaengine: add ep93xx DMA support Mika Westerberg
2011-05-25  8:00   ` Koul, Vinod
2011-05-25 19:00     ` Mika Westerberg
2011-05-26  4:38       ` Koul, Vinod
2011-05-26 18:15         ` Mika Westerberg
2011-05-26 18:42           ` H Hartley Sweeten
2011-05-25  8:39   ` Linus Walleij
2011-05-25  8:19     ` Koul, Vinod
2011-05-25  9:09       ` Linus Walleij
2011-05-25 19:54     ` Mika Westerberg
2011-05-25 20:47       ` Linus Walleij
2011-05-26  4:33         ` Mika Westerberg
2011-05-26  5:26           ` Ryan Mallon
2011-05-26  7:15           ` Linus Walleij
2011-05-26 18:38             ` Mika Westerberg
2011-05-26 18:48               ` H Hartley Sweeten
2011-05-26 21:53                 ` Russell King - ARM Linux
2011-05-26 22:58                 ` Linus Walleij
2011-05-27  1:38   ` H Hartley Sweeten
2011-05-28 10:33     ` Mika Westerberg
2011-05-22 17:03 ` [PATCH 2/5] ep93xx: add dmaengine platform code Mika Westerberg
2011-05-27  1:44   ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 3/5] ASoC: ep93xx: convert to use the DMA engine API Mika Westerberg
2011-05-23  5:11   ` Mark Brown
2011-05-23  9:38     ` Liam Girdwood
2011-05-27  1:43   ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 4/5] ep93xx: remove the old M2P DMA code Mika Westerberg
2011-05-27  1:42   ` H Hartley Sweeten
2011-05-22 17:03 ` [PATCH 5/5] spi/ep93xx: add DMA support Mika Westerberg
2011-05-27  1:47   ` H Hartley Sweeten
2011-05-23 17:34 ` [PATCH 0/5] ep93xx DMA patches H Hartley Sweeten
2011-05-23 20:10 ` Ryan Mallon [this message]
2011-05-24 14:42   ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DDABF2C.2010708@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).