LCDVSYNC not set up in Atmel AT91SAM9RL device code

LCDVSYNC not set up in Atmel AT91SAM9RL device code

[Nicholas Kinar]

Hello,

I've been setting up an LCD display interfaced to the Atmel AT91SAM9RL 
processor, and I noticed that in the 
/arch/arm/mach-at91/at91sam9rl_devices.c file, the GPIO pin AT91_PIN_PC4 
is not switched over to the LCD peripheral.

To make the LCD display peripheral operate properly, I had to add the 
following line to the at91_add_device_lcdc() function:

at91_set_A_periph(AT91_PIN_PC4, 0);    /* LCDVSYNC */

Perhaps this could be patched?  I do not know if a similar issue also 
occurs in other device setup files.

Nicholas

LCDVSYNC not set up in Atmel AT91SAM9RL device code

[Xu, Hong]

Hi Nicholas,
> -----Original Message-----
> From: linux-arm-kernel-bounces at lists.infradead.org
> [mailto:linux-arm-kernel-bounces at lists.infradead.org] On Behalf Of
> Nicholas Kinar
> Sent: Tuesday, May 24, 2011 4:53 AM
> To: linux-arm-kernel at lists.infradead.org
> Subject: LCDVSYNC not set up in Atmel AT91SAM9RL device code
> 
> Hello,
> 
> I've been setting up an LCD display interfaced to the Atmel AT91SAM9RL
> processor, and I noticed that in the
> /arch/arm/mach-at91/at91sam9rl_devices.c file, the GPIO pin AT91_PIN_PC4
> is not switched over to the LCD peripheral.
> 
> To make the LCD display peripheral operate properly, I had to add the
> following line to the at91_add_device_lcdc() function:
> 
> at91_set_A_periph(AT91_PIN_PC4, 0);    /* LCDVSYNC */

You're right. Although the LCD panel on Atmel's AT91SAM9RL-EK does not need the VSYNC, you board needs. I just sent out a small patch about this and put you in the "Reported-by" line. Thanks.

> Perhaps this could be patched?  I do not know if a similar issue also
> occurs in other device setup files.
AT91SAM9263-EK has the same issue as you specified, another patch will be sent out, thanks.

BR,
Eric

LCDVSYNC not set up in Atmel AT91SAM9RL device code

[Nicholas Kinar]

On 25/05/2011 12:18 AM, Xu, Hong wrote:
> Hi Nicholas,
>> -----Original Message-----
>> From: linux-arm-kernel-bounces at lists.infradead.org
>> [mailto:linux-arm-kernel-bounces at lists.infradead.org] On Behalf Of
>> Nicholas Kinar
>> Sent: Tuesday, May 24, 2011 4:53 AM
>> To: linux-arm-kernel at lists.infradead.org
>> Subject: LCDVSYNC not set up in Atmel AT91SAM9RL device code
>>
>> Hello,
>>
>> I've been setting up an LCD display interfaced to the Atmel AT91SAM9RL
>> processor, and I noticed that in the
>> /arch/arm/mach-at91/at91sam9rl_devices.c file, the GPIO pin AT91_PIN_PC4
>> is not switched over to the LCD peripheral.
>>
>> To make the LCD display peripheral operate properly, I had to add the
>> following line to the at91_add_device_lcdc() function:
>>
>> at91_set_A_periph(AT91_PIN_PC4, 0);    /* LCDVSYNC */
> You're right. Although the LCD panel on Atmel's AT91SAM9RL-EK does not need the VSYNC, you board needs. I just sent out a small patch about this and put you in the "Reported-by" line. Thanks.
>
>> Perhaps this could be patched?  I do not know if a similar issue also
>> occurs in other device setup files.
> AT91SAM9263-EK has the same issue as you specified, another patch will be sent out, thanks.
>
> BR,
> Eric
>
Thank you; this is very useful.

Nicholas