From: n.kinar@usask.ca (Nicholas Kinar)
To: linux-arm-kernel@lists.infradead.org
Subject: LCDVSYNC not set up in Atmel AT91SAM9RL device code
Date: Wed, 25 May 2011 11:03:37 -0600 [thread overview]
Message-ID: <4DDD3669.2060505@usask.ca> (raw)
In-Reply-To: <4C79549CB6F772498162A641D92D532801C916AD@penmb01.corp.atmel.com>
On 25/05/2011 12:18 AM, Xu, Hong wrote:
> Hi Nicholas,
>> -----Original Message-----
>> From: linux-arm-kernel-bounces at lists.infradead.org
>> [mailto:linux-arm-kernel-bounces at lists.infradead.org] On Behalf Of
>> Nicholas Kinar
>> Sent: Tuesday, May 24, 2011 4:53 AM
>> To: linux-arm-kernel at lists.infradead.org
>> Subject: LCDVSYNC not set up in Atmel AT91SAM9RL device code
>>
>> Hello,
>>
>> I've been setting up an LCD display interfaced to the Atmel AT91SAM9RL
>> processor, and I noticed that in the
>> /arch/arm/mach-at91/at91sam9rl_devices.c file, the GPIO pin AT91_PIN_PC4
>> is not switched over to the LCD peripheral.
>>
>> To make the LCD display peripheral operate properly, I had to add the
>> following line to the at91_add_device_lcdc() function:
>>
>> at91_set_A_periph(AT91_PIN_PC4, 0); /* LCDVSYNC */
> You're right. Although the LCD panel on Atmel's AT91SAM9RL-EK does not need the VSYNC, you board needs. I just sent out a small patch about this and put you in the "Reported-by" line. Thanks.
>
>> Perhaps this could be patched? I do not know if a similar issue also
>> occurs in other device setup files.
> AT91SAM9263-EK has the same issue as you specified, another patch will be sent out, thanks.
>
> BR,
> Eric
>
Thank you; this is very useful.
Nicholas
prev parent reply other threads:[~2011-05-25 17:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 20:53 LCDVSYNC not set up in Atmel AT91SAM9RL device code Nicholas Kinar
2011-05-25 6:18 ` Xu, Hong
2011-05-25 17:03 ` Nicholas Kinar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDD3669.2060505@usask.ca \
--to=n.kinar@usask.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).