From mboxrd@z Thu Jan 1 00:00:00 1970 From: grinberg@compulab.co.il (Igor Grinberg) Date: Fri, 27 May 2011 16:20:55 +0300 Subject: [PATCH v2] OMAP3: beagle: add support for beagleboard xM revision C In-Reply-To: <1306500018-19685-1-git-send-email-koen@dominion.thruhere.net> References: <1306500018-19685-1-git-send-email-koen@dominion.thruhere.net> Message-ID: <4DDFA537.1060207@compulab.co.il> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Koen, Please CC LAKML for patches like this, otherwise Tony, will have to post all of them before pull requesting. On 05/27/11 15:40, Koen Kooi wrote: > The USB enable GPIO has been inverted again and the USER button moved. > > Future revisions will now fall back to xM rev C instead of unknown. > > Signed-off-by: Koen Kooi > --- > > Changes since v1: > * updated against mainline to take Igors gpio cleanup into account > * removed xM rev B checks, no boards with that ID were ever produced, rev B boards show up as rev A > * double checked whitespace: > > total: 0 errors, 0 warnings, 89 lines checked > patches/0001-OMAP3-beagle-add-support-for-beagleboard-xM-revision.patch has no obvious style problems and is ready for submission. > > arch/arm/mach-omap2/board-omap3beagle.c | 31 +++++++++++++++++++++++-------- > 1 files changed, 23 insertions(+), 8 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c > index be71426..177769b 100644 > --- a/arch/arm/mach-omap2/board-omap3beagle.c > +++ b/arch/arm/mach-omap2/board-omap3beagle.c [...] > @@ -565,6 +576,10 @@ static void __init omap3_beagle_init(void) > omap3_mux_init(board_mux, OMAP_PACKAGE_CBB); > omap3_beagle_init_rev(); > omap3_beagle_i2c_init(); > + > + if (cpu_is_omap3630()) > + gpio_buttons[0].gpio = 4; Don't get me wrong, I want this patch in mainline as soon as possible. Just curious, what the hell happened to indentation here? :) checkpatch.pl does not spot things like this... interesting... If you want to leave this as is, go ahead, I don't mind, just curious. -- Regards, Igor.