From: robherring2@gmail.com (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: uncompress and ll debug uart consolidation
Date: Fri, 27 May 2011 13:10:14 -0500 [thread overview]
Message-ID: <4DDFE906.9020101@gmail.com> (raw)
I started looking at the 10 duplicate implementations of PL01x uart code
in various mach/uncompress.h. My first thought was just consolidate
those into 1 uncompress-pl01x.h header similar to debug-pl01x.S.
However, the LL debug macros are basically doing the same thing and are
already used by compressed/head.S, so why not make the uncompress code
use them? The debug macros are already included when DEBUG is defined
for compressed/head.S. It's quite trivial to use putc from head.S in
misc.c instead of the C version. To take it a step further, why not just
use kernel/debug.S for the decompresser and replace much of the code in
compressed/head.S. This would get rid of 2 implementations of DCC,
SA1100 and S3C2410 code.
Am I missing something?
Rob
next reply other threads:[~2011-05-27 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-27 18:10 Rob Herring [this message]
2011-05-27 18:58 ` uncompress and ll debug uart consolidation Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDFE906.9020101@gmail.com \
--to=robherring2@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox