From mboxrd@z Thu Jan  1 00:00:00 1970
From: jcrouse@codeaurora.org (Jordan Crouse)
Date: Tue, 14 Jun 2011 09:49:05 -0600
Subject: [Linaro-mm-sig] [PATCH 02/10] lib: genalloc: Generic allocator
	improvements
In-Reply-To: <20110610135217.701a2fd2@lxorguk.ukuu.org.uk>
References: <1307699698-29369-1-git-send-email-m.szyprowski@samsung.com>	<1307699698-29369-3-git-send-email-m.szyprowski@samsung.com>	<20110610122451.15af86d1@lxorguk.ukuu.org.uk>	<000c01cc2769$02669b70$0733d250$%szyprowski@samsung.com>
	<20110610135217.701a2fd2@lxorguk.ukuu.org.uk>
Message-ID: <4DF782F1.9030105@codeaurora.org>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 06/10/2011 06:52 AM, Alan Cox wrote:
>> I plan to replace it with lib/bitmap.c bitmap_* based allocator (similar like
>> it it is used by dma_declare_coherent_memory() and friends in
>> drivers/base/dma-coherent.c). We need something really simple for CMA area
>> management.
>>
>> IMHO allocate_resource and friends a bit too heavy here, but good to know
>> that such allocator also exists.
>
> Not sure I'd class allocate_resource as heavyweight but providing it's
> using something that already exists rather than inventing yet another
> allocator.
>
> This wants dealing with before it goes upstream though so the chaneges in
> lib/*c etc never have to reach mainline and then get changed back.

Even if CMA doesn't end up using genalloc, there are existing consumers of
the API and I think the _aligned function has value.

I agree that allocate_resource isn't overly heavy, but comparatively genalloc
is really simple and lightweight for a driver to manage a contiguous address
space without a lot of extra thought. I think both APIs serve slightly
different masters, but if somebody thought about it long enough there could
be some consolidation (same goes for the internal guts of
dma_declare_coherent_memory).

I agree with Michal - if genalloc goes deprecated, then so be it, but as
long as it lives, I think its useful to get these functions upstream.

Jordan