linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] Add Arm cpu topology definition
Date: Thu, 16 Jun 2011 12:40:30 -0700	[thread overview]
Message-ID: <4DFA5C2E.40507@codeaurora.org> (raw)
In-Reply-To: <BANLkTinRGRUxKB=C_2Y2F93czWScEUo+Jw@mail.gmail.com>

On 06/16/2011 01:49 AM, Vincent Guittot wrote:
> +config SCHED_MC
> +	bool "Multi-core scheduler support"
> +	depends on SMP && ARM_CPU_TOPOLOGY
> +	default n
> +	help
> +	  Multi-core scheduler support improves the CPU scheduler's decision
> +	  making when dealing with multi-core CPU chips at a cost of slightly
> +	  increased overhead in some places. If unsure say N here.
> +
> +config SCHED_SMT
> +	bool "SMT scheduler support"
> +	depends on SMP && ARM_CPU_TOPOLOGY
> +	default n
> +	help
> +	  Improves the CPU scheduler's decision making when dealing with
> +	  MultiThreading at a cost of slightly increased overhead in some
> +	  places. If unsure say N here.
> +

The default is already n so you can drop those two lines.

> +		 * This is a multiprocessor system
> +		 * multiprocessor format & multiprocessor mode field are set
> +		 */
> +
> +		if (mpidr & (0x1 << 24)) {
> +			/* core performance interdependency */
> +			cpuid_topo->thread_id = (mpidr & 0x3);
> +			cpuid_topo->core_id =  ((mpidr >> 8) & 0xF);
> +			cpuid_topo->socket_id = ((mpidr >> 16) & 0xFF);
> +		} else {
> +			/* normal core interdependency */
> +			cpuid_topo->thread_id = -1;
> +			cpuid_topo->core_id = (mpidr & 0x3);
> +			cpuid_topo->socket_id = ((mpidr >> 8) & 0xF);
> +		}
> +

The ARM ARM says these fields are IMPLEMENTATION DEFINED meaning that
different vendors may attribute different meaning to these fields if
they wish. Does that mean this should be a platform_*() function?

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

  parent reply	other threads:[~2011-06-16 19:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16  8:49 [RFC] Add Arm cpu topology definition Vincent Guittot
2011-06-16  8:55 ` Samuel Thibault
2011-06-16  9:44   ` Vincent Guittot
2011-06-16  9:47     ` Samuel Thibault
2011-06-16  9:56       ` Vincent Guittot
2011-06-16 10:49 ` Daniel Lezcano
2011-06-16 12:05   ` Vincent Guittot
2011-06-16 11:48 ` Amit Kucheria
2011-06-16 12:30   ` Vincent Guittot
2011-06-16 11:55 ` Amit Kachhap
2011-06-16 12:10   ` Vincent Guittot
2011-06-16 13:24 ` Christian Robottom Reis
2011-06-16 13:48   ` Vincent Guittot
2011-06-16 19:40 ` Stephen Boyd [this message]
2011-06-17  6:54   ` Vincent Guittot
2011-06-21 20:36     ` Stephen Boyd
2011-06-22  9:17       ` Catalin Marinas
2011-06-22 10:19         ` Amit Kucheria
2011-06-16 21:13 ` Russell King - ARM Linux
2011-06-17  7:43   ` Vincent Guittot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DFA5C2E.40507@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).