From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH] ARM: smp: Fix the CPU hotplug race with scheduler.
Date: Mon, 20 Jun 2011 20:40:45 +0530 [thread overview]
Message-ID: <4DFF62F5.2080802@ti.com> (raw)
In-Reply-To: <20110620150140.GM2082@n2100.arm.linux.org.uk>
On 6/20/2011 8:31 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 20, 2011 at 08:24:33PM +0530, Santosh Shilimkar wrote:
>> I am away from my board now. Will test this change.
>> btw, the online-active race is still open even with this patch close
>> and should be fixed.
>
> I have yet to see any evidence of that race - I've been running your
> test loop for about an hour so far on Versatile Express and nothing
> yet.
>
In that case my script was just exposing the calibrate() code race
condition.
> That's not to say that we shouldn't wait for the active mask to become
> true before calling schedule(), but I don't think its as big a deal as
> you're suggesting it is.
I am not expert to really trigger that exact race online-to-active but
am sure the race needs to be fixed.
May be Thomas can suggest a test-case to expose that race. From
his fix for x86, it appeared that the race was indeed hit in some
sequence.
Regards,
Santosh
next prev parent reply other threads:[~2011-06-20 15:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 9:23 [RFC PATCH] ARM: smp: Fix the CPU hotplug race with scheduler Santosh Shilimkar
2011-06-20 9:50 ` Russell King - ARM Linux
2011-06-20 10:14 ` Russell King - ARM Linux
2011-06-20 10:28 ` Santosh Shilimkar
2011-06-20 10:35 ` Russell King - ARM Linux
2011-06-20 10:45 ` Santosh Shilimkar
2011-06-20 11:42 ` Santosh Shilimkar
2011-06-20 10:44 ` Russell King - ARM Linux
2011-06-20 10:47 ` Santosh Shilimkar
2011-06-20 11:13 ` Russell King - ARM Linux
2011-06-20 11:25 ` Santosh Shilimkar
2011-06-20 11:40 ` Russell King - ARM Linux
2011-06-20 11:51 ` Santosh Shilimkar
2011-06-20 12:19 ` Russell King - ARM Linux
2011-06-20 12:27 ` Santosh Shilimkar
2011-06-20 12:57 ` Russell King - ARM Linux
2011-06-20 14:23 ` Russell King - ARM Linux
2011-06-20 14:54 ` Santosh Shilimkar
2011-06-20 15:01 ` Russell King - ARM Linux
2011-06-20 15:10 ` Santosh Shilimkar [this message]
2011-06-21 9:08 ` Santosh Shilimkar
2011-06-21 10:00 ` Russell King - ARM Linux
2011-06-21 10:17 ` Santosh Shilimkar
2011-06-21 10:19 ` Russell King - ARM Linux
2011-06-21 10:21 ` Santosh Shilimkar
2011-06-21 10:26 ` Russell King - ARM Linux
2011-06-21 20:16 ` Stephen Boyd
2011-06-21 23:10 ` Russell King - ARM Linux
2011-06-22 0:06 ` Stephen Boyd
2011-06-22 10:06 ` Russell King - ARM Linux
2011-06-20 10:19 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DFF62F5.2080802@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).