From: b32955@freescale.com (Huang Shijie)
To: linux-arm-kernel@lists.infradead.org
Subject: reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for imx23/imx28
Date: Thu, 7 Jul 2011 16:56:01 +0800 [thread overview]
Message-ID: <4E1574A1.4050502@freescale.com> (raw)
In-Reply-To: <201107011109.27206.arnd@arndb.de>
Hi:
> On Friday 01 July 2011 10:57:40 Huang Shijie wrote:
>>>> It's annoying, but it really saves some lines.
>>> It would save more lines if you introduce the macros globally and
>>> convert all existing resource definitions ;-)
>> The origin code did not use any macros.
>> Some one suggested me to use macros.
>> So i used the macros.
>>
>> Do i have to drop the macros?
> Can you find out who made the suggestion? Let's first reach consensus
> about how we want to do these things in the future.
http://www.spinics.net/lists/arm-kernel/msg121384.html
Thanks to your comments.
Best Regards
Huang Shijie
> My opinion is that we should not have macros like these in any platform
> specific code: If the macros are a good idea, we should define them
> globally and let everyone use the same macros. If we decide not to have
> them in global code, it would be even worse to have them in specific
> platforms.
>
> Arnd
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2011-07-07 8:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 16:12 reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for imx23/imx28 Huang Shijie-B32955
2011-06-30 22:29 ` Arnd Bergmann
2011-07-01 6:44 ` Uwe Kleine-König
2011-07-01 8:57 ` Huang Shijie
2011-07-01 9:09 ` Arnd Bergmann
2011-07-07 8:56 ` Huang Shijie [this message]
2011-07-07 15:57 ` Arnd Bergmann
2011-07-07 20:48 ` reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for?imx23/imx28 Uwe Kleine-König
2011-07-07 21:04 ` Arnd Bergmann
2011-07-11 14:40 ` [PATCH] new helper to define common struct resource constructs Uwe Kleine-König
2011-07-11 15:03 ` [PATCH] ARM: mxc: use new helpers to define common struct resource entries Uwe Kleine-König
2011-07-12 13:29 ` [PATCH] new helper to define common struct resource constructs Arnd Bergmann
2011-07-12 17:13 ` H Hartley Sweeten
2011-07-12 18:31 ` [PATCH v2] " Uwe Kleine-König
2011-07-13 21:18 ` [PATCH] " Andrew Morton
2011-07-13 21:42 ` Arnd Bergmann
2011-07-13 22:15 ` H Hartley Sweeten
2011-07-14 8:11 ` [PATCH v3] " Uwe Kleine-König
2011-07-14 11:34 ` Lothar Waßmann
2011-07-01 14:52 ` reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for imx23/imx28 Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1574A1.4050502@freescale.com \
--to=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).