From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] DaVinci: correct MDSTAT_STATE_MASK
Date: Fri, 08 Jul 2011 19:30:26 +0400 [thread overview]
Message-ID: <4E172292.6090600@mvista.com> (raw)
In-Reply-To: <201107081924.57577.sshtylyov@ru.mvista.com>
Hello.
I wrote:
> MDSTAT.STATE occupies bits 0..5 according to all available documentation, so fix
> the #define MDSTAT_STATE_MASK at last. Using the wrong value seems to have been
> harmless though...
Except maybe sleep.S -- davinci_ddr_psc_config() could exit too early when
disabling DDR clock. The same is true with davinci_psc_config() in general but I
don't think that anything depended on its timely return in that case.
> This was noticed by me back in 2009 but I didn't follow up with the patch back
> then... :-/
Shame on me. :-)
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
WBR, Sergei
next prev parent reply other threads:[~2011-07-08 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 15:24 [PATCH] DaVinci: correct MDSTAT_STATE_MASK Sergei Shtylyov
2011-07-08 15:30 ` Sergei Shtylyov [this message]
2011-07-27 16:18 ` Nori, Sekhar
2011-09-06 13:50 ` Sergei Shtylyov
2011-09-06 17:40 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E172292.6090600@mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).