From: rmallon@gmail.com (Ryan Mallon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] clk: Add initial WM831x clock driver
Date: Fri, 15 Jul 2011 15:14:28 +1000 [thread overview]
Message-ID: <4E1FCCB4.4080205@gmail.com> (raw)
In-Reply-To: <20110715050503.GL32716@opensource.wolfsonmicro.com>
On 15/07/11 15:05, Mark Brown wrote:
> On Thu, Jul 14, 2011 at 08:53:39PM -0600, Grant Likely wrote:
>> On Mon, Jul 11, 2011 at 11:53:57AM +0900, Mark Brown wrote:
>>> + if (clkdata->xtal_ena)
>>> + return 0;
>>> + else
>>> + return -EPERM;
>>> +}
>> Nit: return clkdata->xtal_ena ? 0 : -EPERM;
>> Just makes for more concise code.
> I have an extremely strong dislike of the ternery operator, I find it
> does nothing for legibility.
>
I prefer this:
if (!clkdata->xtal_ena)
return -EPERM;
return 0;
}
Which makes the error check clear and makes the success case visible
right at the bottom of the function.
~Ryan
next prev parent reply other threads:[~2011-07-15 5:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 2:53 [PATCH 0/6] clk: Initial feedback for off-SoC slow bus clocks Mark Brown
2011-07-11 2:53 ` [PATCH 1/6] clk: Prototype and document clk_register() Mark Brown
2011-07-11 2:53 ` [PATCH 2/6] clk: Provide a dummy clk_unregister() Mark Brown
2011-07-11 2:53 ` [PATCH 3/6] clk: Constify struct clk_hw_ops Mark Brown
2011-07-11 2:53 ` [PATCH 4/6] clk: Add Kconfig option to build all generic clk drivers Mark Brown
2011-07-11 2:53 ` [PATCH 5/6] clk: Support multiple instances of the same clock provider Mark Brown
2011-07-11 9:34 ` Russell King - ARM Linux
2011-07-11 10:53 ` Mark Brown
2011-07-11 11:11 ` Russell King - ARM Linux
2011-07-11 11:41 ` Mark Brown
2011-07-11 2:53 ` [PATCH 6/6] clk: Add initial WM831x clock driver Mark Brown
2011-07-15 2:53 ` Grant Likely
2011-07-15 5:05 ` Mark Brown
2011-07-15 5:14 ` Ryan Mallon [this message]
2011-07-15 2:53 ` [PATCH 1/6] clk: Prototype and document clk_register() Grant Likely
2011-07-11 3:57 ` [PATCH 0/6] clk: Initial feedback for off-SoC slow bus clocks Mark Brown
2011-07-11 4:30 ` Mike Frysinger
2011-07-11 4:56 ` Barry Song
2011-07-11 5:01 ` [uclinux-dist-devel] " Mike Frysinger
2011-07-11 9:31 ` Russell King - ARM Linux
2011-07-11 10:07 ` Sascha Hauer
2011-07-11 10:28 ` Russell King - ARM Linux
2011-07-11 10:46 ` Sascha Hauer
2011-07-11 11:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1FCCB4.4080205@gmail.com \
--to=rmallon@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).