From: sshtylyov@mvista.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: tegra: paz00: export the WIFI rfkill gpio
Date: Fri, 15 Jul 2011 21:25:00 +0400 [thread overview]
Message-ID: <4E2077EC.1070902@ru.mvista.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049E834C2F@HQMAIL01.nvidia.com>
Hello.
Stephen Warren wrote:
>> This makes the WIFI rfkill gpio available to userspace. On boot,
>> WIFI will be unblocked by default.
> ...
>> +static void __init paz00_wifi_init(void)
>> +{
>> + int ret;
>> +
>> + /* unlock hw rfkill */
>> + ret = gpio_request_one(TEGRA_WIFI_PWRN, GPIOF_OUT_INIT_HIGH,
>> + "wifi pwrn");
>> + if (ret) {
>> + pr_warning("WIFI: could not requestrfkill gpio\n");
>> + return;
>> + }
>> + gpio_export(TEGRA_WIFI_PWRN, 0);
>> +};
>
> Wouldn't you want to skip the gpio_export() call if the gpio_request()
> call failed?
I think that's what he does -- there's a *return* statement.
WBR, Sergei
next prev parent reply other threads:[~2011-07-15 17:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 10:24 [PATCH 0/3] ARM: tegra: paz00: Add Wifi and second serial port support Marc Dietrich
2011-07-15 10:24 ` [PATCH 1/3] ARM: tegra: paz00: add support serial port on JP1 Marc Dietrich
2011-07-15 16:39 ` Stephen Warren
2011-07-16 15:59 ` Marc Dietrich
2011-07-15 10:24 ` [PATCH 2/3] ARM: tegra: paz00: export the WIFI rfkill gpio Marc Dietrich
2011-07-15 12:17 ` Vasily Khoruzhick
2011-07-22 20:38 ` Marc Dietrich
2011-07-15 16:53 ` Stephen Warren
2011-07-15 17:25 ` Sergei Shtylyov [this message]
2011-07-15 17:30 ` Stephen Warren
2011-07-15 10:24 ` [PATCH 3/3] ARM: tegra: paz00: enable wifi led Marc Dietrich
2011-07-15 17:10 ` Stephen Warren
2011-07-16 16:19 ` Marc Dietrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2077EC.1070902@ru.mvista.com \
--to=sshtylyov@mvista.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox