From: tushar.behera@linaro.org (Tushar Behera)
To: linux-arm-kernel@lists.infradead.org
Subject:
Date: Thu, 21 Jul 2011 11:54:46 +0530 [thread overview]
Message-ID: <4E27C62E.8010005@linaro.org> (raw)
In-Reply-To: <CAAgF-BcTUTN5B59NO+yo7o=r=AtzvEHHOPwLBUgL15ifyYfFWA@mail.gmail.com>
On Thursday 21 July 2011 11:13 AM, padma venkat wrote:
> Hi Tushar,
>
> On Thu, Jul 21, 2011 at 10:58 AM, Tushar Behera
> <tushar.behera@linaro.org> wrote:
>> On Thursday 21 July 2011 04:42 PM, Padmavathi Venna wrote:
>>>
[snip]
>>> + gc = irq_alloc_generic_chip("s5p64x0-eint", 1, S5P_IRQ_EINT_BASE,
>>> + S5P_VA_GPIO, handle_level_irq);
>>
>> ^^^^
> Added spaces purposefully to make the parameters aligned properly in
> the next line
But spaces should never be used for indentation.
Quoting from http://www.kernel.org/doc/Documentation/CodingStyle
"Outside of comments, documentation and except in Kconfig, spaces are
never used for indentation"
>> nitpick: Should be TABS
>
> Thanks&Regards
> Padma
[snip]
--
Tushar Behera
prev parent reply other threads:[~2011-07-21 6:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 11:12 No subject Padmavathi Venna
2011-07-21 5:28 ` Tushar Behera
2011-07-21 5:43 ` padma venkat
2011-07-21 6:24 ` Tushar Behera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E27C62E.8010005@linaro.org \
--to=tushar.behera@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox