From: santosh.shilimkar@ti.com (Santosh Shilimkar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/4] Fix CPU hotplug IRQ migration
Date: Fri, 22 Jul 2011 11:05:01 +0530 [thread overview]
Message-ID: <4E290C05.7020209@ti.com> (raw)
In-Reply-To: <20110721151413.GD28942@n2100.arm.linux.org.uk>
+ Colin,
On 7/21/2011 8:44 PM, Russell King - ARM Linux wrote:
> This series fixes a bunch of issues with IRQ migration:
>
> 1. Preventing affinity changes causing IRQs to be directed to off-line CPUs.
> 2. Preventing oopses with non-GIC interrupt controllers.
> 3. Preventing per-CPU IRQs being candidates for migration.
> 4. Removing the abuse of irqdesc's node member.
>
> This prevents crashes on OMAP4430 SDP when non-default IRQ affinity
> settings are used and a CPU which owns some IRQs is offlined.
>
Firstly thanks for fixing the IRQ migration and affinity issues
with hotplug code. Colin found the hotplug irq affinity issue
last week.
Colin quoted ..
----------------------------------
The irq affinity mask is not kept up to date by the ARM irq
code. In particular, migrate_one_irq is not called when
the irq node does not match the cpu going offline, and
when it is called, it doesn't update the irq affinity
mask before calling the irq chip's set_affinity function.
This causes the use of the affinity mask in the mask
and unmask functions to be unreliable, possibly unmasking
an interrupt on a cpu that is offline.
----------------------------------
Need to check if this series addresses above issue as well.
> With this patch set applied, there is no reason core code can't handle
> CPU0 being offlined - on OMAP4, the only remaining issue is CPU0
> being woken from WFI and falsely passing the non-spurious wake-up test.
There is one as commented in other thread. The Secure code runs only
on CPU0 so if you offline the CPU0, all the secure services are not
available.
Regards
Santosh
next prev parent reply other threads:[~2011-07-22 5:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 15:14 [PATCH 0/4] Fix CPU hotplug IRQ migration Russell King - ARM Linux
2011-07-21 15:24 ` [PATCH 1/4] ARM: CPU hotplug: fix abuse of irqdesc->node Russell King - ARM Linux
2011-07-21 15:24 ` [PATCH 2/4] ARM: GIC: avoid routing interrupts to offline CPUs Russell King - ARM Linux
2011-07-21 15:25 ` [PATCH 3/4] ARM: CPU hotplug: pass in proper affinity mask on IRQ migration Russell King - ARM Linux
2011-07-25 12:38 ` Santosh Shilimkar
2011-07-25 13:06 ` Russell King - ARM Linux
2011-07-21 15:25 ` [PATCH 4/4] ARM: CPU hotplug: ensure we migrate all IRQs off a downed CPU Russell King - ARM Linux
2011-07-22 5:35 ` Santosh Shilimkar [this message]
2011-07-22 8:12 ` [PATCH 0/4] Fix CPU hotplug IRQ migration Russell King - ARM Linux
2011-07-22 8:22 ` Santosh Shilimkar
2011-07-22 17:14 ` Colin Cross
2011-07-25 13:04 ` Santosh Shilimkar
2011-07-25 13:23 ` Russell King - ARM Linux
2011-07-25 14:27 ` Santosh Shilimkar
2011-07-25 14:46 ` Russell King - ARM Linux
2011-07-25 15:03 ` Santosh Shilimkar
2011-07-22 8:50 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E290C05.7020209@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).