From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Mon, 25 Jul 2011 23:12:19 +0200 Subject: [PATCH 3/3] dmaengine: at_hdmac: add slave config operation In-Reply-To: <1310006025.20150.29.camel@psiaudioba-mobl1> References: <1151852b20789636633095406a180335364f4afb.1309259835.git.nicolas.ferre@atmel.com> <1310006025.20150.29.camel@psiaudioba-mobl1> Message-ID: <4E2DDC33.3020107@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/07/2011 04:33 AM, Vinod Koul wrote: > On Tue, 2011-06-28 at 13:17 +0200, Nicolas Ferre wrote: >> Only change source/destination peripheral register access width. > How about a little more explainable change log > >> >> Signed-off-by: Nicolas Ferre >> Signed-off-by: Uwe Kleine-K?nig >> --- >> drivers/dma/at_hdmac.c | 29 +++++++++++++++++++++++++++++ >> 1 files changed, 29 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c >> index 7096adb..9cb8044 100644 >> --- a/drivers/dma/at_hdmac.c >> +++ b/drivers/dma/at_hdmac.c >> @@ -954,6 +954,35 @@ static int atc_control(struct dma_chan *chan, enum dma_ctrl_cmd cmd, >> clear_bit(ATC_IS_PAUSED,&atchan->status); >> >> spin_unlock_irqrestore(&atchan->lock, flags); >> + } else if (cmd == DMA_SLAVE_CONFIG) { >> + struct dma_slave_config *dmaengine_cfg = (void *)arg; >> + struct at_dma_slave *atslave = chan->private; > This API was created to remove chan->private, so this doesn't make sense > at all. If your intent is to have a channels internal data, then you > should consider embedding dma_chan into this structure (the way other > dma drivers do) rather than using private field. Yes, I need to rework this slave config part of the driver (and its related calling drivers). So please drop this 3/3 patch of the series. Best regards, -- Nicolas Ferre