From: troy.kisky@boundarydevices.com (Troy Kisky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] davinci: Add wl1271/wlan support for AM18x
Date: Fri, 29 Jul 2011 11:51:46 -0700 [thread overview]
Message-ID: <4E330142.6040809@boundarydevices.com> (raw)
In-Reply-To: <20110728220643.GG1985@WorkStation>
On 7/28/2011 3:06 PM, Ido Yariv wrote:
> Hi Troy,
>
> On Thu, Jul 28, 2011 at 02:15:41PM -0700, Troy Kisky wrote:
>>> + if (power_on) {
>>> + /* Power up sequence required for wl127x devices */
>>> + gpio_set_value(DA850_WLAN_EN, 1);
>>> + usleep_range(15000, 15000);
>>> + gpio_set_value(DA850_WLAN_EN, 0);
>>> + usleep_range(1000, 1000);
>>> + gpio_set_value(DA850_WLAN_EN, 1);
>>> + msleep(70);
>>
>> Why turn on, then off, and then back on?
>> Isn't off, then back on sufficient?
>
> Unfortunately, no. This is a required power up sequence for some
> hardware revisions of the 1271 chip.
That's too bad.
>
>> Also, why not use regulator API like panda board does?
>
> Unlike omap_hsmmc, davinci's MMC host driver does not toggle any
> regulators. To keep things simple, a set_power callback function was
> added to the mmc host as part of this patch series.
> I've considered adding regulator support instead, but found it to be
> a bit over-complicated for this task. In addition, it would require
> either modifying the fixed regulator or adding a new one in order to
> support the above power sequence.
Yes, that is more effort. I'm fine with your method, but with all
the consolidation effort that's being expended currently, it would
be nice if all boards could use a common method to power up sdio cards.
It might make a device tree implementation for this driver easier too,
though I am certainly no expert there.
>
> Thanks for your review,
> Ido.
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2011-07-29 18:51 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-10 13:14 [PATCH v2 0/6] arm: davinci: DA850: wl12xx expansion card Ido Yariv
2011-07-10 13:14 ` [PATCH v2 1/6] arm: davinci: Fix low level gpio irq handlers' argument Ido Yariv
2011-07-11 11:58 ` Nori, Sekhar
2011-07-11 20:33 ` Ido Yariv
2011-07-11 21:03 ` [PATCH v3 " Ido Yariv
2011-07-12 9:22 ` Nori, Sekhar
2011-07-12 22:19 ` Ido Yariv
2011-07-10 13:14 ` [PATCH v2 2/6] arm: davinci: Explicitly set channel controllers' default queues Ido Yariv
2011-07-25 13:15 ` Nori, Sekhar
2011-07-25 13:33 ` Sergei Shtylyov
2011-07-25 16:31 ` Nori, Sekhar
2011-07-29 14:42 ` Ben Gardiner
2011-07-10 13:14 ` [PATCH v2 3/6] arm: davinci: mmc: Add support for set_power callback Ido Yariv
2011-07-25 13:19 ` Nori, Sekhar
2011-07-28 20:49 ` [PATCH REPOST v2] mmc: davinci: " Ido Yariv
2011-07-28 22:02 ` Chris Ball
2011-07-10 13:14 ` [PATCH v2 4/6] arm: davinci: DA850: Add MMC/SD1 pinmux configuration Ido Yariv
2011-07-10 13:14 ` [PATCH v2 5/6] arm: davinci: DA850: Add GPIO pinmux configuration for wl1271 Ido Yariv
2011-07-25 13:23 ` Nori, Sekhar
2011-07-10 13:14 ` [PATCH v2 6/6] arm: davinci: DA850: Add wl1271/wlan support Ido Yariv
2011-07-25 17:40 ` Nori, Sekhar
2011-07-28 18:34 ` Ido Yariv
2011-07-28 20:52 ` [PATCH v3] davinci: Add wl1271/wlan support for AM18x Ido Yariv
2011-07-28 21:15 ` Troy Kisky
2011-07-28 22:06 ` Ido Yariv
2011-07-29 18:51 ` Troy Kisky [this message]
2011-08-03 13:27 ` Nori, Sekhar
2011-08-04 7:51 ` [PATCH v4] ARM: davinci: AM18x: Add wl1271/wlan support Ido Yariv
2011-08-04 8:40 ` Jaya Kumar
2011-08-04 9:22 ` Ido Yariv
2011-09-01 11:59 ` Nori, Sekhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E330142.6040809@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).