linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jochen@scram.de (Jochen Friedrich)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 17/18] mach-sa1100: retire custom LED code
Date: Mon, 15 Aug 2011 13:19:17 +0200	[thread overview]
Message-ID: <4E4900B5.8000708@scram.de> (raw)
In-Reply-To: <1312977952-2272-18-git-send-email-bryan.wu@canonical.com>

Hi Bryan,

> diff --git a/arch/arm/mach-sa1100/badge4.c b/arch/arm/mach-sa1100/badge4.c
> index b4311b0..2e370c6c 100644
> --- a/arch/arm/mach-sa1100/badge4.c
> +++ b/arch/arm/mach-sa1100/badge4.c
> @@ -22,6 +22,8 @@
>   #include<linux/mtd/mtd.h>
>   #include<linux/mtd/partitions.h>
>   #include<linux/errno.h>
> +#include<linux/gpio.h>
> +#include<linux/leds.h>
>
>   #include<mach/hardware.h>
>   #include<asm/mach-types.h>
> @@ -69,8 +71,36 @@ static struct platform_device sa1111_device = {
>   	.resource	= sa1111_resources,
>   };
>
> +/* LEDs */
> +struct gpio_led badge4_gpio_leds[] = {
> +	{
> +		.name			= "badge4:red",
> +		.default_trigger	= "heartbeat",
> +		.gpio			= 7,
> +	},
> +	{
> +		.name			= "badge4:green",
> +		.default_trigger	= "cpu0",
> +		.gpio			= 9,
> +	},
> +};
> +
> +static struct gpio_led_platform_data badge4_gpio_led_info = {
> +	.leds		= badge4_gpio_leds,
> +	.num_leds	= ARRAY_SIZE(badge4_gpio_leds),
> +};
> +
> +static struct platform_device badge4_leds = {
> +	.name	= "leds-gpio",
> +	.id	= -1,
> +	.dev	= {
> +		.platform_data	=&badge4_gpio_led_info,
> +	}
> +};
> +
>   static struct platform_device *devices[] __initdata = {
>   	&sa1111_device,
> +	&badge4_leds;

Typo. This should be &badge4_leds,

>   };
>
>   static int __init badge4_sa1111_init(void)

Thanks,
Jochen

  reply	other threads:[~2011-08-15 11:19 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-10 12:05 [PATCH v3 00/18] Introduce a led trigger for CPU activity and consolidate LED driver in ARM Bryan Wu
2011-08-10 12:05 ` [PATCH 01/18] led-triggers: use atomic kzalloc during led trigger registering Bryan Wu
2011-08-10 12:05 ` [PATCH 02/18] led-triggers: create a trigger for CPU activity Bryan Wu
2011-08-10 13:06   ` Jamie Iles
2011-08-10 13:11     ` Jochen Friedrich
2011-08-10 12:05 ` [PATCH 03/18] arm: at91: convert old leds drivers to gpio_led and led_trigger drivers Bryan Wu
2011-08-10 12:05 ` [PATCH 04/18] mach-realview and mach-versatile: retire custom LED code Bryan Wu
2011-08-10 12:05 ` [PATCH 05/18] mach-ks8695: remove leds driver, since nobody use it Bryan Wu
2011-08-10 12:05 ` [PATCH 06/18] mach-shark: retire custom LED code Bryan Wu
2011-08-10 12:05 ` [PATCH 07/18] mach-orion5x: convert custom LED code to gpio_led and LED CPU trigger Bryan Wu
2011-08-10 12:05 ` [PATCH 08/18] mach-integrator: move CM_CTRL to header file for accessing by other functions Bryan Wu
2011-08-10 12:05 ` [PATCH 09/18] mach-integrator: retire custom LED code Bryan Wu
2011-08-10 12:05 ` [PATCH 10/18] mach-clps711x: retire custom LED code of P720T machine Bryan Wu
2011-08-10 12:05 ` [PATCH 11/18] mach-ebsa110: retire custom LED code Bryan Wu
2011-08-10 12:05 ` [PATCH 12/18] mach-footbridge: " Bryan Wu
2011-08-10 12:05 ` [PATCH 13/18] mach-pxa: " Bryan Wu
2011-08-10 12:05 ` [PATCH 14/18] plat-samsung: remove including old leds event API header file Bryan Wu
2011-08-10 12:05 ` [PATCH 15/18] mach-pnx4008: " Bryan Wu
2011-08-10 12:05 ` [PATCH 16/18] mach-omap1: retire custom LED code Bryan Wu
2011-08-10 12:05 ` [PATCH 17/18] mach-sa1100: " Bryan Wu
2011-08-15 11:19   ` Jochen Friedrich [this message]
2011-08-17 11:07     ` Bryan Wu
2011-08-10 12:05 ` [PATCH 18/18] ARM: use new LEDS CPU trigger stub to replace old one Bryan Wu
  -- strict thread matches above, loose matches on Subject: below --
2011-08-26  9:03 [PATCH v4 00/18] Introduce a led trigger for CPU activity and consolidate LED driver in ARM Bryan Wu
2011-08-26  9:03 ` [PATCH 17/18] mach-sa1100: retire custom LED code Bryan Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4900B5.8000708@scram.de \
    --to=jochen@scram.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).